highperfocused/bips
1
0
Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2025-03-17 13:22:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

BIPs 348 and 379: spelling fixups (#1715)

Browse Source 
* Update bip-0348.md

* Update bip-0379.md
This commit is contained in:
Danbo 2024-12-16 15:23:08 -05:00 committed by GitHub
parent 7150ef5f6d
commit 45fbec92cd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bip-0348.md
View File

@ -50,7 +50,7 @@ successful.
## Design Considerations
1. Message hashing: [BIP 340] is compatible with any size of message and does not require it to be a securely hashed input, so the message is not hashed prior to [BIP 340] verification.
2. Lack of verify semantics: Adding a single opcode for this purpose keeps the implementation and design simple. An earlier draft had a verify variant as a NOP upgrade, and if this funcationality is later brought to legacy scripts, that would be a good time to add a verify variant.
2. Lack of verify semantics: Adding a single opcode for this purpose keeps the implementation and design simple. An earlier draft had a verify variant as a NOP upgrade, and if this functionality is later brought to legacy scripts, that would be a good time to add a verify variant.
3. Add/multisig: No concession is made to `OP_CHECKMULTISIG` or `OP_CHECKSIGADD` semantics with `OP_CHECKSIGFROMSTACK`. In Tapscript, add semantics can be implemented with 1 additional vByte per key (`OP_TOALTSTACK OP_CHECKSIGFROMSTACK OP_FROMALTSTACK OP_ADD`).
4. Splitting R/S on the stack: Implementing split/separate signatures is left as an exercise for other bitcoin upgrades, such as [BIP 347] (`OP_CAT`).
5. APO-style ([BIP 118]) Taproot internal key: Rather than introducing an additional key type in this change, we suggest implementing `OP_INTERNALKEY` ([BIP 349]) or separately introducing that key type for all Tapscript signature checking operations in a separate change.

2
bip-0379.md
View File

@ -52,7 +52,7 @@ specifications apply to both. P2SH and bare scripts are excluded from this speci
### Translation Table
Miniscript consists of a set of script *fragments* which are designed to be safely and correctly composabe.
Miniscript consists of a set of script *fragments* which are designed to be safely and correctly composable.
This table shows all Miniscript *fragments* and their associated semantics and Bitcoin Script.
Fragments that do not change the semantics of their subexpressions are called *wrappers*. Normal