ephemeral behavior for redis (#2373)

* ephemeral behavior for redis

* notes for redis command line consistency
This commit is contained in:
rkuo-danswer
2024-09-12 21:48:50 -07:00
committed by GitHub
parent da8e68b320
commit 140c34e59e
6 changed files with 23 additions and 21 deletions

View File

@@ -346,12 +346,11 @@ services:
restart: always
ports:
- '6379:6379'
command: redis-server
volumes:
- cache_volume:/data
# docker silently mounts /data even without an explicit volume mount, which enables
# persistence. explicitly setting save and appendonly forces ephemeral behavior.
command: redis-server --save "" --appendonly no
volumes:
cache_volume:
db_volume:
vespa_volume: # Created by the container itself

View File

@@ -358,13 +358,12 @@ services:
restart: always
ports:
- '6379:6379'
command: redis-server
volumes:
- cache_volume:/data
# docker silently mounts /data even without an explicit volume mount, which enables
# persistence. explicitly setting save and appendonly forces ephemeral behavior.
command: redis-server --save "" --appendonly no
volumes:
cache_volume:
db_volume:
vespa_volume:
# Created by the container itself

View File

@@ -213,13 +213,12 @@ services:
restart: always
ports:
- '6379:6379'
command: redis-server
volumes:
- cache_volume:/data
# docker silently mounts /data even without an explicit volume mount, which enables
# persistence. explicitly setting save and appendonly forces ephemeral behavior.
command: redis-server --save "" --appendonly no
volumes:
cache_volume:
db_volume:
vespa_volume:
# Created by the container itself

View File

@@ -230,13 +230,12 @@ services:
restart: always
ports:
- '6379:6379'
command: redis-server
volumes:
- cache_volume:/data
# docker silently mounts /data even without an explicit volume mount, which enables
# persistence. explicitly setting save and appendonly forces ephemeral behavior.
command: redis-server --save "" --appendonly no
volumes:
cache_volume:
db_volume:
vespa_volume:
# Created by the container itself

View File

@@ -209,13 +209,12 @@ services:
restart: always
ports:
- '6379:6379'
command: redis-server
volumes:
- cache_volume:/data
# docker silently mounts /data even without an explicit volume mount, which enables
# persistence. explicitly setting save and appendonly forces ephemeral behavior.
command: redis-server --save "" --appendonly no
volumes:
cache_volume:
db_volume:
driver: local
driver_opts:

View File

@@ -38,4 +38,11 @@ spec:
name: danswer-secrets
key: redis_password
command: ["redis-server"]
args: ["--requirepass", "$(REDIS_PASSWORD)"]
args:
# save and appendonly are not strictly necessary because kubernetes doesn't mount
# /data silently like docker, but add the save and appendonly for consistency
[
"--requirepass", "$(REDIS_PASSWORD)",
"--save", "",
"--appendonly", "no"
]