ephemeral behavior for redis (#2373)

* ephemeral behavior for redis

* notes for redis command line consistency

deployment/docker_compose/docker-compose.dev.yml

@@ -346,12 +346,11 @@ services:
     restart: always
     ports:
       - '6379:6379'
-    command: redis-server
+    # docker silently mounts /data even without an explicit volume mount, which enables
-    volumes: 
+    # persistence. explicitly setting save and appendonly forces ephemeral behavior.
-      - cache_volume:/data
+    command: redis-server --save "" --appendonly no
 
 volumes:
-  cache_volume:
   db_volume:
   vespa_volume: # Created by the container itself
 

deployment/docker_compose/docker-compose.gpu-dev.yml

@@ -358,13 +358,12 @@ services:
     restart: always
     ports:
       - '6379:6379'
-    command: redis-server
+    # docker silently mounts /data even without an explicit volume mount, which enables
-    volumes: 
+    # persistence. explicitly setting save and appendonly forces ephemeral behavior.
-      - cache_volume:/data
+    command: redis-server --save "" --appendonly no
 
 
 volumes:
-  cache_volume:
   db_volume:
   vespa_volume:
   # Created by the container itself

deployment/docker_compose/docker-compose.prod-no-letsencrypt.yml

@@ -213,13 +213,12 @@ services:
     restart: always
     ports:
       - '6379:6379'
-    command: redis-server
+    # docker silently mounts /data even without an explicit volume mount, which enables
-    volumes: 
+    # persistence. explicitly setting save and appendonly forces ephemeral behavior.
-      - cache_volume:/data
+    command: redis-server --save "" --appendonly no
 
 
 volumes:
-  cache_volume:
   db_volume:
   vespa_volume:
   # Created by the container itself

deployment/docker_compose/docker-compose.prod.yml

@@ -230,13 +230,12 @@ services:
     restart: always
     ports:
       - '6379:6379'
-    command: redis-server
+    # docker silently mounts /data even without an explicit volume mount, which enables
-    volumes: 
+    # persistence. explicitly setting save and appendonly forces ephemeral behavior.
-      - cache_volume:/data
+    command: redis-server --save "" --appendonly no
 
 
 volumes:
-  cache_volume:
   db_volume:
   vespa_volume:
   # Created by the container itself

deployment/docker_compose/docker-compose.search-testing.yml

@@ -209,13 +209,12 @@ services:
     restart: always
     ports:
       - '6379:6379'
-    command: redis-server
+    # docker silently mounts /data even without an explicit volume mount, which enables
-    volumes: 
+    # persistence. explicitly setting save and appendonly forces ephemeral behavior.
-      - cache_volume:/data
+    command: redis-server --save "" --appendonly no
 
 
 volumes:
-  cache_volume:
   db_volume:
     driver: local
     driver_opts:

deployment/kubernetes/redis-service-deployment.yaml

@@ -38,4 +38,11 @@ spec:
               name: danswer-secrets
               key: redis_password
         command: ["redis-server"]
-        args: ["--requirepass", "$(REDIS_PASSWORD)"]
+        args:
+          # save and appendonly are not strictly necessary because kubernetes doesn't mount
+          # /data silently like docker, but add the save and appendonly for consistency         
+          [
+            "--requirepass", "$(REDIS_PASSWORD)", 
+            "--save", "", 
+            "--appendonly", "no"
+          ]