highperfocused/danswer
1
0
Fork 0
mirror of https://github.com/danswer-ai/danswer.git synced 2025-03-26 17:51:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

made description optional for document sets (#3407)

Browse Source 
* made description optional for document sets

* update document set optional

* update alembic migration head

---------

Co-authored-by: pablodanswer <pablo@danswer.ai>
This commit is contained in:
hagen-danswer 2024-12-12 17:41:11 -08:00 committed by GitHub
parent c69b7fc941
commit 54dcbfa288
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 34 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
backend/alembic/versions/94dc3d0236f8_make_document_set_description_optional.py Normal file
View File

@ -0,0 +1,30 @@
"""make document set description optional
Revision ID: 94dc3d0236f8
Revises: bf7a81109301
Create Date: 2024-12-11 11:26:10.616722
"""
from alembic import op
import sqlalchemy as sa
# revision identifiers, used by Alembic.
revision = "94dc3d0236f8"
down_revision = "bf7a81109301"
branch_labels = None
depends_on = None
def upgrade() -> None:
# Make document_set.description column nullable
op.alter_column(
"document_set", "description", existing_type=sa.String(), nullable=True
)
def downgrade() -> None:
# Revert document_set.description column to non-nullable
op.alter_column(
"document_set", "description", existing_type=sa.String(), nullable=False
)

2
backend/danswer/db/models.py
View File

@ -1226,7 +1226,7 @@ class DocumentSet(Base):
id: Mapped[int] = mapped_column(Integer, primary_key=True)
name: Mapped[str] = mapped_column(String, unique=True)
description: Mapped[str] = mapped_column(String)
description: Mapped[str | None] = mapped_column(String)
user_id: Mapped[UUID | None] = mapped_column(
ForeignKey("user.id", ondelete="CASCADE"), nullable=True
)

2
backend/danswer/server/features/document_set/models.py
View File

@ -44,7 +44,7 @@ class CheckDocSetPublicResponse(BaseModel):
class DocumentSet(BaseModel):
id: int
name: str
description: str
description: str | None
cc_pair_descriptors: list[ConnectorCredentialPairDescriptor]
is_up_to_date: bool
is_public: bool

5
web/src/app/admin/documents/sets/DocumentSetCreationForm.tsx
View File

@ -65,9 +65,7 @@ export const DocumentSetCreationForm = ({
}}
validationSchema={Yup.object().shape({
name: Yup.string().required("Please enter a name for the set"),
description: Yup.string().required(
"Please enter a description for the set"
),
description: Yup.string().optional(),
cc_pair_ids: Yup.array()
.of(Yup.number().required())
.required("Please select at least one connector"),
@ -125,6 +123,7 @@ export const DocumentSetCreationForm = ({
label="Description:"
placeholder="Describe what the document set represents"
autoCompleteDisabled={true}
optional={true}
/>
{isPaidEnterpriseFeaturesEnabled && (