Merge pull request #3893 from onyx-dot-app/mypy_random

Mypy random fixes

backend/tests/daily/connectors/confluence/test_confluence_basic.py

@@ -6,6 +6,7 @@ from unittest.mock import patch
 import pytest
 
 from onyx.connectors.confluence.connector import ConfluenceConnector
+from onyx.connectors.models import Document
 
 
 @pytest.fixture
@@ -41,6 +42,10 @@ def test_confluence_connector_basic(
 
     assert len(doc_batch) == 3
 
+    page_within_a_page_doc: Document | None = None
+    page_doc: Document | None = None
+    txt_doc: Document | None = None
+
     for doc in doc_batch:
         if doc.semantic_identifier == "DailyConnectorTestSpace Home":
             page_doc = doc
@@ -49,6 +54,7 @@ def test_confluence_connector_basic(
         elif doc.semantic_identifier == "Page Within A Page":
             page_within_a_page_doc = doc
 
+    assert page_within_a_page_doc is not None
     assert page_within_a_page_doc.semantic_identifier == "Page Within A Page"
     assert page_within_a_page_doc.primary_owners
     assert page_within_a_page_doc.primary_owners[0].email == "hagen@danswer.ai"
@@ -62,6 +68,7 @@ def test_confluence_connector_basic(
         == "https://danswerai.atlassian.net/wiki/spaces/DailyConne/pages/200769540/Page+Within+A+Page"
     )
 
+    assert page_doc is not None
     assert page_doc.semantic_identifier == "DailyConnectorTestSpace Home"
     assert page_doc.metadata["labels"] == ["testlabel"]
     assert page_doc.primary_owners
@@ -75,6 +82,7 @@ def test_confluence_connector_basic(
         == "https://danswerai.atlassian.net/wiki/spaces/DailyConne/overview"
     )
 
+    assert txt_doc is not None
     assert txt_doc.semantic_identifier == "small-file.txt"
     assert len(txt_doc.sections) == 1
     assert txt_doc.sections[0].text == "small"

backend/tests/daily/connectors/gmail/test_gmail_connector.py

@@ -110,6 +110,8 @@ def test_docs_retrieval(
 
     for doc in retrieved_docs:
         id = doc.id
+        retrieved_primary_owner_emails: set[str | None] = set()
+        retrieved_secondary_owner_emails: set[str | None] = set()
         if doc.primary_owners:
             retrieved_primary_owner_emails = set(
                 [owner.email for owner in doc.primary_owners]

backend/tests/integration/common_utils/managers/user.py

@@ -165,6 +165,7 @@ class UserManager:
         target_status: bool,
         user_performing_action: DATestUser,
     ) -> DATestUser:
+        url_substring: str
         if target_status is True:
             url_substring = "activate"
         elif target_status is False:

backend/tests/integration/connector_job_tests/google/test_google_drive_permission_sync.py

@@ -54,6 +54,7 @@ def google_drive_test_env_setup() -> (
 
     service_account_key = os.environ["FULL_CONTROL_DRIVE_SERVICE_ACCOUNT"]
     drive_id: str | None = None
+    drive_service: GoogleDriveService | None = None
 
     try:
         credentials = {