highperfocused/danswer
1
0
Fork 0
mirror of https://github.com/danswer-ai/danswer.git synced 2025-04-01 00:18:18 +02:00
Code Issues Packages Projects Releases Wiki Activity

Only log vespa error on second attempt (#578)

Browse Source
This commit is contained in:
Chris Weaver 2023-10-15 21:36:25 -07:00 committed by GitHub
parent 595f61ea3a
commit a7ddb22e50
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
backend/danswer/datastores/vespa/store.py
View File

@ -179,6 +179,7 @@ def _index_vespa_chunk(
url: str,
headers: dict[str, str],
fields: dict[str, Any],
log_error: bool = True,
) -> Response:
logger.debug(f'Indexing to URL "{url}"')
res = requests.post(url, headers=headers, json={"fields": fields})
@ -186,14 +187,20 @@ def _index_vespa_chunk(
res.raise_for_status()
return res
except Exception as e:
logger.error(
f"Failed to index document: '{document.id}'. Got response: '{res.text}'"
)
if log_error:
logger.error(
f"Failed to index document: '{document.id}'. Got response: '{res.text}'"
)
raise e
vespa_url = f"{DOCUMENT_ID_ENDPOINT}/{vespa_chunk_id}"
try:
_index_chunk(vespa_url, json_header, vespa_document_fields)
_index_chunk(
url=vespa_url,
headers=json_header,
fields=vespa_document_fields,
log_error=False,
)
except HTTPError as e:
if cast(Response, e.response).status_code != 400:
raise e
@ -213,7 +220,12 @@ def _index_vespa_chunk(
vespa_document_fields[CONTENT_SUMMARY] = remove_invalid_unicode_chars(
cast(str, vespa_document_fields[CONTENT_SUMMARY])
)
_index_chunk(vespa_url, json_header, vespa_document_fields)
_index_chunk(
url=vespa_url,
headers=json_header,
fields=vespa_document_fields,
log_error=True,
)
return chunk_exists