highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avfilter/af_aiir: Avoid unchecked allocation

Browse Source 
W has not been checked at all; allocate it jointly with M
to fix this.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
This commit is contained in:
Andreas Rheinhardt
2024-05-24 09:48:12 +02:00
parent 37cc648fbd
commit 21bfc62642
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libavfilter/af_aiir.c
View File

@@ -828,17 +828,17 @@ static int convert_serial2parallel(AVFilterContext *ctx, int channels)
double *impulse = av_calloc(length, sizeof(*impulse)); double *impulse = av_calloc(length, sizeof(*impulse));
double *y = av_calloc(length, sizeof(*y)); double *y = av_calloc(length, sizeof(*y));
double *resp = av_calloc(length, sizeof(*resp)); double *resp = av_calloc(length, sizeof(*resp));
double *M = av_calloc((length - 1) * 2 * nb_biquads, sizeof(*M)); double *M = av_calloc((length - 1) * nb_biquads, 2 * 2 * sizeof(*M));
double *W = av_calloc((length - 1) * 2 * nb_biquads, sizeof(*W)); double *W;
if (!impulse || !y || !resp || !M) { if (!impulse || !y || !resp || !M) {
av_free(impulse); av_free(impulse);
av_free(y); av_free(y);
av_free(resp); av_free(resp);
av_free(M); av_free(M);
av_free(W);
return AVERROR(ENOMEM); return AVERROR(ENOMEM);
} }
W = M + (length - 1) * 2 * nb_biquads;
impulse[0] = 1.; impulse[0] = 1.;
@@ -877,7 +877,6 @@ static int convert_serial2parallel(AVFilterContext *ctx, int channels)
av_free(y); av_free(y);
av_free(resp); av_free(resp);
av_free(M); av_free(M);
av_free(W);
} }
return 0; return 0;