highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avformat/aviobuf: Don't check for overflow after it happened

Browse Source 
If adding two ints overflows, it doesn't matter whether the result will
be stored in an unsigned or not; and checking afterwards does not make it
retroactively defined.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
This commit is contained in:
Andreas Rheinhardt 2020-05-24 03:14:00 +02:00
parent 7aa7d68971
commit 28a078eded
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libavformat/aviobuf.c
View File

@ -1287,7 +1287,7 @@ static int dyn_buf_write(void *opaque, uint8_t *buf, int buf_size)
unsigned new_size, new_allocated_size; unsigned new_size, new_allocated_size;
/* reallocate buffer if needed */ /* reallocate buffer if needed */
new_size = d->pos + buf_size; new_size = (unsigned)d->pos + buf_size;
new_allocated_size = d->allocated_size; new_allocated_size = d->allocated_size;
if (new_size < d->pos || new_size > INT_MAX/2) if (new_size < d->pos || new_size > INT_MAX/2)
return -1; return -1;