highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avcodec/tests/avcodec: Sanity check AVCodec.priv_data_size

Browse Source 
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
This commit is contained in:
Andreas Rheinhardt
2021-09-24 04:36:14 +02:00
parent 5aac4b669a
commit 2b0f29507f
1 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
libavcodec/tests/avcodec.c
View File

@@ -16,6 +16,7 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#include "libavutil/opt.h"
#include "libavcodec/codec.h" #include "libavcodec/codec.h"
#include "libavcodec/codec_desc.h" #include "libavcodec/codec_desc.h"
@@ -34,6 +35,25 @@ do { \
#define ERR(msg) ERR_INTERNAL(msg, ) #define ERR(msg) ERR_INTERNAL(msg, )
#define ERR_EXT(msg, ...) ERR_INTERNAL(msg, , __VA_ARGS__) #define ERR_EXT(msg, ...) ERR_INTERNAL(msg, , __VA_ARGS__)
static int priv_data_size_wrong(const AVCodec *codec)
{
if (codec->priv_data_size < 0 ||
codec->priv_class && codec->priv_data_size < sizeof(AVClass*))
return 1;
if (!codec->priv_class || !codec->priv_class->option)
return 0;
for (const AVOption *opt = codec->priv_class->option; opt->name; opt++) {
if (opt->offset >= codec->priv_data_size ||
opt->type == AV_OPT_TYPE_CONST && opt->offset != 0 ||
opt->type != AV_OPT_TYPE_CONST && (opt->offset < sizeof(AVClass*) || opt->offset < 0)) {
AV_LOG("Option %s offset %d nonsensical\n",
opt->name, opt->offset);
return 1;
}
}
return 0;
}
int main(void){ int main(void){
void *iter = NULL; void *iter = NULL;
const AVCodec *codec = NULL; const AVCodec *codec = NULL;
@@ -92,6 +112,9 @@ int main(void){
if (!!codec->decode + !!codec->receive_frame != 1) if (!!codec->decode + !!codec->receive_frame != 1)
ERR("Decoder %s does not implement exactly one decode API.\n"); ERR("Decoder %s does not implement exactly one decode API.\n");
} }
if (priv_data_size_wrong(codec))
ERR_EXT("Private context of codec %s is impossibly-sized (size %d).",
codec->priv_data_size);
if (!(desc = avcodec_descriptor_get(codec->id))) { if (!(desc = avcodec_descriptor_get(codec->id))) {
ERR("Codec %s lacks a corresponding descriptor\n"); ERR("Codec %s lacks a corresponding descriptor\n");
} else if (desc->type != codec->type) } else if (desc->type != codec->type)