highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avformat/mxfdec: check avio_read(UID) result

Browse Source 
Fixes use of uninitialized memory
Fixes: msan_uninit-mem_7fc9ba2fd98e_82_02785736.mxf
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
Michael Niedermayer
2014-01-10 02:11:20 +01:00
parent 7f9697aa11
commit 4162ceea93
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libavformat/mxfdec.c
View File

@@ -487,7 +487,10 @@ static int mxf_read_partition_pack(void *arg, AVIOContext *pb, int tag, int size
partition->index_sid = avio_rb32(pb); partition->index_sid = avio_rb32(pb);
avio_skip(pb, 8); avio_skip(pb, 8);
partition->body_sid = avio_rb32(pb); partition->body_sid = avio_rb32(pb);
avio_read(pb, op, sizeof(UID)); if (avio_read(pb, op, sizeof(UID)) != sizeof(UID)) {
av_log(mxf->fc, AV_LOG_ERROR, "Failed reading UID\n");
return AVERROR_INVALIDDATA;
}
nb_essence_containers = avio_rb32(pb); nb_essence_containers = avio_rb32(pb);
/* some files don'thave FooterPartition set in every partition */ /* some files don'thave FooterPartition set in every partition */