highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avfilter/ff_insert_pad: fix order of operations

Browse Source 
Fixes out of bounds access
Fixes CID732170
Fixes CID732169

No filter is known to use this function in a way so the issue can be reproduced.

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit ab2bfb85d4)

Conflicts:

	libavfilter/avfilter.c
(cherry picked from commit 86591b244f3a27293153896813f5569b49b2f5c0)

Conflicts:

	libavfilter/avfilter.c
This commit is contained in:
Michael Niedermayer
2013-10-21 16:21:14 +02:00
parent da82be0cc0
commit 45dd7df83b
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libavfilter/avfilter.c
View File

@ -117,9 +117,9 @@ void ff_insert_pad(unsigned idx, unsigned *count, size_t padidx_off,
(*links)[idx] = NULL; (*links)[idx] = NULL;
(*count)++; (*count)++;
for (i = idx+1; i < *count; i++) for (i = idx + 1; i < *count; i++)
if (*links[i]) if ((*links)[i])
(*(unsigned *)((uint8_t *) *links[i] + padidx_off))++; (*(unsigned *)((uint8_t *) (*links)[i] + padidx_off))++;
} }
int avfilter_link(AVFilterContext *src, unsigned srcpad, int avfilter_link(AVFilterContext *src, unsigned srcpad,