highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avcodec/sonic: Check channels before deallocating

Browse Source 
Fixes: heap-buffer-overflow
Fixes: 25744/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5172961169113088

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit f249981976)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Michael Niedermayer
2020-09-24 22:20:39 +02:00
parent d23e7ce02a
commit 7abc2f9fea
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libavcodec/sonic.c
View File

@@ -980,9 +980,7 @@ static av_cold int sonic_decode_close(AVCodecContext *avctx)
av_freep(&s->int_samples); av_freep(&s->int_samples);
av_freep(&s->tap_quant); av_freep(&s->tap_quant);
av_freep(&s->predictor_k); av_freep(&s->predictor_k);
for (i = 0; i < MAX_CHANNELS; i++) {
for (i = 0; i < s->channels; i++)
{
av_freep(&s->predictor_state[i]); av_freep(&s->predictor_state[i]);
av_freep(&s->coded_samples[i]); av_freep(&s->coded_samples[i]);
} }