highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fftools/ffmpeg_enc: simplify error handling for decoded_side_data setup

Browse Source 
There is no need to free the already-added items, they will be freed
alongside the codec context. There is also little point in an error
message, as the only reason this can fail is malloc failure.
This commit is contained in:
Anton Khirnov
2024-03-23 13:58:25 +01:00
parent 6f2cb0923c
commit 8fc1e1358b
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
fftools/ffmpeg_enc.c
View File

@@ -198,17 +198,10 @@ int enc_open(void *opaque, const AVFrame *frame)
&enc_ctx->nb_decoded_side_data,
frame->side_data[i],
AV_FRAME_SIDE_DATA_FLAG_UNIQUE);
if (ret < 0) {
av_frame_side_data_free(
&enc_ctx->decoded_side_data,
&enc_ctx->nb_decoded_side_data);
av_log(NULL, AV_LOG_ERROR,
"failed to configure video encoder: %s!\n",
av_err2str(ret));
if (ret < 0)
return ret;
}
}
}
ret = set_encoder_id(of, ost);
if (ret < 0)