highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avcodec/diracdec: Fixes integer overflow

Browse Source 
Fixes: runtime error: signed integer overflow: 340018243 * 27 cannot be represented in type 'int'
Fixes: 2861/clusterfuzz-testcase-minimized-5361070510178304

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Michael Niedermayer
2017-08-15 03:32:44 +02:00
parent 1e6cab8745
commit 92da23093c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libavcodec/diracdec.c
View File

@@ -442,7 +442,7 @@ static av_cold int dirac_decode_end(AVCodecContext *avctx)
static inline int coeff_unpack_golomb(GetBitContext *gb, int qfactor, int qoffset) static inline int coeff_unpack_golomb(GetBitContext *gb, int qfactor, int qoffset)
{ {
int coeff = dirac_get_se_golomb(gb); int coeff = dirac_get_se_golomb(gb);
const int sign = FFSIGN(coeff); const unsigned sign = FFSIGN(coeff);
if (coeff) if (coeff)
coeff = sign*((sign * coeff * qfactor + qoffset) >> 2); coeff = sign*((sign * coeff * qfactor + qoffset) >> 2);
return coeff; return coeff;