highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lavc/aacpsdsp: fix R-V V stereo interpolate

Browse Source 
The penultimate loop iteration could pick any vl such that:
 vlenb/4 < vl <= vlenb/2
Thus if the total length is not a multiple of vlenb/2, the vfadd.vf
on the penultimate iteration would yield corrupt values for the last
iteration.

To avoid this, force vl = vlen/2 until the last iteration. Unfortunately
this latent bug is not reproducible with either hardware or QEMU as of now.
This commit is contained in:
Rémi Denis-Courmont
2023-12-17 17:14:05 +02:00
parent db32f75c63
commit cdd38a2ffe
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libavcodec/riscv/aacpsdsp_rvv.S
View File

@ -234,7 +234,8 @@ func ff_ps_stereo_interpolate_rvv, zve32f
vfmacc.vf v22, ft3, v24 vfmacc.vf v22, ft3, v24
fmul.s ft3, ft3, ft4 fmul.s ft3, ft3, ft4
1: 1:
vsetvli t0, a4, e32, m2, ta, ma min t0, t0, a4
vsetvli zero, t0, e32, m2, ta, ma
vlseg2e32.v v0, (a0) // v0:l_re, v2:l_im vlseg2e32.v v0, (a0) // v0:l_re, v2:l_im
sub a4, a4, t0 sub a4, a4, t0
vlseg2e32.v v4, (a1) // v4:r_re, v6:r_im vlseg2e32.v v4, (a1) // v4:r_re, v6:r_im