highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

aacenc_tns: fix out-of-bounds array access

Browse Source 
Since the coefficients are stepped up to order + 1 it was possible
that it went over TNS_MAX_ORDER. Also just return in case the only
coefficient is less than the threshold.

Signed-off-by: Rostislav Pehlivanov <atomnuker@gmail.com>
This commit is contained in:
Rostislav Pehlivanov
2015-08-29 19:21:35 +01:00
parent 902ac9ca74
commit e924967fd5
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libavcodec/aacenc_tns.c
View File

@ -97,6 +97,10 @@ static void process_tns_coeffs(TemporalNoiseShaping *tns, double *coef_raw,
break; break;
} }
} }
order = av_clip(order, 0, TNS_MAX_ORDER - 1);
*order_p = order;
if (!order)
return;
/* Step up procedure, convert to LPC coeffs */ /* Step up procedure, convert to LPC coeffs */
out[0] = 1.0f; out[0] = 1.0f;
@ -109,7 +113,6 @@ static void process_tns_coeffs(TemporalNoiseShaping *tns, double *coef_raw,
} }
out[i] = lpc[i-1]; out[i] = lpc[i-1];
} }
*order_p = order;
memcpy(lpc, out, TNS_MAX_ORDER*sizeof(float)); memcpy(lpc, out, TNS_MAX_ORDER*sizeof(float));
} }