libsecp256k1: use a static global context and add verification tests.

This commit is contained in:
fiatjaf
2024-05-29 15:40:57 -03:00
parent 427bfc7a4b
commit 31e0645afe
4 changed files with 34 additions and 25 deletions

View File

@@ -25,13 +25,9 @@ func BenchmarkSignatureVerification(b *testing.B) {
}) })
b.Run("libsecp256k1", func(b *testing.B) { b.Run("libsecp256k1", func(b *testing.B) {
c, err := NewContext()
if err != nil {
panic(err)
}
for i := 0; i < b.N; i++ { for i := 0; i < b.N; i++ {
for _, evt := range events { for _, evt := range events {
c.CheckSignature(evt) CheckSignature(evt)
} }
} }
}) })

View File

@@ -14,45 +14,38 @@ import (
"unsafe" "unsafe"
) )
type Context struct { var globalSecp256k1Context *C.secp256k1_context
ctx *C.secp256k1_context
}
func NewContext() (*Context, error) { func init() {
ctx := C.secp256k1_context_create(C.SECP256K1_CONTEXT_SIGN | C.SECP256K1_CONTEXT_VERIFY) globalSecp256k1Context = C.secp256k1_context_create(C.SECP256K1_CONTEXT_SIGN | C.SECP256K1_CONTEXT_VERIFY)
if ctx == nil { if globalSecp256k1Context == nil {
return nil, errors.New("failed to create secp256k1 context") panic("failed to create secp256k1 context")
} }
return &Context{ctx: ctx}, nil
} }
func (c *Context) Destroy() { func Sign(msg [32]byte, sk [32]byte) ([64]byte, error) {
C.secp256k1_context_destroy(c.ctx)
}
func (c *Context) Sign(msg [32]byte, sk [32]byte) ([64]byte, error) {
var sig [64]byte var sig [64]byte
var keypair C.secp256k1_keypair var keypair C.secp256k1_keypair
if C.secp256k1_keypair_create(c.ctx, &keypair, (*C.uchar)(unsafe.Pointer(&sk[0]))) != 1 { if C.secp256k1_keypair_create(globalSecp256k1Context, &keypair, (*C.uchar)(unsafe.Pointer(&sk[0]))) != 1 {
return sig, errors.New("failed to parse private key") return sig, errors.New("failed to parse private key")
} }
var random [32]byte var random [32]byte
rand.Read(random[:]) rand.Read(random[:])
if C.secp256k1_schnorrsig_sign32(c.ctx, (*C.uchar)(unsafe.Pointer(&sig[0])), (*C.uchar)(unsafe.Pointer(&msg[0])), &keypair, (*C.uchar)(unsafe.Pointer(&random[0]))) != 1 { if C.secp256k1_schnorrsig_sign32(globalSecp256k1Context, (*C.uchar)(unsafe.Pointer(&sig[0])), (*C.uchar)(unsafe.Pointer(&msg[0])), &keypair, (*C.uchar)(unsafe.Pointer(&random[0]))) != 1 {
return sig, errors.New("failed to sign message") return sig, errors.New("failed to sign message")
} }
return sig, nil return sig, nil
} }
func (c *Context) Verify(msg [32]byte, sig [64]byte, pk [32]byte) bool { func Verify(msg [32]byte, sig [64]byte, pk [32]byte) bool {
var xonly C.secp256k1_xonly_pubkey var xonly C.secp256k1_xonly_pubkey
if C.secp256k1_xonly_pubkey_parse(c.ctx, &xonly, (*C.uchar)(unsafe.Pointer(&pk[0]))) != 1 { if C.secp256k1_xonly_pubkey_parse(globalSecp256k1Context, &xonly, (*C.uchar)(unsafe.Pointer(&pk[0]))) != 1 {
return false return false
} }
return C.secp256k1_schnorrsig_verify(c.ctx, (*C.uchar)(unsafe.Pointer(&sig[0])), (*C.uchar)(unsafe.Pointer(&msg[0])), 32, &xonly) == 1 return C.secp256k1_schnorrsig_verify(globalSecp256k1Context, (*C.uchar)(unsafe.Pointer(&sig[0])), (*C.uchar)(unsafe.Pointer(&msg[0])), 32, &xonly) == 1
} }

View File

@@ -0,0 +1,20 @@
package libsecp256k1
import (
"encoding/json"
"testing"
"github.com/nbd-wtf/go-nostr"
"github.com/nbd-wtf/go-nostr/test_common"
"github.com/stretchr/testify/assert"
)
func TestEventVerification(t *testing.T) {
for _, jevt := range test_common.NormalEvents {
evt := &nostr.Event{}
json.Unmarshal([]byte(jevt), evt)
ok, _ := CheckSignature(evt)
shouldBe, _ := evt.CheckSignature()
assert.Equal(t, ok, shouldBe, "%s signature must be %s", jevt, shouldBe)
}
}

View File

@@ -8,7 +8,7 @@ import (
"github.com/nbd-wtf/go-nostr" "github.com/nbd-wtf/go-nostr"
) )
func (c *Context) CheckSignature(evt *nostr.Event) (bool, error) { func CheckSignature(evt *nostr.Event) (bool, error) {
var pk [32]byte var pk [32]byte
_, err := hex.Decode(pk[:], []byte(evt.PubKey)) _, err := hex.Decode(pk[:], []byte(evt.PubKey))
if err != nil { if err != nil {
@@ -22,5 +22,5 @@ func (c *Context) CheckSignature(evt *nostr.Event) (bool, error) {
} }
msg := sha256.Sum256(evt.Serialize()) msg := sha256.Sum256(evt.Serialize())
return c.Verify(msg, sig, pk), nil return Verify(msg, sig, pk), nil
} }