highperfocused/go-nostr
1
0
Fork 0
mirror of https://github.com/nbd-wtf/go-nostr.git synced 2025-11-15 16:50:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

hints: prevent malicious timestamp hints to bork calculations.

Browse Source
This commit is contained in:
fiatjaf
2024-11-28 21:29:47 -03:00
parent 2519cab5ae
commit 9df2fc8d7b
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/hints/memory/db.go
View File

@@ -27,6 +27,10 @@ func NewHintDB() *HintDB {
} }
func (db *HintDB) Save(pubkey string, relay string, key hints.HintKey, ts nostr.Timestamp) { func (db *HintDB) Save(pubkey string, relay string, key hints.HintKey, ts nostr.Timestamp) {
if now := nostr.Now(); ts > now {
ts = now
}
relayIndex := slices.Index(db.RelayBySerial, relay) relayIndex := slices.Index(db.RelayBySerial, relay)
if relayIndex == -1 { if relayIndex == -1 {
relayIndex = len(db.RelayBySerial) relayIndex = len(db.RelayBySerial)

10
sdk/hints/sqlite/db.go
View File

@@ -87,11 +87,15 @@ func (sh SQLiteHints) TopN(pubkey string, n int) []string {
return res return res
} }
func (sh SQLiteHints) Save(pubkey string, relay string, key hints.HintKey, score nostr.Timestamp) { func (sh SQLiteHints) Save(pubkey string, relay string, key hints.HintKey, ts nostr.Timestamp) {
_, err := sh.saves[key].Exec(pubkey, relay, score, score) if now := nostr.Now(); ts > now {
ts = now
}
_, err := sh.saves[key].Exec(pubkey, relay, ts, ts)
if err != nil { if err != nil {
nostr.InfoLogger.Printf("[sdk/hints/sqlite] unexpected error on insert for %s, %s, %d: %s\n", nostr.InfoLogger.Printf("[sdk/hints/sqlite] unexpected error on insert for %s, %s, %d: %s\n",
pubkey, relay, score, err) pubkey, relay, ts, err)
} }
} }