highperfocused/lnbits
1
0
Fork 0
mirror of https://github.com/lnbits/lnbits.git synced 2025-10-10 20:42:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

Login polish (#2180)

Browse Source 
* feat: set `samesite="none", secure=True` for `is_lnbits_user_authorized` (required in iframe)
* feat: add icons for User ID actions
* feat: set `samesite="none", secure=True
This commit is contained in:
Vlad Stan
2023-12-14 16:07:22 +02:00
committed by GitHub
parent bb918a8523
commit db72953310
3 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lnbits/app.py
View File

@@ -524,7 +524,9 @@ def register_exception_handlers(app: FastAPI):
response = RedirectResponse("/") response = RedirectResponse("/")
response.delete_cookie("cookie_access_token") response.delete_cookie("cookie_access_token")
response.delete_cookie("is_lnbits_user_authorized") response.delete_cookie("is_lnbits_user_authorized")
response.set_cookie("is_access_token_expired", "true") response.set_cookie(
"is_access_token_expired", "true", samesite="none", secure=True
)
return response return response
return template_renderer().TemplateResponse( return template_renderer().TemplateResponse(

4
lnbits/core/templates/core/index.html
View File

@@ -52,10 +52,11 @@
rounded rounded
> >
<strong> <strong>
<q-icon name="account_circle" size="xs"></q-icon>
<span v-text="$t('login_with_user_id')"></span> </strong <span v-text="$t('login_with_user_id')"></span> </strong
></q-badge> ></q-badge>
{% if LNBITS_NEW_ACCOUNTS_ALLOWED %} {% if LNBITS_NEW_ACCOUNTS_ALLOWED %}
<span><span v-text="$t('or')"></span></span> <span v-text="$t('or')"></span>
<q-badge <q-badge
@click="showRegister('user-id-only')" @click="showRegister('user-id-only')"
color="primary" color="primary"
@@ -63,6 +64,7 @@
rounded rounded
> >
<strong> <strong>
<q-icon name="add" size="xs"></q-icon>
<span v-text="$t('create_new_wallet')"></span> <span v-text="$t('create_new_wallet')"></span>
</strong> </strong>
</q-badge> </q-badge>

8
lnbits/core/views/auth_api.py
View File

@@ -293,7 +293,9 @@ def _auth_success_response(
) )
response = JSONResponse({"access_token": access_token, "token_type": "bearer"}) response = JSONResponse({"access_token": access_token, "token_type": "bearer"})
response.set_cookie("cookie_access_token", access_token, httponly=True) response.set_cookie("cookie_access_token", access_token, httponly=True)
response.set_cookie("is_lnbits_user_authorized", "true") response.set_cookie(
"is_lnbits_user_authorized", "true", samesite="none", secure=True
)
response.delete_cookie("is_access_token_expired") response.delete_cookie("is_access_token_expired")
return response return response
@@ -303,7 +305,9 @@ def _auth_redirect_response(path: str, email: str) -> RedirectResponse:
access_token = create_access_token(data={"sub": "" or "", "email": email}) access_token = create_access_token(data={"sub": "" or "", "email": email})
response = RedirectResponse(path) response = RedirectResponse(path)
response.set_cookie("cookie_access_token", access_token, httponly=True) response.set_cookie("cookie_access_token", access_token, httponly=True)
response.set_cookie("is_lnbits_user_authorized", "true") response.set_cookie(
"is_lnbits_user_authorized", "true", samesite="none", secure=True
)
response.delete_cookie("is_access_token_expired") response.delete_cookie("is_access_token_expired")
return response return response