highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-07-04 04:21:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

itest: bind to local addr in network test

Browse Source 
This makes the test work even if the local OS has no outside network
connections available or if DNS lookups are failing.
This commit is contained in:
Matheus Degiovani
2023-07-21 16:24:30 -03:00
parent c3cd93c98a
commit 13399e9e81
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/release-notes/release-notes-0.17.0.md
View File

@ -148,6 +148,9 @@ unlock or create.
* [Simplify fuzz tests](https://github.com/lightningnetwork/lnd/pull/7709) * [Simplify fuzz tests](https://github.com/lightningnetwork/lnd/pull/7709)
using the `require` package. using the `require` package.
* [Removed](https://github.com/lightningnetwork/lnd/pull/7854) need for an
active internet connection for the network connection itest.
## `lncli` ## `lncli`
* Added ability to use [ENV variables to override `lncli` global flags](https://github.com/lightningnetwork/lnd/pull/7693). Flags will have preference over ENVs. * Added ability to use [ENV variables to override `lncli` global flags](https://github.com/lightningnetwork/lnd/pull/7693). Flags will have preference over ENVs.

14
itest/lnd_network_test.go
View File

@ -17,14 +17,20 @@ import (
// effect. It creates a node with a small connection timeout value, and // effect. It creates a node with a small connection timeout value, and
// connects it to a non-routable IP address. // connects it to a non-routable IP address.
func testNetworkConnectionTimeout(ht *lntest.HarnessTest) { func testNetworkConnectionTimeout(ht *lntest.HarnessTest) {
// Bind to a random port on localhost but never actually accept any
// connections. This makes any connection attempts timeout.
l, err := net.Listen("tcp", "127.0.0.1:0")
require.NoError(ht, err)
defer l.Close()
var ( var (
// testPub is a random public key for testing only. // testPub is a random public key for testing only.
testPub = "0332bda7da70fefe4b6ab92f53b3c4f4ee7999" + testPub = "0332bda7da70fefe4b6ab92f53b3c4f4ee7999" +
"f312284a8e89c8670bb3f67dbee2" "f312284a8e89c8670bb3f67dbee2"
// testHost is a reachable IP address with an unreachable port // testHost is the previously bound address that will never
// that's used for testing only. // accept any conns.
testHost = "lightning.engineering:81" testHost = l.Addr().String()
) )
// First, test the global timeout settings. // First, test the global timeout settings.
@ -62,7 +68,7 @@ func testNetworkConnectionTimeout(ht *lntest.HarnessTest) {
dave := ht.NewNode("Dave", nil) dave := ht.NewNode("Dave", nil)
// Try to connect Dave to a non-routable IP address, using a timeout // Try to connect Dave to a non-routable IP address, using a timeout
// value of 1ms, which should give us a timeout error immediately. // value of 1s, which should give us a timeout error immediately.
req = &lnrpc.ConnectPeerRequest{ req = &lnrpc.ConnectPeerRequest{
Addr: &lnrpc.LightningAddress{ Addr: &lnrpc.LightningAddress{
Pubkey: testPub, Pubkey: testPub,