routing+channeldb: use HTLCAttempt instead of HTLCAttemptInfo

This commit refactors the params used in lifecycle to prefer
`HTLCAttempt` over `HTLCAttemptInfo`. This change is needed as
`HTLCAttempt` also wraps settled and failure info, which is useful in
the following commits.

routing/control_tower_test.go

@@ -560,9 +560,9 @@ func genInfo() (*channeldb.PaymentCreationInfo, *channeldb.HTLCAttemptInfo,
 			CreationTime:      time.Unix(time.Now().Unix(), 0),
 			PaymentRequest:    []byte("hola"),
 		},
-		channeldb.NewHtlcAttemptInfo(
+		&channeldb.NewHtlcAttempt(
 			1, priv, testRoute, time.Time{}, nil,
-		), preimage, nil
+		).HTLCAttemptInfo, preimage, nil
 }
 
 func genPreimage() ([32]byte, error) {