highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-08-03 10:12:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

routing+channeldb: make MPPayment into an interface

Browse Source 
This commit turns `MPPayment` into an interface inside `routing`. Having
this interface gives us the benefit to write more granular unit tests
inside payment lifecycle. As seen from the modified unit tests, several
hacky ways of testing the `SendPayment` method is now replaced by a mock
over `MPPayment`.
This commit is contained in:
yyforyongyu
2023-02-09 12:51:43 +08:00
committed by Olaoluwa Osuntokun
parent c412ab5ccb
commit 34d0e5d4c5
8 changed files with 257 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
routing/control_tower_test.go
View File

@@ -130,9 +130,9 @@ func TestControlTowerSubscribeSuccess(t *testing.T) {
}
}
require.Equalf(t, channeldb.StatusSucceeded, result.Status,
require.Equalf(t, channeldb.StatusSucceeded, result.GetStatus(),
"subscriber %v failed, want %s, got %s", i,
channeldb.StatusSucceeded, result.Status)
channeldb.StatusSucceeded, result.GetStatus())
settle, _ := result.TerminalInfo()
if settle.Preimage != preimg {
@@ -259,7 +259,7 @@ func TestPaymentControlSubscribeAllSuccess(t *testing.T) {
result1 := results[info1.PaymentIdentifier]
require.Equal(
t, channeldb.StatusSucceeded, result1.Status,
t, channeldb.StatusSucceeded, result1.GetStatus(),
"unexpected payment state payment 1",
)
@@ -278,7 +278,7 @@ func TestPaymentControlSubscribeAllSuccess(t *testing.T) {
result2 := results[info2.PaymentIdentifier]
require.Equal(
t, channeldb.StatusSucceeded, result2.Status,
t, channeldb.StatusSucceeded, result2.GetStatus(),
"unexpected payment state payment 2",
)
@@ -486,7 +486,7 @@ func testPaymentControlSubscribeFail(t *testing.T, registerAttempt,
}
}
if result.Status == channeldb.StatusSucceeded {
if result.GetStatus() == channeldb.StatusSucceeded {
t.Fatal("unexpected payment state")
}
@@ -511,9 +511,9 @@ func testPaymentControlSubscribeFail(t *testing.T, registerAttempt,
len(result.HTLCs))
}
require.Equalf(t, channeldb.StatusFailed, result.Status,
require.Equalf(t, channeldb.StatusFailed, result.GetStatus(),
"subscriber %v failed, want %s, got %s", i,
channeldb.StatusFailed, result.Status)
channeldb.StatusFailed, result.GetStatus())
if *result.FailureReason != channeldb.FailureReasonTimeout {
t.Fatal("unexpected failure reason")