channeldb: unify Create/Open into simply Open

Open will now create, and initialize the db if it does not yet exist.
This commit is contained in:
Olaoluwa Osuntokun
2016-03-24 14:31:46 -07:00
parent 082a8a34e3
commit 3f5664b46d
3 changed files with 21 additions and 33 deletions

View File

@@ -3,16 +3,11 @@ package channeldb
import (
"io/ioutil"
"os"
"path/filepath"
"testing"
)
func TestOpenNotCreated(t *testing.T) {
if _, err := Open("path doesn't exist"); err != ErrNoExists {
t.Fatalf("channeldb Open should fail due to non-existant dir")
}
}
func TestCreateThenOpen(t *testing.T) {
func TestOpenWithCreate(t *testing.T) {
// First, create a temporary directory to be used for the duration of
// this test.
tempDirName, err := ioutil.TempDir("", "channeldb")
@@ -21,8 +16,9 @@ func TestCreateThenOpen(t *testing.T) {
}
defer os.RemoveAll(tempDirName)
// Next, create channeldb for the first time.
cdb, err := Create(tempDirName)
// Next, open thereby creating channeldb for the first time.
dbPath := filepath.Join(tempDirName, "cdb")
cdb, err := Open(dbPath)
if err != nil {
t.Fatalf("unable to create channeldb: %v", err)
}
@@ -30,9 +26,8 @@ func TestCreateThenOpen(t *testing.T) {
t.Fatalf("unable to close channeldb: %v", err)
}
// Open should now succeed as the cdb was created above.
cdb, err = Open(tempDirName)
if err != nil {
t.Fatalf("unable to open channeldb: %v", err)
// The path should have been succesfully created.
if !fileExists(dbPath) {
t.Fatalf("channeldb failed to create data directory")
}
}