highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-07-05 04:54:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

sqldb: cleanup scope state reset by adding reset closure to ExecTx

Browse Source 
For SQL transactions, we often accumulate results in variables declared
outside the closure's scope. To eliminate the need for manually clearing
these containers, we introduce a reset function to ExecTx, mirroring the
approach already adopted in kvdb.
This commit is contained in:
Andras Banki-Horvath
2024-04-02 16:46:31 +02:00
parent c6073a14ca
commit 478ae1e9b0
2 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sqldb/interfaces.go
View File

@ -52,7 +52,7 @@ type BatchedTx[Q any] interface {
// specify if a transaction should be read-only and optionally what
// type of concurrency control should be used.
ExecTx(ctx context.Context, txOptions TxOptions,
txBody func(Q) error) error
txBody func(Q) error, reset func()) error
}
// Tx represents a database transaction that can be committed or rolled back.
@ -317,7 +317,7 @@ func ExecuteSQLTransactionWithRetry(ctx context.Context, makeTx MakeTx,
// type of query and options run, in order to have access to batched operations
// related to a storage object.
func (t *TransactionExecutor[Q]) ExecTx(ctx context.Context,
txOptions TxOptions, txBody func(Q) error) error {
txOptions TxOptions, txBody func(Q) error, reset func()) error {
makeTx := func() (Tx, error) {
return t.BatchedQuerier.BeginTx(ctx, txOptions)
@ -328,6 +328,8 @@ func (t *TransactionExecutor[Q]) ExecTx(ctx context.Context,
if !ok {
return fmt.Errorf("expected *sql.Tx, got %T", tx)
}
reset()
return txBody(t.createQuery(sqlTx))
}