highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-09-06 17:47:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

chainntnfs: don't register notifications twice if details exist

Browse Source
This commit is contained in:
Oliver Gugger
2019-10-10 09:32:38 +02:00
parent e64493fe5b
commit 51c066e7ed
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
chainntnfs/txnotifier.go
View File

@@ -103,6 +103,9 @@ type confNtfnSet struct {
// details serves as a cache of the confirmation details of a // details serves as a cache of the confirmation details of a
// transaction that we'll use to determine if a transaction/output // transaction that we'll use to determine if a transaction/output
// script has already confirmed at the time of registration. // script has already confirmed at the time of registration.
// details is also used to make sure that in case of an address reuse
// (funds sent to a previously confirmed script) no additional
// notification is registered which would lead to an inconsistent state.
details *TxConfirmation details *TxConfirmation
} }
@@ -1507,6 +1510,15 @@ func (n *TxNotifier) handleConfDetailsAtTip(confRequest ConfRequest,
// TODO(wilmer): cancel pending historical rescans if any? // TODO(wilmer): cancel pending historical rescans if any?
confSet := n.confNotifications[confRequest] confSet := n.confNotifications[confRequest]
// If we already have details for this request, we don't want to add it
// again since we have already dispatched notifications for it.
if confSet.details != nil {
Log.Warnf("Ignoring address reuse for %s at height %d.",
confRequest, details.BlockHeight)
return
}
confSet.rescanStatus = rescanComplete confSet.rescanStatus = rescanComplete
confSet.details = details confSet.details = details