highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-10-10 01:42:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8615 from ProofOfKeags/bugfix/revert-compulsory-gossip-queries

Browse Source 
Revert "feature: make gossip queries compulsory"
This commit is contained in:
Oliver Gugger
2024-04-05 06:57:39 +00:00
committed by GitHub
parent e509657fac 939e3cc6c1
commit 6377f98536
4 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
docs/release-notes/release-notes-0.18.0.md
View File

@@ -392,6 +392,11 @@ bitcoin peers' feefilter values into account](https://github.com/lightningnetwor
and makes TLV Onions, Static Remote Keys, Gossip Queries, compulsory features and makes TLV Onions, Static Remote Keys, Gossip Queries, compulsory features
for LND's peers. Data Loss Protection has been compulsory for years. for LND's peers. Data Loss Protection has been compulsory for years.
* [Don't Require Gossip Queries](https://github.com/lightningnetwork/lnd/pull/8615)
This change undoes a portion of what was introduced in #8275 due to a subsequent
[spec change](https://github.com/lightning/bolts/pull/1092/commits/e0ee59f3c92b7c98be8dfc47b7db358b45baf9de)
that meant we shouldn't require it.
## Testing ## Testing
* Added fuzz tests for [onion * Added fuzz tests for [onion

2
feature/default_sets.go
View File

@@ -14,7 +14,7 @@ var defaultSetDesc = setDesc{
SetInit: {}, // I SetInit: {}, // I
SetNodeAnn: {}, // N SetNodeAnn: {}, // N
}, },
lnwire.GossipQueriesRequired: { lnwire.GossipQueriesOptional: {
SetInit: {}, // I SetInit: {}, // I
SetNodeAnn: {}, // N SetNodeAnn: {}, // N
}, },

8
feature/manager_internal_test.go
View File

@@ -151,7 +151,7 @@ func TestUpdateFeatureSets(t *testing.T) {
SetInit: {}, // I SetInit: {}, // I
SetNodeAnn: {}, // N SetNodeAnn: {}, // N
}, },
lnwire.GossipQueriesRequired: { lnwire.GossipQueriesOptional: {
SetNodeAnn: {}, // N SetNodeAnn: {}, // N
}, },
} }
@@ -201,7 +201,7 @@ func TestUpdateFeatureSets(t *testing.T) {
), ),
SetNodeAnn: lnwire.NewRawFeatureVector( SetNodeAnn: lnwire.NewRawFeatureVector(
lnwire.DataLossProtectRequired, lnwire.DataLossProtectRequired,
lnwire.GossipQueriesRequired, lnwire.GossipQueriesOptional,
lnwire.FeatureBit(1000), lnwire.FeatureBit(1000),
), ),
}, },
@@ -222,7 +222,7 @@ func TestUpdateFeatureSets(t *testing.T) {
), ),
SetNodeAnn: lnwire.NewRawFeatureVector( SetNodeAnn: lnwire.NewRawFeatureVector(
lnwire.DataLossProtectRequired, lnwire.DataLossProtectRequired,
lnwire.GossipQueriesRequired, lnwire.GossipQueriesOptional,
), ),
}, },
config: Config{ config: Config{
@@ -242,7 +242,7 @@ func TestUpdateFeatureSets(t *testing.T) {
), ),
SetNodeAnn: lnwire.NewRawFeatureVector( SetNodeAnn: lnwire.NewRawFeatureVector(
lnwire.DataLossProtectRequired, lnwire.DataLossProtectRequired,
lnwire.GossipQueriesRequired, lnwire.GossipQueriesOptional,
lnwire.FeatureBit(500), lnwire.FeatureBit(500),
), ),
SetInvoice: lnwire.NewRawFeatureVector( SetInvoice: lnwire.NewRawFeatureVector(

1
peer/brontide_test.go
View File

@@ -1138,7 +1138,6 @@ func TestPeerCustomMessage(t *testing.T) {
initReplyMsg := lnwire.NewInitMessage( initReplyMsg := lnwire.NewInitMessage(
lnwire.NewRawFeatureVector( lnwire.NewRawFeatureVector(
lnwire.DataLossProtectRequired, lnwire.DataLossProtectRequired,
lnwire.GossipQueriesOptional,
), ),
lnwire.NewRawFeatureVector(), lnwire.NewRawFeatureVector(),
) )