rpc: verify address is for correct net

Verify that the addresses we're decoding when sending coins onchain are
for the correct network. Without this check we'll convert the users
addresses to their equivalent on other networks, which is a gross
violation of the principle of least astonishment.
This commit is contained in:
Torkel Rogstad
2022-04-22 22:03:08 -04:00
committed by Oliver Gugger
parent 4ea24c0820
commit 681e3ceede
4 changed files with 31 additions and 3 deletions

View File

@@ -1104,6 +1104,12 @@ func (w *WalletKit) FundPsbt(_ context.Context,
"%s for network %s: %v", addrStr,
w.cfg.ChainParams.Name, err)
}
if !addr.IsForNet(w.cfg.ChainParams) {
return nil, fmt.Errorf("address is not for %s",
w.cfg.ChainParams.Name)
}
pkScript, err := txscript.PayToAddrScript(addr)
if err != nil {
return nil, fmt.Errorf("error getting pk "+