routing: store missioncontrol state in blocks and eliminate cursor use

This commit changes missioncontrol's store update from per payment to
every second. Updating the missioncontrol store on every payment caused
gradual slowdown when using etcd.
We also completely eliminate the use of the cursor, further reducing
the performance bottleneck.
This commit is contained in:
Andras Banki-Horvath
2021-06-25 22:22:12 +02:00
parent 79010cc097
commit 6d80ddfe91
7 changed files with 214 additions and 61 deletions

View File

@ -10,8 +10,8 @@ import (
"github.com/davecgh/go-spew/spew"
"github.com/lightningnetwork/lnd/kvdb"
"github.com/lightningnetwork/lnd/lnwire"
"github.com/lightningnetwork/lnd/routing/route"
"github.com/stretchr/testify/require"
)
const testMaxRecords = 2
@ -40,7 +40,7 @@ func TestMissionControlStore(t *testing.T) {
defer db.Close()
defer os.Remove(dbPath)
store, err := newMissionControlStore(db, testMaxRecords)
store, err := newMissionControlStore(db, testMaxRecords, time.Second)
if err != nil {
t.Fatal(err)
}
@ -80,27 +80,21 @@ func TestMissionControlStore(t *testing.T) {
result2.id = 2
// Store result.
err = store.AddResult(&result2)
if err != nil {
t.Fatal(err)
}
store.AddResult(&result2)
// Store again to test idempotency.
err = store.AddResult(&result2)
if err != nil {
t.Fatal(err)
}
store.AddResult(&result2)
// Store second result which has an earlier timestamp.
err = store.AddResult(&result1)
if err != nil {
t.Fatal(err)
}
store.AddResult(&result1)
require.NoError(t, store.storeResults())
results, err = store.fetchAll()
if err != nil {
t.Fatal(err)
}
require.Equal(t, 2, len(results))
if len(results) != 2 {
t.Fatal("expected two results")
}
@ -116,7 +110,7 @@ func TestMissionControlStore(t *testing.T) {
}
// Recreate store to test pruning.
store, err = newMissionControlStore(db, testMaxRecords)
store, err = newMissionControlStore(db, testMaxRecords, time.Second)
if err != nil {
t.Fatal(err)
}
@ -128,16 +122,15 @@ func TestMissionControlStore(t *testing.T) {
result3.id = 3
result3.failure = &lnwire.FailMPPTimeout{}
err = store.AddResult(&result3)
if err != nil {
t.Fatal(err)
}
store.AddResult(&result3)
require.NoError(t, store.storeResults())
// Check that results are pruned.
results, err = store.fetchAll()
if err != nil {
t.Fatal(err)
}
require.Equal(t, 2, len(results))
if len(results) != 2 {
t.Fatal("expected two results")
}