highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-09-30 06:05:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

invoices: remove redundant code

Browse Source 
HTLCSet already removes any HTLCs that are not in the desired state,
so doing it again on the same set is redundant.
This commit is contained in:
eugene
2022-05-11 13:46:48 -04:00
parent c2adb03e38
commit 6dcec862aa
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
invoices/update.go
View File

@@ -196,13 +196,6 @@ func updateMpp(ctx *invoiceUpdateCtx,
// Check whether total amt matches other htlcs in the set. // Check whether total amt matches other htlcs in the set.
var newSetTotal lnwire.MilliSatoshi var newSetTotal lnwire.MilliSatoshi
for _, htlc := range htlcSet { for _, htlc := range htlcSet {
// Only consider accepted mpp htlcs. It is possible that there
// are htlcs registered in the invoice database that previously
// timed out and are in the canceled state now.
if htlc.State != channeldb.HtlcStateAccepted {
continue
}
if ctx.mpp.TotalMsat() != htlc.MppTotalAmt { if ctx.mpp.TotalMsat() != htlc.MppTotalAmt {
return nil, ctx.failRes(ResultHtlcSetTotalMismatch), nil return nil, ctx.failRes(ResultHtlcSetTotalMismatch), nil
} }