highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-08-30 23:53:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

peer/lnwallet: persist shutdown info on send

Browse Source 
In this commit, we start persisting shutdown info when we send the
Shutdown message. When starting up a link, we also first check if we
have previously persisted Shutdown info and if we have, we start the
link in shutdown mode meaning that it will not accept any new outgoing
HTLC additions and it will queue the shutdown message after any pending
CommitSig has been sent.
This commit is contained in:
Elle Mouton
2024-02-06 19:11:26 +02:00
parent 5de7792520
commit 785790abed
3 changed files with 114 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
itest/lnd_coop_close_with_htlcs_test.go
View File

@@ -186,7 +186,7 @@ func coopCloseWithHTLCsWithRestart(ht *lntest.HarnessTest) {
DeliveryAddress: newAddr.Address,
})
// Assert that both nodes now see this channel as inactive.
// Assert that both nodes see the channel as waiting for close.
ht.AssertChannelInactive(bob, chanPoint)
ht.AssertChannelInactive(alice, chanPoint)
@@ -196,42 +196,35 @@ func coopCloseWithHTLCsWithRestart(ht *lntest.HarnessTest) {
ht.AssertConnected(alice, bob)
// Show that the channel is seen as active again by Alice and Bob.
//
// NOTE: This is a bug and will be fixed in an upcoming commit.
ht.AssertChannelActive(alice, chanPoint)
ht.AssertChannelActive(bob, chanPoint)
// Show that both nodes still see the channel as waiting for close after
// the restart.
ht.AssertChannelInactive(bob, chanPoint)
ht.AssertChannelInactive(alice, chanPoint)
// Let's settle the invoice.
// Settle the invoice.
alice.RPC.SettleInvoice(preimage[:])
// Wait for the channel to appear in the waiting closed list.
//
// NOTE: this will time out at the moment since there is a bug that
// results in shutdown not properly being re-started after a reconnect.
err := wait.Predicate(func() bool {
pendingChansResp := alice.RPC.PendingChannels()
waitingClosed := pendingChansResp.WaitingCloseChannels
return len(waitingClosed) == 1
}, defaultTimeout)
require.NoError(ht, err)
// We assert here that there is a timeout error. This will be fixed in
// an upcoming commit.
require.Error(ht, err)
// Wait for the close tx to be in the Mempool and then mine 6 blocks
// to confirm the close.
closingTx := ht.AssertClosingTxInMempool(
chanPoint, lnrpc.CommitmentType_LEGACY,
)
ht.MineBlocksAndAssertNumTxes(6, 1)
// Since the channel closure did not continue, we need to re-init the
// close.
closingTXID := ht.CloseChannel(alice, chanPoint)
// To further demonstrate the extent of the bug, we inspect the closing
// transaction here to show that the delivery address that Alice
// specified in her original close request is not the one that ended up
// being used.
//
// NOTE: this is a bug that will be fixed in an upcoming commit.
// Finally, we inspect the closing transaction here to show that the
// delivery address that Alice specified in her original close request
// is the one that ended up being used in the final closing transaction.
tx := alice.RPC.GetTransaction(&walletrpc.GetTransactionRequest{
Txid: closingTXID.String(),
Txid: closingTx.TxHash().String(),
})
require.Len(ht, tx.OutputDetails, 2)
@@ -245,6 +238,6 @@ func coopCloseWithHTLCsWithRestart(ht *lntest.HarnessTest) {
}
require.NotNil(ht, outputDetail)
// Show that the address used is not the one she requested.
require.NotEqual(ht, outputDetail.Address, newAddr.Address)
// Show that the address used is the one she requested.
require.Equal(ht, outputDetail.Address, newAddr.Address)
}