cmd/commands: don't error out on replacement failure

This commit is contained in:
Oliver Gugger
2024-10-15 09:58:39 +02:00
parent 5d60da54a3
commit 8c79940374
2 changed files with 10 additions and 20 deletions

View File

@@ -131,7 +131,6 @@ func TestReplaceCustomData(t *testing.T) {
data string
replaceData string
expected string
expectedErr string
}{
{
name: "no replacement necessary",
@@ -175,7 +174,8 @@ func TestReplaceCustomData(t *testing.T) {
name: "invalid json",
data: "this ain't json, " +
"\"custom_channel_data\":\"a\"",
expectedErr: "invalid character 'h' in literal true",
expected: "this ain't json, " +
"\"custom_channel_data\":\"a\"",
},
{
name: "valid json, invalid hex, just formatted",
@@ -186,15 +186,7 @@ func TestReplaceCustomData(t *testing.T) {
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
result, err := replaceCustomData([]byte(tc.data))
if tc.expectedErr != "" {
require.ErrorContains(t, err, tc.expectedErr)
return
}
require.NoError(t, err)
result := replaceCustomData([]byte(tc.data))
require.Equal(t, tc.expected, string(result))
})
}