highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-11-10 14:17:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

discovery: only send node_announcement associated with channels

Browse Source 
If a node doesn't have any channels, there's little point to send its
node_announcement as it cannot be used for routing.
This commit is contained in:
yyforyongyu
2025-07-23 17:54:25 +08:00
parent f00073e62c
commit 9cae62dcd7
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
discovery/chan_series.go
View File

@@ -120,6 +120,10 @@ func (c *ChanSeries) UpdatesInHorizon(chain chainhash.Hash,
if err != nil { if err != nil {
return nil, err return nil, err
} }
// nodesFromChan records the nodes seen from the channels.
nodesFromChan := make(map[[33]byte]struct{}, len(chansInHorizon)*2)
for _, channel := range chansInHorizon { for _, channel := range chansInHorizon {
// If the channel hasn't been fully advertised yet, or is a // If the channel hasn't been fully advertised yet, or is a
// private channel, then we'll skip it as we can't construct a // private channel, then we'll skip it as we can't construct a
@@ -181,6 +185,10 @@ func (c *ChanSeries) UpdatesInHorizon(chain chainhash.Hash,
// Append the all the msgs to the slice. // Append the all the msgs to the slice.
updates = append(updates, chanUpdates...) updates = append(updates, chanUpdates...)
// Record the nodes seen.
nodesFromChan[channel.Info.NodeKey1Bytes] = struct{}{}
nodesFromChan[channel.Info.NodeKey2Bytes] = struct{}{}
} }
// Next, we'll send out all the node announcements that have an update // Next, we'll send out all the node announcements that have an update
@@ -192,8 +200,15 @@ func (c *ChanSeries) UpdatesInHorizon(chain chainhash.Hash,
if err != nil { if err != nil {
return nil, err return nil, err
} }
for _, nodeAnn := range nodeAnnsInHorizon { for _, nodeAnn := range nodeAnnsInHorizon {
nodeAnn := nodeAnn // If this node has not been seen in the above channels, we can
// skip sending its NodeAnnouncement.
if _, seen := nodesFromChan[nodeAnn.PubKeyBytes]; !seen {
log.Debugf("Skipping forwarding as node %x not found "+
"in channel announcement", nodeAnn.PubKeyBytes)
continue
}
// Ensure we only forward nodes that are publicly advertised to // Ensure we only forward nodes that are publicly advertised to
// prevent leaking information about nodes. // prevent leaking information about nodes.