mirror of
https://github.com/lightningnetwork/lnd.git
synced 2025-06-30 10:35:32 +02:00
Merge pull request #6211 from carlaKC/github-prtemplate
github: simplify PR template and add more sections
This commit is contained in:
@ -687,28 +687,7 @@ default of 3 days to the given duration.
|
||||
|
||||
## Contribution Checklist
|
||||
|
||||
- [ ] All changes are Go version 1.12 compliant
|
||||
- [ ] The code being submitted is commented according to
|
||||
[Code Documentation and Commenting](#code-documentation-and-commenting)
|
||||
- [ ] For new code: Code is accompanied by tests which exercise both
|
||||
the positive and negative (error paths) conditions (if applicable)
|
||||
- [ ] For bug fixes: Code is accompanied by new tests which trigger
|
||||
the bug being fixed to prevent regressions
|
||||
- [ ] Any new logging statements use an appropriate subsystem and
|
||||
logging level
|
||||
- [ ] Code has been formatted with `go fmt`
|
||||
- [ ] For code and documentation: lines are wrapped at 80 characters
|
||||
(the tab character should be counted as 8 characters, not 4, as some IDEs do
|
||||
per default)
|
||||
- [ ] Running `make check` does not fail any tests
|
||||
- [ ] Running `go vet` does not report any issues
|
||||
- [ ] Running `make lint` does not report any **new** issues that
|
||||
did not already exist
|
||||
- [ ] All commits build properly and pass tests. Only in exceptional
|
||||
cases it can be justifiable to violate this condition. In that case, the
|
||||
reason should be stated in the commit message.
|
||||
- [ ] Commits have a logical structure according to
|
||||
[Ideal Git Commit Structure](#ideal-git-commit-structure).
|
||||
See [template](https://github.com/lightningnetwork/lnd/blob/master/.github/pull_request_template.md).
|
||||
|
||||
## Licensing of Contributions
|
||||
****
|
||||
|
Reference in New Issue
Block a user