highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-08-03 02:02:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

lnwallet: check coop close fee negative balance

Browse Source 
Also modify the test to check for this condition.
This commit is contained in:
Johan T. Halseth
2020-08-24 15:44:13 +02:00
parent 09a126b29f
commit a48c369250
3 changed files with 37 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lnwallet/commitment.go
View File

@@ -667,7 +667,7 @@ func CreateCommitTx(chanType channeldb.ChannelType,
// the cooperative close tx, given the channel type and transaction fee.
func CoopCloseBalance(chanType channeldb.ChannelType, isInitiator bool,
coopCloseFee btcutil.Amount, localCommit channeldb.ChannelCommitment) (
btcutil.Amount, btcutil.Amount) {
btcutil.Amount, btcutil.Amount, error) {
// Get both parties' balances from the latest commitment.
ourBalance := localCommit.LocalBalance.ToSatoshis()
@@ -693,7 +693,15 @@ func CoopCloseBalance(chanType channeldb.ChannelType, isInitiator bool,
theirBalance += initiatorDelta
}
return ourBalance, theirBalance
// During fee negotiation it should always be verified that the
// initiator can pay the proposed fee, but we do a sanity check just to
// be sure here.
if ourBalance < 0 || theirBalance < 0 {
return 0, 0, fmt.Errorf("initiator cannot afford proposed " +
"coop close fee")
}
return ourBalance, theirBalance, nil
}
// genHtlcScript generates the proper P2WSH public key scripts for the HTLC