btcwallet: skip unsupported addresses in ListTransasctionDetails

A transaction with an unsupported address would prevent the method from
returning any other transactions and would instead return an error.
This commit is contained in:
Wilmer Paulino
2020-08-25 11:21:29 -07:00
parent fac3c84806
commit a85c4feb17

View File

@@ -558,7 +558,9 @@ func minedTransactionsToDetails(
txOut.PkScript, chainParams, txOut.PkScript, chainParams,
) )
if err != nil { if err != nil {
return nil, err // Skip any unsupported addresses to prevent
// other transactions from not being returned.
continue
} }
destAddresses = append(destAddresses, outAddresses...) destAddresses = append(destAddresses, outAddresses...)
@@ -607,7 +609,9 @@ func unminedTransactionsToDetail(
_, outAddresses, _, err := _, outAddresses, _, err :=
txscript.ExtractPkScriptAddrs(txOut.PkScript, chainParams) txscript.ExtractPkScriptAddrs(txOut.PkScript, chainParams)
if err != nil { if err != nil {
return nil, err // Skip any unsupported addresses to prevent other
// transactions from not being returned.
continue
} }
destAddresses = append(destAddresses, outAddresses...) destAddresses = append(destAddresses, outAddresses...)