multi: rename nolint:lll to nolint:ll

Find and replace all nolint instances refering to the `lll` linter and
replace with `ll` which is the name of our custom version of the `lll`
linter which can be used to ignore log lines during linting.

The next commit will do the configuration of the custom linter and
disable the default one.

lncfg/autopilot.go

@@ -2,7 +2,7 @@ package lncfg
 
 // AutoPilot holds the configuration options for the daemon's autopilot.
 //
-//nolint:lll
+//nolint:ll
 type AutoPilot struct {
 	Active         bool               `long:"active" description:"If the autopilot agent should be active or not."`
 	Heuristic      map[string]float64 `long:"heuristic" description:"Heuristic to activate, and the weight to give it during scoring."`

lncfg/bitcoind.go

@@ -11,7 +11,7 @@ const (
 // Bitcoind holds the configuration options for the daemon's connection to
 // bitcoind.
 //
-//nolint:lll
+//nolint:ll
 type Bitcoind struct {
 	Dir                  string        `long:"dir" description:"The base directory that contains the node's data, logs, configuration file, etc."`
 	ConfigPath           string        `long:"config" description:"Configuration filepath. If not set, will default to the default filename under 'dir'."`

lncfg/btcd.go

@@ -2,7 +2,7 @@ package lncfg
 
 // Btcd holds the configuration options for the daemon's connection to btcd.
 //
-//nolint:lll
+//nolint:ll
 type Btcd struct {
 	Dir        string `long:"dir" description:"The base directory that contains the node's data, logs, configuration file, etc."`
 	RPCHost    string `long:"rpchost" description:"The daemon's rpc listening address. If a port is omitted, then the default port for the selected chain parameters will be used."`

lncfg/caches.go

@@ -21,7 +21,7 @@ const (
 
 // Caches holds the configuration for various caches within lnd.
 //
-//nolint:lll
+//nolint:ll
 type Caches struct {
 	// RejectCacheSize is the maximum number of entries stored in lnd's
 	// reject cache, which is used for efficiently rejecting gossip updates.

lncfg/chain.go

@@ -8,7 +8,7 @@ import (
 
 // Chain holds the configuration options for the daemon's chain settings.
 //
-//nolint:lll
+//nolint:ll
 type Chain struct {
 	Active   bool   `long:"active" description:"DEPRECATED: If the chain should be active or not. This field is now ignored since only the Bitcoin chain is supported" hidden:"true"`
 	ChainDir string `long:"chaindir" description:"The directory to store the chain's data within."`

lncfg/db.go

@@ -71,7 +71,7 @@ const (
 
 // DB holds database configuration for LND.
 //
-//nolint:lll
+//nolint:ll
 type DB struct {
 	Backend string `long:"backend" description:"The selected database backend."`
 

lncfg/dev_integration.go

@@ -19,7 +19,7 @@ func IsDevBuild() bool {
 // DevConfig specifies configs used for integration tests. These configs can
 // only be used in tests and must NOT be exported for production usage.
 //
-//nolint:lll
+//nolint:ll
 type DevConfig struct {
 	ProcessChannelReadyWait time.Duration `long:"processchannelreadywait" description:"Time to sleep before processing remote node's channel_ready message."`
 	ReservationTimeout      time.Duration `long:"reservationtimeout" description:"The maximum time we keep a pending channel open flow in memory."`

lncfg/fee.go

@@ -12,7 +12,7 @@ const DefaultMaxUpdateTimeout = 20 * time.Minute
 
 // Fee holds the configuration options for fee estimation.
 //
-//nolint:lll
+//nolint:ll
 type Fee struct {
 	URL              string        `long:"url" description:"Optional URL for external fee estimation. If no URL is specified, the method for fee estimation will depend on the chosen backend and network. Must be set for neutrino on mainnet."`
 	MinUpdateTimeout time.Duration `long:"min-update-timeout" description:"The minimum interval in which fees will be updated from the specified fee URL."`

lncfg/gossip.go

@@ -7,7 +7,7 @@ import (
 	"github.com/lightningnetwork/lnd/routing/route"
 )
 
-//nolint:lll
+//nolint:ll
 type Gossip struct {
 	PinnedSyncersRaw []string `long:"pinned-syncers" description:"A set of peers that should always remain in an active sync state, which can be used to closely synchronize the routing tables of two nodes. The value should be a hex-encoded pubkey, the flag can be specified multiple times to add multiple peers. Connected peers matching this pubkey will remain active for the duration of the connection and not count towards the NumActiveSyncer count."`
 

lncfg/healthcheck.go

@@ -23,7 +23,7 @@ var (
 // HealthCheckConfig contains the configuration for the different health checks
 // the lnd runs.
 //
-//nolint:lll
+//nolint:ll
 type HealthCheckConfig struct {
 	ChainCheck *CheckConfig `group:"chainbackend" namespace:"chainbackend"`
 

lncfg/htlcswitch.go

@@ -13,7 +13,7 @@ var (
 	MaxMailboxDeliveryTimeout = 2 * time.Minute
 )
 
-//nolint:lll
+//nolint:ll
 type Htlcswitch struct {
 	MailboxDeliveryTimeout time.Duration `long:"mailboxdeliverytimeout" description:"The timeout value when delivering HTLCs to a channel link. Setting this value too small will result in local payment failures if large number of payments are sent over a short period."`
 }

lncfg/invoices.go

@@ -36,7 +36,7 @@ const (
 
 // Invoices holds the configuration options for invoices.
 //
-//nolint:lll
+//nolint:ll
 type Invoices struct {
 	HoldExpiryDelta uint32 `long:"holdexpirydelta" description:"The number of blocks before a hold invoice's htlc expires that the invoice should be canceled to prevent a force close. Force closes will not be prevented if this value is not greater than DefaultIncomingBroadcastDelta."`
 }

lncfg/monitoring_on.go

@@ -6,7 +6,7 @@ package lncfg
 // Prometheus is the set of configuration data that specifies the listening
 // address of the Prometheus exporter.
 //
-//nolint:lll
+//nolint:ll
 type Prometheus struct {
 	// Listen is the listening address that we should use to allow the main
 	// Prometheus server to scrape our metrics.

lncfg/neutrino.go

@@ -5,7 +5,7 @@ import "time"
 // Neutrino holds the configuration options for the daemon's connection to
 // neutrino.
 //
-//nolint:lll
+//nolint:ll
 type Neutrino struct {
 	AddPeers           []string      `short:"a" long:"addpeer" description:"Add a peer to connect with at startup"`
 	ConnectPeers       []string      `long:"connect" description:"Connect only to the specified peers at startup"`

lncfg/pprof.go

@@ -7,7 +7,7 @@ import (
 
 // Pprof holds the configuration options for LND's built-in pprof server.
 //
-//nolint:lll
+//nolint:ll
 type Pprof struct {
 	CPUProfile string `long:"cpuprofile" description:"Write CPU profile to the specified file"`
 

lncfg/protocol.go

@@ -11,7 +11,7 @@ import (
 // compatibility of protocol additions, while defaulting to the latest within
 // lnd, or to enable experimental protocol changes.
 //
-//nolint:lll
+//nolint:ll
 type ProtocolOptions struct {
 	// LegacyProtocol is a sub-config that houses all the legacy protocol
 	// options.  These are mostly used for integration tests as most modern

lncfg/protocol_integration.go

@@ -13,7 +13,7 @@ import (
 //
 // TODO(yy): delete this build flag to unify with `lncfg/protocol.go`.
 //
-//nolint:lll
+//nolint:ll
 type ProtocolOptions struct {
 	// LegacyProtocol is a sub-config that houses all the legacy protocol
 	// options.  These are mostly used for integration tests as most modern

lncfg/protocol_legacy_on.go

@@ -7,7 +7,7 @@ package lncfg
 // are mostly used for integration tests as most modern nodes should always run
 // with them on by default.
 //
-//nolint:lll
+//nolint:ll
 type LegacyProtocol struct {
 	// LegacyOnionFormat if set to true, then we won't signal
 	// TLVOnionPayloadOptional. As a result, nodes that include us in the

lncfg/remotesigner.go

@@ -13,7 +13,7 @@ const (
 
 // RemoteSigner holds the configuration options for a remote RPC signer.
 //
-//nolint:lll
+//nolint:ll
 type RemoteSigner struct {
 	Enable           bool          `long:"enable" description:"Use a remote signer for signing any on-chain related transactions or messages. Only recommended if local wallet is initialized as watch-only. Remote signer must use the same seed/root key as the local watch-only wallet but must have private keys."`
 	RPCHost          string        `long:"rpchost" description:"The remote signer's RPC host:port"`

lncfg/routing.go

@@ -4,7 +4,7 @@ import "fmt"
 
 // Routing holds the configuration options for routing.
 //
-//nolint:lll
+//nolint:ll
 type Routing struct {
 	AssumeChannelValid bool `long:"assumechanvalid" description:"DEPRECATED: Skip checking channel spentness during graph validation. This speedup comes at the risk of using an unvalidated view of the network for routing. (default: false)" hidden:"true"`
 
@@ -15,7 +15,7 @@ type Routing struct {
 
 // BlindedPaths holds the configuration options for blinded path construction.
 //
-//nolint:lll
+//nolint:ll
 type BlindedPaths struct {
 	MinNumRealHops           uint8   `long:"min-num-real-hops" description:"The minimum number of real hops to include in a blinded path. This doesn't include our node, so if the minimum is 1, then the path will contain at minimum our node along with an introduction node hop. If it is zero then the shortest path will use our node as an introduction node."`
 	NumHops                  uint8   `long:"num-hops" description:"The number of hops to include in a blinded path. This doesn't include our node, so if it is 1, then the path will contain our node along with an introduction node or dummy node hop. If paths shorter than NumHops is found, then they will be padded using dummy hops."`

lncfg/rpcmiddleware.go

@@ -16,7 +16,7 @@ const (
 
 // RPCMiddleware holds the configuration for RPC interception middleware.
 //
-//nolint:lll
+//nolint:ll
 type RPCMiddleware struct {
 	Enable           bool          `long:"enable" description:"Enable the RPC middleware interceptor functionality."`
 	InterceptTimeout time.Duration `long:"intercepttimeout" description:"Time after which a RPC middleware intercept request will time out and return an error if it hasn't yet received a response."`

lncfg/sweeper.go

@@ -19,7 +19,7 @@ const (
 	MaxAllowedFeeRate = 10_000
 )
 
-//nolint:lll
+//nolint:ll
 type Sweeper struct {
 	BatchWindowDuration time.Duration        `long:"batchwindowduration" description:"Duration of the sweep batch window. The sweep is held back during the batch window to allow more inputs to be added and thereby lower the fee per input." hidden:"true"`
 	MaxFeeRate          chainfee.SatPerVByte `long:"maxfeerate" description:"Maximum fee rate in sat/vb that the sweeper is allowed to use when sweeping funds, the fee rate derived from budgets are capped at this value. Setting this value too low can result in transactions not being confirmed in time, causing HTLCs to expire hence potentially losing funds."`

lncfg/tor.go

@@ -2,7 +2,7 @@ package lncfg
 
 // Tor holds the configuration options for the daemon's connection to tor.
 //
-//nolint:lll
+//nolint:ll
 type Tor struct {
 	Active                      bool   `long:"active" description:"Allow outbound and inbound connections to be routed through Tor"`
 	SOCKS                       string `long:"socks" description:"The host:port that Tor's exposed SOCKS5 proxy is listening on"`

lncfg/watchtower.go

@@ -5,7 +5,7 @@ import "github.com/lightningnetwork/lnd/watchtower"
 // Watchtower holds the daemon specific configuration parameters for running a
 // watchtower that shares resources with the daemon.
 //
-//nolint:lll
+//nolint:ll
 type Watchtower struct {
 	Active bool `long:"active" description:"If the watchtower should be active or not"`
 

lncfg/workers.go

@@ -19,7 +19,7 @@ const (
 // Workers exposes CLI configuration for turning resources consumed by worker
 // pools.
 //
-//nolint:lll
+//nolint:ll
 type Workers struct {
 	// Read is the maximum number of concurrent read pool workers.
 	Read int `long:"read" description:"Maximum number of concurrent read pool workers. This number should be proportional to the number of peers."`

lncfg/wtclient.go

@@ -9,7 +9,7 @@ import (
 
 // WtClient holds the configuration options for the daemon's watchtower client.
 //
-//nolint:lll
+//nolint:ll
 type WtClient struct {
 	// Active determines whether a watchtower client should be created to
 	// back up channel states with registered watchtowers.