highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-09-23 08:11:48 +02:00
Code Issues Packages Projects Releases Wiki Activity

htlcswitch/test: allow missing field errors in payload decode

Browse Source
This commit is contained in:
Carla Kirk-Cohen
2023-11-03 14:24:52 -04:00
parent 69d5496e7c
commit af4fdcc1fd
1 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
htlcswitch/hop/fuzz_test.go
View File

@@ -122,15 +122,26 @@ func fuzzPayload(f *testing.F, finalPayload bool) {
var b bytes.Buffer var b bytes.Buffer
hop, nextChanID := hopFromPayload(payload1) hop, nextChanID := hopFromPayload(payload1)
err = hop.PackHopPayload(&b, nextChanID, finalPayload) err = hop.PackHopPayload(&b, nextChanID, finalPayload)
if errors.Is(err, route.ErrAMPMissingMPP) { switch {
// PackHopPayload refuses to encode an AMP record // PackHopPayload refuses to encode an AMP record
// without an MPP record. However, NewPayloadFromReader // without an MPP record. However, NewPayloadFromReader
// does allow decoding an AMP record without an MPP // does allow decoding an AMP record without an MPP
// record, since validation is done at a later stage. Do // record, since validation is done at a later stage. Do
// not report a bug for this case. // not report a bug for this case.
case errors.Is(err, route.ErrAMPMissingMPP):
return return
// PackHopPayload will not encode regular payloads or final
// hops in blinded routes that do not have an amount or expiry
// TLV set. However, NewPayloadFromReader will allow creation
// of payloads where these TLVs are present, but they have
// zero values because validation is done at a later stage.
case errors.Is(err, route.ErrMissingField):
return
default:
require.NoError(t, err)
} }
require.NoError(t, err)
payload2, err := NewPayloadFromReader(&b, finalPayload) payload2, err := NewPayloadFromReader(&b, finalPayload)
require.NoError(t, err) require.NoError(t, err)