Merge pull request #9279 from ellemouton/misc

misc: nil checks and remove deprecated default values
This commit is contained in:
Elle
2024-11-19 10:37:01 +02:00
committed by GitHub
3 changed files with 6 additions and 8 deletions

View File

@@ -562,8 +562,6 @@ func DefaultConfig() Config {
LetsEncryptDir: defaultLetsEncryptDir, LetsEncryptDir: defaultLetsEncryptDir,
LetsEncryptListen: defaultLetsEncryptListen, LetsEncryptListen: defaultLetsEncryptListen,
LogDir: defaultLogDir, LogDir: defaultLogDir,
MaxLogFiles: build.DefaultMaxLogFiles,
MaxLogFileSize: build.DefaultMaxLogFileSize,
AcceptorTimeout: defaultAcceptorTimeout, AcceptorTimeout: defaultAcceptorTimeout,
WSPingInterval: lnrpc.DefaultPingInterval, WSPingInterval: lnrpc.DefaultPingInterval,
WSPongWait: lnrpc.DefaultPongWait, WSPongWait: lnrpc.DefaultPongWait,
@@ -1417,7 +1415,7 @@ func ValidateConfig(cfg Config, interceptor signal.Interceptor, fileParser,
os.Exit(0) os.Exit(0)
} }
if cfg.MaxLogFiles != build.DefaultMaxLogFiles { if cfg.MaxLogFiles != 0 {
if cfg.LogConfig.File.MaxLogFiles != if cfg.LogConfig.File.MaxLogFiles !=
build.DefaultMaxLogFiles { build.DefaultMaxLogFiles {
@@ -1427,7 +1425,7 @@ func ValidateConfig(cfg Config, interceptor signal.Interceptor, fileParser,
cfg.LogConfig.File.MaxLogFiles = cfg.MaxLogFiles cfg.LogConfig.File.MaxLogFiles = cfg.MaxLogFiles
} }
if cfg.MaxLogFileSize != build.DefaultMaxLogFileSize { if cfg.MaxLogFileSize != 0 {
if cfg.LogConfig.File.MaxLogFileSize != if cfg.LogConfig.File.MaxLogFileSize !=
build.DefaultMaxLogFileSize { build.DefaultMaxLogFileSize {

View File

@@ -255,10 +255,10 @@ func (h *HarnessTest) AssertNumActiveEdges(hn *node.HarnessNode,
// filterDisabled is a helper closure that filters out disabled // filterDisabled is a helper closure that filters out disabled
// channels. // channels.
filterDisabled := func(edge *lnrpc.ChannelEdge) bool { filterDisabled := func(edge *lnrpc.ChannelEdge) bool {
if edge.Node1Policy.Disabled { if edge.Node1Policy != nil && edge.Node1Policy.Disabled {
return false return false
} }
if edge.Node2Policy.Disabled { if edge.Node2Policy != nil && edge.Node2Policy.Disabled {
return false return false
} }

View File

@@ -312,10 +312,10 @@ func (s *State) updateEdgeStats() {
// filterDisabled is a helper closure that filters out disabled // filterDisabled is a helper closure that filters out disabled
// channels. // channels.
filterDisabled := func(edge *lnrpc.ChannelEdge) bool { filterDisabled := func(edge *lnrpc.ChannelEdge) bool {
if edge.Node1Policy.Disabled { if edge.Node1Policy != nil && edge.Node1Policy.Disabled {
return false return false
} }
if edge.Node2Policy.Disabled { if edge.Node2Policy != nil && edge.Node2Policy.Disabled {
return false return false
} }