highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-06-29 02:00:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8377 from ellemouton/towerTestFlakeFix

Browse Source 
wtclient: ensure correct disk mode for overflow queue
This commit is contained in:
Oliver Gugger
2024-01-23 09:47:27 -06:00
committed by GitHub
parent 7d03b43ddf 65de80be7d
commit d7796b464e
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
docs/release-notes/release-notes-0.18.0.md
View File

@ -49,7 +49,7 @@
same exclusive group](https://github.com/lightningnetwork/lnd/pull/7800). same exclusive group](https://github.com/lightningnetwork/lnd/pull/7800).
When using neutrino as a backend unconfirmed transactions have to be When using neutrino as a backend unconfirmed transactions have to be
removed from the wallet when a conflicting tx is confirmed. For other backends removed from the wallet when a conflicting tx is confirmed. For other backends
these unconfirmed transactions are already removed. In addition a new these unconfirmed transactions are already removed. In addition, a new
walletrpc endpoint `RemoveTransaction` is introduced which let one easily walletrpc endpoint `RemoveTransaction` is introduced which let one easily
remove unconfirmed transaction manually. remove unconfirmed transaction manually.
@ -62,6 +62,9 @@
protects against the case where htlcs are added asynchronously resulting in protects against the case where htlcs are added asynchronously resulting in
stuck channels. stuck channels.
* [Fixed](https://github.com/lightningnetwork/lnd/pull/8377) a watchtower client
test flake that prevented new tasks from overflowing to disk.
* [Properly handle un-acked updates for exhausted watchtower * [Properly handle un-acked updates for exhausted watchtower
sessions](https://github.com/lightningnetwork/lnd/pull/8233) sessions](https://github.com/lightningnetwork/lnd/pull/8233)

7
watchtower/wtclient/queue.go
View File

@ -476,6 +476,13 @@ func (q *DiskOverflowQueue[T]) feedMemQueue() {
} }
} }
// If we did manage to fetch a task from disk, we make
// sure to set the toDisk mode to true since we may
// block indefinitely while trying to push the tasks to
// the memQueue in which case we want the drainInputList
// goroutine to write any new tasks to disk.
q.toDisk.Store(true)
for i, task := range tasks { for i, task := range tasks {
select { select {
case q.memQueue <- task: case q.memQueue <- task: