lnwire+lnd: Make Logging Messages Great Again

This commit modifies the login of sent/recv’d wire messages in trace
mode in order utilize the more detailed, and automatically generated
logging statements using pure spew.Sdump.

In order to avoid the spammy messages due to spew printing the
btcec.S256() curve paramter within wire messages with public keys, we
introduce a new logging function to unset the curve paramter to it
isn’t printed in its entirety. To insure we don’t run into any panics
as a result of a nil pointer defense, we now copy the public keys
during the funding process so we don’t run into a panic due to
modifying a pointer to the same object.

lnwire/htlc_addrequest.go

@@ -25,10 +25,7 @@ type HTLCAddRequest struct {
 	// sufficient expiry value to allow her to redeem the incmoing HTLC.
 	Expiry uint32
 
-	// Amount to pay in the hop
-	// Difference between hop and first item in blob is the fee to complete
-
-	// Amount is the number of credits this HTLC is worth.
+	// Amount of BTC that the HTLC is worth.
 	Amount btcutil.Amount
 
 	// RefundContext is for payment cancellation
@@ -148,24 +145,3 @@ func (c *HTLCAddRequest) Validate() error {
 	// We're good!
 	return nil
 }
-
-// String returns the string representation of the target HTLCAddRequest.
-//
-// This is part of the lnwire.Message interface.
-func (c *HTLCAddRequest) String() string {
-	var redemptionHashes string
-	for i, rh := range c.RedemptionHashes {
-		redemptionHashes += fmt.Sprintf("\n\tSlice\t%d\n", i)
-		redemptionHashes += fmt.Sprintf("\t\tRedemption Hash: %x\n", rh)
-	}
-
-	return fmt.Sprintf("\n--- Begin HTLCAddRequest ---\n") +
-		fmt.Sprintf("ChannelPoint:\t%v\n", c.ChannelPoint) +
-		fmt.Sprintf("Expiry:\t\t%d\n", c.Expiry) +
-		fmt.Sprintf("Amount\t\t%d\n", c.Amount) +
-		fmt.Sprintf("ContractType:\t%d (%b)\n", c.ContractType, c.ContractType) +
-		fmt.Sprintf("RedemptionHashes:") +
-		redemptionHashes +
-		fmt.Sprintf("OnionBlob:\t\t\t\t%x\n", c.OnionBlob) +
-		fmt.Sprintf("--- End HTLCAddRequest ---\n")
-}