highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-11-30 07:58:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

sqldb: establish a base DB version even if it's not yet tracked

Browse Source 
Previously, if a DB version wasn't available, we re-ran all schema
migrations without verifying the schema version. However, setting a
base schema version is essential because some earlier migrations were
not idempotent. This commit addresses the issue by using the current
schema version provided by sqlc as the base.
This commit is contained in:
Andras Banki-Horvath
2025-03-26 08:38:50 +01:00
parent 65b2bac81c
commit dae212697d
3 changed files with 62 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
sqldb/migrations.go
View File

@@ -112,6 +112,9 @@ type MigrationExecutor interface {
// order. Migration details are stored in the global variable
// migrationConfig.
ExecuteMigrations(target MigrationTarget) error
// GetSchemaVersion returns the current schema version of the database.
GetSchemaVersion() (int, bool, error)
}
var (
@@ -360,6 +363,22 @@ func ApplyMigrations(ctx context.Context, db *BaseDB,
}
currentVersion = int(version)
} else {
// Since we don't have a version tracked by our own table yet,
// we'll use the schema version reported by sqlc to determine
// the current version.
//
// NOTE: This is safe because the first in-code migration was
// introduced in version 7. This is only possible if the user
// has a schema version <= 4.
var dirty bool
currentVersion, dirty, err = migrator.GetSchemaVersion()
if err != nil {
return err
}
log.Infof("No database version found, using schema version %d "+
"(dirty=%v) as base version", currentVersion, dirty)
}
for _, migration := range migrations {