chainntnfs: ensure previous test succeeded before running

This commit is contained in:
yyforyongyu 2024-11-26 22:13:48 +08:00
parent fb429d658b
commit f03e242515
No known key found for this signature in database
GPG Key ID: 9BCD95C4FF296868
3 changed files with 20 additions and 4 deletions

View File

@ -109,11 +109,15 @@ func syncNotifierWithMiner(t *testing.T, notifier *BitcoindNotifier,
// TestHistoricalConfDetailsTxIndex ensures that we correctly retrieve // TestHistoricalConfDetailsTxIndex ensures that we correctly retrieve
// historical confirmation details using the backend node's txindex. // historical confirmation details using the backend node's txindex.
func TestHistoricalConfDetailsTxIndex(t *testing.T) { func TestHistoricalConfDetailsTxIndex(t *testing.T) {
t.Run("rpc polling enabled", func(st *testing.T) { success := t.Run("rpc polling enabled", func(st *testing.T) {
st.Parallel() st.Parallel()
testHistoricalConfDetailsTxIndex(st, true) testHistoricalConfDetailsTxIndex(st, true)
}) })
if !success {
return
}
t.Run("rpc polling disabled", func(st *testing.T) { t.Run("rpc polling disabled", func(st *testing.T) {
st.Parallel() st.Parallel()
testHistoricalConfDetailsTxIndex(st, false) testHistoricalConfDetailsTxIndex(st, false)
@ -207,11 +211,15 @@ func testHistoricalConfDetailsTxIndex(t *testing.T, rpcPolling bool) {
// historical confirmation details using the set of fallback methods when the // historical confirmation details using the set of fallback methods when the
// backend node's txindex is disabled. // backend node's txindex is disabled.
func TestHistoricalConfDetailsNoTxIndex(t *testing.T) { func TestHistoricalConfDetailsNoTxIndex(t *testing.T) {
t.Run("rpc polling enabled", func(st *testing.T) { success := t.Run("rpc polling enabled", func(st *testing.T) {
st.Parallel() st.Parallel()
testHistoricalConfDetailsNoTxIndex(st, true) testHistoricalConfDetailsNoTxIndex(st, true)
}) })
if !success {
return
}
t.Run("rpc polling disabled", func(st *testing.T) { t.Run("rpc polling disabled", func(st *testing.T) {
st.Parallel() st.Parallel()
testHistoricalConfDetailsNoTxIndex(st, false) testHistoricalConfDetailsNoTxIndex(st, false)

View File

@ -12,11 +12,15 @@ import (
// TestInterfaces executes the generic notifier test suite against a bitcoind // TestInterfaces executes the generic notifier test suite against a bitcoind
// powered chain notifier. // powered chain notifier.
func TestInterfaces(t *testing.T) { func TestInterfaces(t *testing.T) {
t.Run("bitcoind", func(st *testing.T) { success := t.Run("bitcoind", func(st *testing.T) {
st.Parallel() st.Parallel()
chainntnfstest.TestInterfaces(st, "bitcoind") chainntnfstest.TestInterfaces(st, "bitcoind")
}) })
if !success {
return
}
t.Run("bitcoind rpc polling", func(st *testing.T) { t.Run("bitcoind rpc polling", func(st *testing.T) {
st.Parallel() st.Parallel()
chainntnfstest.TestInterfaces(st, "bitcoind-rpc-polling") chainntnfstest.TestInterfaces(st, "bitcoind-rpc-polling")

View File

@ -173,7 +173,7 @@ func TestTxNotifierRegistrationValidation(t *testing.T) {
for _, testCase := range testCases { for _, testCase := range testCases {
testCase := testCase testCase := testCase
t.Run(testCase.name, func(t *testing.T) { success := t.Run(testCase.name, func(t *testing.T) {
hintCache := newMockHintCache() hintCache := newMockHintCache()
n := chainntnfs.NewTxNotifier( n := chainntnfs.NewTxNotifier(
10, chainntnfs.ReorgSafetyLimit, hintCache, hintCache, 10, chainntnfs.ReorgSafetyLimit, hintCache, hintCache,
@ -201,6 +201,10 @@ func TestTxNotifierRegistrationValidation(t *testing.T) {
"\"%v\", got \"%v\"", testCase.err, err) "\"%v\", got \"%v\"", testCase.err, err)
} }
}) })
if !success {
return
}
} }
} }