highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-06-20 13:53:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7158 from yyforyongyu/move-tx-label

Browse Source 
funding: mark tx label before notifying channel open event
This commit is contained in:
Oliver Gugger 2022-11-15 14:06:54 +01:00 committed by GitHub
commit f277f89e08
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/release-notes/release-notes-0.16.0.md
View File

@ -171,6 +171,9 @@ certain large transactions](https://github.com/lightningnetwork/lnd/pull/7100).
* [A new config option, `mailboxdeliverytimeout` has been added to * [A new config option, `mailboxdeliverytimeout` has been added to
`htlcswitch`](https://github.com/lightningnetwork/lnd/pull/7066). `htlcswitch`](https://github.com/lightningnetwork/lnd/pull/7066).
* [Label the openchannel tx first before notifying the channel open
event.](https://github.com/lightningnetwork/lnd/pull/7158)
## Code Health ## Code Health
* [test: use `T.TempDir` to create temporary test * [test: use `T.TempDir` to create temporary test

6
funding/manager.go
View File

@ -2815,13 +2815,13 @@ func (f *Manager) handleFundingConfirmation(
"%v", err) "%v", err)
} }
// Update the confirmed funding transaction label.
f.makeLabelForTx(completeChan)
// Inform the ChannelNotifier that the channel has transitioned from // Inform the ChannelNotifier that the channel has transitioned from
// pending open to open. // pending open to open.
f.cfg.NotifyOpenChannelEvent(completeChan.FundingOutpoint) f.cfg.NotifyOpenChannelEvent(completeChan.FundingOutpoint)
// Update the confirmed funding transaction label.
f.makeLabelForTx(completeChan)
// Close the discoverySignal channel, indicating to a separate // Close the discoverySignal channel, indicating to a separate
// goroutine that the channel now is marked as open in the database // goroutine that the channel now is marked as open in the database
// and that it is acceptable to process funding locked messages // and that it is acceptable to process funding locked messages