highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-09-26 18:26:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

channeldb: avoid modifying bucket during cursor traversal

Browse Source 
This is not safe according to bbolt documentation.
This commit is contained in:
Johan T. Halseth
2019-06-12 14:50:59 +02:00
parent ed8d635cf1
commit f98f452528
2 changed files with 18 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
channeldb/channel.go
View File

@@ -2087,10 +2087,6 @@ func (c *OpenChannel) CloseChannel(summary *ChannelCloseSummary) error {
// information stored within the revocation log.
logBucket := chanBucket.Bucket(revocationLogBucket)
if logBucket != nil {
err := wipeChannelLogEntries(logBucket)
if err != nil {
return err
}
err = chanBucket.DeleteBucket(revocationLogBucket)
if err != nil {
return err
@@ -2713,16 +2709,3 @@ func fetchChannelLogEntry(log *bbolt.Bucket,
commitReader := bytes.NewReader(commitBytes)
return deserializeChanCommit(commitReader)
}
func wipeChannelLogEntries(log *bbolt.Bucket) error {
// TODO(roasbeef): comment
logCursor := log.Cursor()
for k, _ := logCursor.First(); k != nil; k, _ = logCursor.Next() {
if err := logCursor.Delete(); err != nil {
return err
}
}
return nil
}