Commit Graph

18958 Commits

Author SHA1 Message Date
bitromortac
615b617cda routing: add test for fuzz test special case
This test demonstrates an error found in a fuzz test by adding a
previously found seed, which will be fixed in an upcoming commit.

The following fuzz test is expected to fail:
go test -v -fuzz=Prob ./routing/
2025-05-02 10:25:19 +02:00
bitromortac
04eec71d54 routing: use default tolerance for bimodal testing 2025-05-02 10:24:22 +02:00
bitromortac
55e7343b14 routing: update to realistic test values
The bimodal model doesn't depend on the unit, which is why updating to
more realistic values doesn't require changes in tests.

We pin the scale in the fuzz test to not invalidate the corpus.
2025-05-02 10:23:56 +02:00
bitromortac
5020e1f98b docs: update release notes 2025-05-02 08:43:04 +02:00
bitromortac
15f0888fa8 routing: fix mission control migration
This commit is temporary and demonstrates a panic. To be squashed with
the following commit.
2025-05-02 08:42:25 +02:00
bitromortac
aa9abb3d96 routing: make sure failure message is valid 2025-04-30 17:43:58 +02:00
bitromortac
a450d85309 routing: remove paymentFailure pointer
This introduces an option instead to signal whether there was a failure
for result interpretation.
2025-04-30 17:43:58 +02:00
bitromortac
4498a78cb0 routing: remove paymentFailureInfo
We can remove paymentFailureInfo since we can gate the result
interpretation on the source index, meaning that if we don't have a
source index, we deal with an unknown payment outcome because we
couldn't pinpoint the failing hop.
2025-04-30 17:43:57 +02:00
bitromortac
e5c541407f routing: make msg and index optional
This is later used to handle their nil values.
2025-04-30 17:42:53 +02:00
Oliver Gugger
b068d79dfb Merge pull request #9776 from saubyk/19.0-releasenotes-update
docs: update release notes with more detail on the RBF coop close section
2025-04-30 08:14:07 +02:00
saubyk
52e1764e0a docs: update release notes with more detail on the RBF coop close section 2025-04-29 21:07:51 -07:00
Yong
f21e3f3ee5 Merge pull request #9772 from yyforyongyu/show-all-inputs
sweep: return all inputs in `PendingSweeps`
2025-04-30 02:24:52 +08:00
yyforyongyu
b610678703 docs: update release notes 2025-04-29 14:15:36 +08:00
yyforyongyu
8f936aa9eb itest: update num of sweeps in AssertNumPendingSweeps
Since we now return all sweeps, we need to update the call to include
immature sweeps.
2025-04-29 14:15:31 +08:00
yyforyongyu
d991f5659a commands: add new field MaturityHeight 2025-04-29 13:49:22 +08:00
yyforyongyu
94463c6844 walletrpc: add new field MaturityHeight 2025-04-28 21:44:10 +08:00
yyforyongyu
0807ce61a1 sweep: return all inputs from PendingSweeps
Previously we'd skip returning immature inputs to stay backwards
compatible. This has the downside as the node operator cannot take
actions on this input, like some customized batching strategy via
`bumpfee` RPC.

After this change, it means when calling `bumpfee` RPC, it will now
update the params for the immature input instead of returning an error
saying `output does not belong to wallet`.

We also add a `MaturityHeight` field so the user knows when this input
will be swept.
2025-04-28 21:44:10 +08:00
Oliver Gugger
b34afa33f6 Merge pull request #9764 from ZZiigguurraatt/RBF-release-notes-cleanup
docs/release-notes: fix indentation in RBF close section
2025-04-28 12:38:23 +02:00
ZZiigguurraatt
cc3615c0a8 docs/release-notes: fix indentation in RBF close section 2025-04-25 15:06:57 -04:00
Oliver Gugger
7e50b8438e Merge pull request #9759 from guggero/fix-release
GitHub: fix order of operations for release build
2025-04-24 12:15:07 +02:00
Oliver Gugger
d9089b11ac GitHub: fix order of operations 2025-04-24 08:36:17 +02:00
Olaoluwa Osuntokun
bc4229b32e Merge pull request #9736 from Roasbeef/0-19-0-rc3
build: bump version to v0.19.0 rc3
v0.19.0-beta.rc3
2025-04-23 15:12:15 -07:00
Oliver Gugger
4862251833 Merge pull request #9750 from starius/fix-InternalKeyForAddr-for-imported-addresses
lnwallet: fix InternalKeyForAddr for imported addr
2025-04-23 17:53:13 +02:00
Boris Nagaev
dc2cad9b0f docs: update release-notes for 0.19.0 2025-04-23 11:53:30 -03:00
Boris Nagaev
c9b5974341 itest: test imported address in coop close
Make sure that an address imported to LND via ImportTapscript or ImportPublicKey
can be used as a delivery address in coop close.

New test cases:
 - P2TR address imported with ImportTapscript
 - P2TR address imported with ImportPublicKey
 - P2WPKH address imported with ImportPublicKey

Safeguard against https://github.com/lightninglabs/loop/issues/923
2025-04-23 11:53:29 -03:00
Boris Nagaev
6451ce495a itest: use prefixed sub-tests
More sub-tests are needed in "coop close with external delivery" itest, which
would break the limit for 50 blocks mined. Turning it into prefixed itest.

Also used new exclusion approach in test "remote signer" where all the prefixed
tests are excluded.
2025-04-23 11:52:39 -03:00
Boris Nagaev
429000e360 lnwallet: fix InternalKeyForAddr for imported addr
An address imported using ImportTapscript doesn't provide a private key
so it can't satisfy waddrmgr.ManagedPubKeyAddress interface. So we don't
return an error for imported addresses.
Fix https://github.com/lightninglabs/loop/issues/923
2025-04-23 11:17:00 -03:00
Boris Nagaev
b5c9df81f0 lnwallet: fix error message
Include the variable of interest (walletAddr), not the outcome of the check
(pubKeyAddr) which is always nil.
2025-04-23 11:17:00 -03:00
Oliver Gugger
a35ace7371 Merge pull request #9739 from ellemouton/rpcInterceptorMD
lnrpc+rpcperms: add ctx metadata pairs to RPCMiddlewareRequest
2025-04-23 11:21:32 +02:00
Oliver Gugger
1aad61c2b6 Merge pull request #9755 from guggero/payment-bandwidth-funding-blob
htlcswitch+routing: add funding blob to PaymentBandwidth
2025-04-22 22:23:45 +02:00
Oliver Gugger
56d2381f51 htlcswitch+routing: add funding blob to PaymentBandwidth
For certain auxiliary bandwidth checks we need to know the funding blob
that was present when the channel was created.
2025-04-22 21:21:11 +02:00
Oliver Gugger
987302923d Merge pull request #9746 from ziggie1984/make-resolution-more-efficient
lnwallet: no need to consult the aux unit for legacy channels
2025-04-22 18:56:28 +02:00
Elle Mouton
0417877038 docs: update release notes 2025-04-22 15:03:40 +02:00
Oliver Gugger
fba64c812b itest: test RPCMiddleware gRPC metadata propagation
Expand the rpc middleware test to assert gRPC metadata pair propagation
for rpc middleware requests.
2025-04-22 15:03:17 +02:00
Elle Mouton
e9fc852390 lnrpc+rpcperms: add ctx metadata pairs to RPCMiddlewareRequest
The MW interceptor works via a stream & sends requests to the
interceptor via this stream. Sometimes, the interceptor might want to
work with grpc metadata pairs that were sent via the context of the
original request though and so in this commit, we ensure that for each
request sent via the stream to the interceptr, the grpc metadata is sent
along explicitly as well. This is done by adding a new `metadata_pairs`
field to the RPCMiddlewareRequest proto message.
2025-04-22 15:03:17 +02:00
Olaoluwa Osuntokun
c9fe051b2f Merge pull request #9749 from ziggie1984/fix-logging-invoices-payments
mulit: increase logprogress time
2025-04-21 16:40:46 -07:00
ziggie
b9620a7dc3 mulit: increase logprogress time
Switched the batchsize to 30 seconds instead of number of payments
and invoices.
2025-04-22 00:01:16 +02:00
ziggie
98384b6f04 docs: add release-notes 2025-04-21 11:09:42 +02:00
ziggie
b2087a8a2e lnwallet: skip aux resolution call for non-anchor channels. 2025-04-21 11:09:00 +02:00
Olaoluwa Osuntokun
d2f9e97c57 build: bump version to v0.19.0 rc3 2025-04-18 16:18:24 -07:00
Olaoluwa Osuntokun
49faa6f543 build: bump kvdb version 2025-04-18 16:18:23 -07:00
Olaoluwa Osuntokun
cb481df816 Merge pull request #9719 from Roasbeef/accessman-log
accessman: add logging to new sub-system
kvdb/v1.4.16
2025-04-18 16:11:11 -07:00
Olaoluwa Osuntokun
9d53617586 Merge pull request #9734 from ziggie1984/improve-logging-for-invoices-payments
Improve logging when fetching invoices and payments
2025-04-18 16:10:45 -07:00
Olaoluwa Osuntokun
825ee3d40b Merge pull request #9723 from ziggie1984/add-global-lock-walletdb
Add the global lock for the wallet db back for postgres
2025-04-18 14:17:44 -07:00
ziggie
440ed31419 multi: add more logging when fetching invoices and payments. 2025-04-18 16:33:39 +02:00
ziggie
729c84bee3 lncli: return more clear error msg for deletepayments 2025-04-18 15:30:39 +02:00
Olaoluwa Osuntokun
21ca1e650b acessman: improve access manager logging and error handling
This commit adds logs to the new access manager. This'll help us monitor
the new system behavior, and may make debugging easier in the future.
2025-04-17 17:20:11 -07:00
Olaoluwa Osuntokun
6517104da6 lnutil: add LogPubKey helper function
This captures a common pattern where we want to log a peer's public key
along side each logging statement.
2025-04-17 17:20:09 -07:00
Oliver Gugger
51add8a701 Merge pull request #9722 from ziggie1984/fix-notifier-itest-flake
Change RPC call order for the btcd notifier
2025-04-17 22:50:07 +02:00
András Bánki-Horváth
579f6f0f68 Merge pull request #9724 from bhandras/fundpsbt-custom-input-lock
walletrpc: allow custom lock ID and duration in `FundPsbt`
2025-04-17 17:31:48 +02:00