mirror of
https://github.com/lightningnetwork/lnd.git
synced 2025-10-10 21:14:50 +02:00
f59fa7477d
The msgStream's backpressure queue previously used a drop predicate that always returned false, meaning messages were never dropped based on queue length. This commit introduces a new drop predicate mechanism for the msgStream queue, controlled by build tags. For non-integration builds, the predicate combines a type-based check with Random Early Detection (RED): - Certain critical message types (`lnwire.LinkUpdater`, `lnwire.AnnounceSignatures1`) are marked as protected and are never dropped. - For other message types, RED is applied based on the queue length, using `redMinThreshold` and `redMaxThreshold` to determine the drop probability. For integration builds, the predicate always returns false, preserving the previous behavior to avoid interfering with tests. This change allows the msgStream queue to proactively drop less critical messages under high load, preventing unbounded queue growth while ensuring essential messages are prioritized.
58 lines
1.5 KiB
Go
58 lines
1.5 KiB
Go
//go:build !integration
|
|
|
|
package peer
|
|
|
|
import (
|
|
"github.com/lightningnetwork/lnd/lnwire"
|
|
"github.com/lightningnetwork/lnd/queue"
|
|
)
|
|
|
|
const (
|
|
// redMinThreshold is the minimum queue length before RED starts dropping
|
|
// messages.
|
|
redMinThreshold = 10
|
|
|
|
// redMaxThreshold is the queue length at or above which RED drops all
|
|
// messages (that are not protected by type).
|
|
redMaxThreshold = 40
|
|
)
|
|
|
|
// isProtectedMsgType checks if a message is of a type that should not be
|
|
// dropped by the predicate.
|
|
func isProtectedMsgType(msg lnwire.Message) bool {
|
|
switch msg.(type) {
|
|
// Never drop any messages that are heading to an active channel.
|
|
case lnwire.LinkUpdater:
|
|
return true
|
|
|
|
// Make sure to never drop an incoming announcement signatures
|
|
// message, as we need this to be able to advertise channels.
|
|
//
|
|
// TODO(roasbeef): don't drop any gossip if doing IGD?
|
|
case *lnwire.AnnounceSignatures1:
|
|
return true
|
|
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// getMsgStreamDropPredicate returns the drop predicate for the msgStream's
|
|
// BackpressureQueue. For non-integration builds, this combines a type-based
|
|
// check for critical messages with Random Early Detection (RED).
|
|
func getMsgStreamDropPredicate() queue.DropPredicate[lnwire.Message] {
|
|
redPred := queue.RandomEarlyDrop[lnwire.Message](
|
|
redMinThreshold, redMaxThreshold,
|
|
)
|
|
|
|
// We'll never dropped protected messages, for the rest we'll use the
|
|
// RED predicate.
|
|
return func(queueLen int, item lnwire.Message) bool {
|
|
if isProtectedMsgType(item) {
|
|
return false
|
|
}
|
|
|
|
return redPred(queueLen, item)
|
|
}
|
|
}
|