highperfocused/multica
1
0
Fork 0
mirror of https://github.com/multica-ai/multica.git synced 2026-07-23 18:17:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat(daemon): discover Codex model and reasoning catalog dynamically (#5198)

Browse Source 
Discover the Codex model list and per-model reasoning efforts from the installed CLI (codex debug models --bundled), with a verified static fallback for old/offline installs. Server gates token syntax; the daemon validates the exact (model, effort) pair.

Closes #5197
MUL-4354
This commit is contained in:
Wood
2026-07-10 14:32:05 +08:00
committed by GitHub
parent bf161f2f9c
commit f7ca045fb1
9 changed files with 410 additions and 289 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
server/internal/handler/agent.go
View File

@@ -895,10 +895,10 @@ func (h *Handler) CreateAgent(w http.ResponseWriter, r *http.Request) {
return
}
// thinking_level validation: provider-level enum only. Per-model gaps
// are enforced by the daemon at execution time (MUL-2339, Trump's
// review note — keep API behaviour consistent: literal-invalid →
// always 400; combination-invalid → daemon-side task error).
// thinking_level validation: fixed-enum providers reject unknown literals;
// dynamic-catalog providers (Codex/OpenCode) reject malformed tokens here.
// Per-model gaps are enforced by the daemon at execution time (MUL-2339):
// combination-invalid values are logged and omitted from the invocation.
if !agent.IsKnownThinkingValue(runtime.Provider, req.ThinkingLevel) {
writeError(w, http.StatusBadRequest, fmt.Sprintf("thinking_level %q is not a recognised value for runtime %q", req.ThinkingLevel, runtime.Provider))
return
@@ -1441,15 +1441,12 @@ func (h *Handler) UpdateAgent(w http.ResponseWriter, r *http.Request) {
// thinking_level handling (MUL-2339). Tri-state semantics:
// - field omitted → leave column alone (COALESCE narg), but if a
// runtime change in this same request would make the *existing*
// value literal-invalid for the new provider, reject 400. This
// closes the gap Elon's review flagged: previously, switching a
// Claude agent storing `max` to a Codex runtime would silently
// keep `max` and forward it to the daemon.
// value invalid for the new provider's fixed enum or token syntax,
// reject 400. Exact dynamic-catalog compatibility is daemon-owned.
// - field set to "" → explicit clear (run ClearAgentThinkingLevel post-update)
// - field set to value → validate against the target runtime's provider
// enum; reject literal-invalid with 400. Per-model combination checks
// run in the daemon at execution time, not here — see Trump's review
// constraint that API behaviour stays consistent across change paths.
// - field set to value → validate against the target runtime's fixed enum
// or dynamic-token syntax; reject literal-invalid with 400. Per-model
// combination checks run in the daemon at execution time, not here.
shouldClearThinkingLevel := false
if req.ThinkingLevel != nil {
value := *req.ThinkingLevel