2 Commits

Author	SHA1	Message	Date
Jiayuan Zhang	35fc318d68	feat(runtimes): weekly usage dimension + tz-aware aggregation (MUL-2382) (#2822) ... * feat(runtimes): weekly usage dimension + tz-aware aggregation (MUL-2382) Adds a Weekly view to the runtime Usage chart alongside Daily and Hourly, backed by `aggregateByWeek` on the existing 180-day daily cache (no new endpoint). Weeks are ISO 8601 Mon–Sun; the in-progress week is rendered at half opacity and tooltip-labelled "partial · N / 7 days". Side effects called out in the RFC: - `sliceWindow` now reads "today" in the runtime's IANA timezone, fixing a one-day drift at the window edge when the browser and runtime sit in different time zones. - ActivityHeatmap rows are reordered Mon → Sun to match the rest of the Weekly aggregation; "today" is computed in runtime tz so the grid's trailing column lines up with the daily rows the backend buckets. Dimension / period coupling: switching dimension resets the period to that dimension's default when the active value isn't in its allowed set (Hourly 7/30, Daily 7/30/90, Weekly 30/90/180). Unit tests cover weekStart / addDays / tz-aware today, the sliceWindow boundary, and aggregateByWeek's partial-week math. Co-authored-by: multica-agent <github@multica.ai> * fix(runtimes): weekly chart shows trailing calendar weeks (MUL-2382) aggregateByWeek built one bucket per week-with-data, and the caller took the last N buckets. With sparse data — old populated weeks plus empty stretches near today — the slice surfaced the old weeks instead of the trailing in-window calendar weeks the user selected. Now aggregateByWeek takes weekCount and emits exactly that many trailing calendar weeks anchored at today's week in the runtime tz. Buckets are pre-zeroed so empty in-range weeks render as empty bars; rows outside the window are dropped. Co-authored-by: multica-agent <github@multica.ai> * feat(usage): drop Hourly dim + add Daily/Weekly to workspace dashboard (MUL-2382) - Remove Hourly from the runtime usage WHEN-chart: segmented control is now Daily / Weekly. Drop the HourlyActivityChart component, aggregateCostByHour helper, byHour query subscription, and the when_tab_hourly i18n key. - Add the same Daily / Weekly dimension toggle to the workspace-level Usage page (dashboard-page.tsx). Time-range linkage matches the runtime page: Daily allows 7/30/90 (default 30), Weekly allows 30/90/180 (default 90); switching dimensions resets `days` when the current value isn't in the new dimension's set. - Reuse `aggregateByWeek` from runtimes/utils for cost / tokens (signature relaxed to accept the wider DashboardUsageDaily shape). Add `aggregateWeeklyTime` / `aggregateWeeklyTasks` in dashboard/utils with identical pre-zeroed trailing-week semantics. Workspace dashboard uses the user-chosen timezone (existing TimezoneSelect) as the week-boundary tz; runtime page continues to use the runtime's IANA tz. - New `WeeklyTimeChart` / `WeeklyTasksChart` mirror their daily counterparts plus partial-week half-opacity bars and rangeLabel tooltips, matching the existing Weekly cost / tokens charts. - Tests: drop hourly-related setup; add weekly run-time / tasks coverage asserting pre-zeroed trailing buckets and the same MUL-2382 sparse window-scoping regression we caught on the runtime side. Co-authored-by: multica-agent <github@multica.ai> * fix(usage): correct workspace Weekly window + lock tz to UTC (MUL-2382) Two blocking correctness bugs from Emacs's PR #2822 review: 1. The Weekly chart paints `ceil(days/7)` trailing calendar weeks but the API was still asked for exactly `days`. Worst case (today = Sunday on a 30D request) the leftmost Monday sits 34 days back, so the first week's bucket was silently truncated. Over-fetch the per-date queries to `weekCount * 7` days when Weekly is active; per-agent rollups stay at `days` so the KPI / leaderboard labels keep their advertised window. Daily-aggregation surfaces (cost/tokens/time/tasks KPIs and the Daily chart) re-scope the over-fetched rows back to `days` so the labels stay consistent. 2. The backend dashboard rollup buckets data by UTC `bucket_date` (and the raw fallback queries by `DATE(tu.created_at)`, also UTC), but the frontend was driving Weekly boundaries from the user-chosen `TimezoneSelect`. Near midnight UTC that put cross-boundary rows into the wrong calendar week. Lock workspace Weekly to UTC and remove the timezone picker from this page; the runtime detail page keeps its own `runtime.timezone`-anchored aggregation, which is consistent because its rollup is materialized in that runtime's tz. Verification: pnpm --filter @multica/views test (636 passed), typecheck clean, lint 0 errors / 13 pre-existing warnings. Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: multica-agent <github@multica.ai>	2026-05-19 04:24:46 +02:00
Bohan Jiang	96695a79c5	feat(dashboard): workspace/project token + run-time dashboard MUL-1882 (#2462) ... * feat(dashboard): workspace/project token + run-time dashboard Add a `/{slug}/dashboard` page showing per-agent token spend and execution time across the whole workspace, with an optional project filter. Backend: - Three new sqlc queries against task_usage + agent_task_queue: daily usage, per-agent usage, per-agent total run-time. All optionally scoped to a project via sqlc.narg('project_id'), reaching project through the issue join. - Handlers under /api/dashboard return the same wire shape the runtime page already consumes (model preserved for client-side cost math). Frontend: - Shared DashboardPage in packages/views/dashboard reusing KpiCard, DailyCostChart, ActorAvatar, and estimateCost from the runtime page so the visual style and pricing math stay in lock-step. - Period selector (7/30/90d), project dropdown, four KPI tiles (cost, tokens, run time, tasks), daily cost chart, and a combined "cost + run time by agent" list. - Routed in both web (app/[slug]/(dashboard)/dashboard) and desktop (memory router); sidebar nav entry added under Workspace group. Co-authored-by: multica-agent <github@multica.ai> * fix(dashboard): drop stale project filter and stop double-counting tasks Two issues caught in PR #2462 review: 1. Project filter held the previous selection's UUID across workspace switches and project deletions: the dropdown gracefully showed "All projects" (because the title lookup missed) while the three dashboard queries kept forwarding the dead UUID, leaving the UI looking like a full-workspace view but populated with empty project-scoped data. Validate the picked UUID against the current projects list before passing it to the queries. 2. The "by agent" table read its task count from the token rollup, which is grouped per (agent, model). A single task that spans two models lands twice and the agent's row reads e.g. "2 tasks" when the real count is 1. Prefer `ListDashboardAgentRunTime`'s per-agent distinct count when available; fall back to the token aggregate only for agents with no terminal run yet (in-flight tasks). Extract the merge into `mergeAgentDashboardRows` so the precedence rules are unit-tested directly. Co-authored-by: multica-agent <github@multica.ai> * test(dashboard): allocate per-workspace issue.number explicitly TestDashboardEndpoints creates two issues in the shared fixture workspace. issue.number defaults to 0 (migration 020), and the table carries UNIQUE (workspace_id, number), so the second insert raced the first on the same default and failed in CI. Allocate MAX(number) + 1 per insert so each row gets a fresh number without stepping on rows other tests left behind in the same workspace. Co-authored-by: multica-agent <github@multica.ai> * feat(dashboard): rollup table + cron-driven aggregation for dashboard Mirror the per-runtime rollup in `task_usage_daily` (migrations 073/077/082) to remove the per-request raw aggregation the dashboard was doing. Migration 084 adds: - `task_usage_dashboard_daily` keyed on (bucket_date, workspace_id, agent_id, project_id, model) — the dimensions the dashboard actually queries, with project_id nullable via UNIQUE NULLS NOT DISTINCT (PG15+) so "no-project" buckets upsert cleanly. - `task_usage_dashboard_rollup_state` watermark table. - `task_usage_dashboard_dirty` invalidation queue. - Triggers on agent_task_queue DELETE, task_usage DELETE, and issue.project_id UPDATE — the cases the updated_at watermark can't see. The project_id trigger re-attributes existing rollup rows when a user moves an issue across projects. - `rollup_task_usage_dashboard_daily_window(from, to)` — idempotent recompute primitive (same shape as 077). - `rollup_task_usage_dashboard_daily()` cron entry — own advisory lock (4244) so it serialises independently of the runtime rollup. - `task_usage_dashboard_rollup_lag_seconds()` health helper. Sqlc queries `ListDashboardUsageDailyRollup` / `ListDashboardUsageByAgentRollup` read from the new table; the handler dispatches between rollup and raw on a separate `UseDailyRollupForDashboard` config flag (`USAGE_DASHBOARD_ROLLUP_ENABLED` env). Same fail-safe default (false → raw) so operators can roll out independently of the per-runtime flag. Bucket date is UTC (the dashboard aggregates across runtimes that may sit in different tzs; there's no single correct local boundary). Adds `cmd/backfill_task_usage_dashboard_daily` mirroring the existing per-runtime backfill — operator runs it once before flipping the flag. Tests: - TestDashboardEndpoints now also exercises the rollup read path (raw vs. rollup, same project-scoped totals). - TestDashboardRollupReattributesOnProjectChange verifies the issue.project_id trigger enqueues both old + new buckets and the next rollup tick zeroes the old project + populates the new one. Co-authored-by: multica-agent <github@multica.ai> * fix(dashboard-rollup): close two invalidation gaps Two leak paths missed by migration 084 review: 1. Issue cascade DELETE — the atq BEFORE DELETE trigger runs AFTER the issue row is gone, so `LEFT JOIN issue` returns NULL project_id and the original-project bucket never gets cleared (issue 077 calls this out for the runtime rollup but didn't need to act on it). Adds an `issue BEFORE DELETE` trigger that enqueues using OLD.project_id while the issue row is still readable. 2. `LinkTaskToIssue` (quick-create task attaching to a real issue post- completion) UPDATEs `agent_task_queue.issue_id` from NULL to a real id. Migration 084 only watched DELETE on atq, so usage already rolled up under the no-project bucket stayed attributed to NULL forever. Extends the atq trigger to fire on UPDATE OF issue_id too, enqueueing both OLD (NULL project) and NEW (linked issue's project). Tests: - TestDashboardRollupClearsOnIssueDelete asserts rollup row drops to zero after issue delete + rollup tick. - TestDashboardRollupReattributesOnLinkTaskToIssue verifies tokens move from the NULL bucket to the project bucket after the UPDATE. Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: multica-agent <github@multica.ai>	2026-05-13 12:51:16 +08:00