2 Commits

Author	SHA1	Message	Date
YYClaw	614dfae884	MUL-2488 feat(timezone): Scheduling / Viewing two-layer timezone architecture (#2968) ... * docs(timezone): add scheduling/viewing timezone architecture RFC * feat(db): replace daily rollups with task_usage_hourly, add user.timezone Migrations 100-104: add "user".timezone (Viewing tz), build the UTC hourly task_usage_hourly rollup with its pipeline, drop the legacy task_usage_daily / task_usage_dashboard_daily pipelines, and drop the agent_runtime.timezone column. Report queries now slice day boundaries at read time by the caller-supplied @tz instead of materialising in a fixed tz. Regenerate sqlc. * feat(server): add task_usage_hourly backfill command Replace the two legacy backfill commands (daily / dashboard_daily) with a single backfill_task_usage_hourly that loads historical task_usage into the new UTC hourly rollup, sliced per workspace. * refactor(server): resolve viewing timezone in report handlers Report handlers resolve the Viewing tz per request (?tz query param, then user.timezone, then UTC) and pass it to the hourly-rollup queries. Drop the UseDailyRollup feature flags and the old raw-scan/daily-rollup dual paths, remove the /api/usage endpoints, and stop the daemon from reporting and the runtime handler from accepting host timezone. * refactor(core): switch report queries to viewing timezone API client and dashboard/runtime queries send ?tz with each report request, the user schema/types carry the new timezone field, and the runtime timezone field/mutation is removed. * feat(views): add viewing timezone preference and UI Add the useViewingTimezone hook and a Timezone setting in Preferences; report charts and the dashboard week boundary follow the viewer tz. Remove the runtime detail timezone editor and its locale strings. * fix(test): update fixtures and stabilize tests for timezone refactor The timezone architecture refactor changed several types without updating dependent test code: - RuntimeDevice no longer has a timezone field — drop it from the create-agent-dialog runtime fixture. - User now requires a timezone field — add it to the apps/web mockUser fixture. - The PreferencesTab timezone tests asserted on the async save handler (PATCH then store update) with a bare expect, racing the mutation's settle callback, and timed out querying the Select's ~600-option IANA list on a loaded CI runner. Wrap the assertions in waitFor and extend the timeout for those three tests. * docs(timezone): document self-host migration order and trigger invariant Add a SELF-HOST UPGRADE ORDER runbook to the backfill command's package comment: applying migrations 100-104 in a single migrate-up drops the legacy daily rollups before the hourly backfill runs, leaving dashboards empty until cron catches up. Add an INVARIANT comment on trg_atq_dirty_hourly noting that agent_id must be added to the trigger's OF list if it ever becomes mutable, otherwise dirty buckets for the old agent_id are silently missed. * style(runtimes): drop trailing blank line in runtime-detail	2026-05-21 15:33:47 +08:00
Naiyuan Qing	20c2f45b4a	fix(views): surface backend error messages on mutation failures (MUL-2317) (#2772) ... * fix(views): surface backend error messages on mutation failures (MUL-2317) Mutation toasts across the views package were swallowing the backend `error` string and showing only a generic i18n fallback. This made it impossible for users to see why an operation failed (most visibly: creating an issue with a duplicate title produced a vague "Failed to create issue" toast). The fix has three pieces: 1. Create-issue duplicate branch (A段) - New schema `DuplicateIssueErrorBodySchema` in core/api/schemas.ts. - `create-issue.tsx` parses `ApiError.body` via `parseWithFallback` and renders a dedicated amber-toned toast with a "view existing" link when the server returns `{ code: "active_duplicate_issue", issue: {...} }`. Schema drift downgrades to the normal error toast. - Schema intentionally omits `issue.status` so the toast does not depend on `StatusIcon`, which has no fallback for unknown enums. 2. User-facing mutation failure toasts (B段) - 47 sites converted to `err instanceof Error && err.message ? err.message : <existing fallback>` — preserves all existing code-specific branches (slug conflict, agent_unavailable, daemon_version_unsupported) and i18n keys. - Covers Type 1 (onError) and Type 2 (catch block) patterns across issues, projects, autopilots, inbox, runtimes, squads, comments, batch actions, workspace create, and agent config tabs. 3. Autopilot partial-success (Type 3) - New i18n keys `toast_create_partial_with_reason` / `toast_update_partial_with_reason` (double-brace `{{reason}}`). - `autopilot-dialog.tsx` captures `err.message` in the schedule `catch` and routes to the `_with_reason` variant when present, preserving the partial-success semantic (autopilot saved, schedule failed) while exposing the actual reason. Explicitly out of scope: - `packages/core/` mutation hooks (no global onError, no UI dependency) - No `toastApiError` helper (matches existing 14+ correct sites) - Sub-issue link aggregate `Promise.allSettled` keeps count-based toast (N independent requests cannot collapse to one err.message); only added a dev-side `console.error` per rejection. - Clipboard catches and `useUpdateChatSession` (not API mutation toasts) Tests: - `packages/core/api/schemas.test.ts` — schema contract (valid body, forward-compat fields, rename rejection, missing issue, wrong types). - `packages/views/modals/create-issue.test.tsx` — duplicate toast + view link, schema-drift fallback, err.message surfacing, non-Error fallback (4 new cases). - `packages/views/autopilots/components/autopilot-dialog-i18n.test.ts` — real i18next, asserts rendered text contains the reason verbatim (guards against `{reason}` vs `{{reason}}` regression). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * fix(autopilots): unify rotate-token catch + cover dialog partial-success render Address reviewer feedback on PR #2772: 1. webhook-token rotate (`autopilot-detail-page.tsx`) now follows the `err.message ?? fallback` ternary used by the sibling trigger delete/add paths, instead of swallowing the error. 2. Extract `formatSchedulePartialFailureToast` so the dialog's partial-success branches and the i18n test exercise the same helper. The test now drives the actual format function, so a variable-name typo at the call site (e.g. `{ msg }` instead of `{ reason }`) fails the substring assertion. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai> * test(modals): drop user.type for title in success path to dodge CI 5s timeout The success-path test typed the 42-character title via userEvent which triggers a controlled re-render per keystroke. On the slower CI runner the whole test crept up to ~5s and intermittently tripped the default vitest timeout. Setting the value in one shot via fireEvent.change cuts the cost while leaving the submit + toast interactions on userEvent. Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>	2026-05-18 13:44:10 +08:00