28 Commits

Author	SHA1	Message	Date
Jiayuan Zhang	7803a5b9ea	feat(ui): establish a role-named type scale and migrate ad-hoc font sizes (MUL-5451) (#6136) ... tokens.css defined colours, radii and font families but not a single --text-* step, so font sizes had no baseline to align to and grew wherever they were needed: 51 distinct sizes across web + desktop, 370 written as arbitrary values, six at half a pixel (10.5 / 11.5 / 12.5 / 13.5 / 14.5 / 15.5px). text-xs and text-sm carried nearly all UI text while the range between them — 11, 13, 15px — could only be reached with arbitrary values. Hierarchy does not come from having more sizes; past a handful, each extra size makes the hierarchy blurrier. Add ten role-named steps, each with its own line-height so leading cannot fragment the way size did, and move every product-UI call site onto them. Steps are named for what the text is for, not for a t-shirt size, because that is what keeps the scale from drifting again. Six steps deliberately keep the exact size/line-height pairs of the Tailwind defaults they replace, so the ~1,900-call-site rename moves nothing on screen. The visible changes are confined to former arbitrary values snapping to a step: 8/9/10px -> micro (11px) on badges and overlines; 17 -> 18; 22 -> 24; 30 (text-3xl) -> 36 on headings and stat numbers; 12.8px -> label (13px) on small buttons and toggles. Half-pixel sizes are gone. This supersedes #6108, which was reverted by #6116 because the sidebar group labels rendered at the inherited 16px. The cause was not the scale but cn(): `text-<x>` is ambiguous in Tailwind, and tailwind-merge resolves it against a table listing only the default sizes, so it filed every role step under text-colour and dropped whichever of `text-caption` / `text-sidebar-foreground/70` came first. Registering the steps as a font-size class group restores the real conflict groups — size beats size, colour beats colour, the two coexist — and a test pins the list against the scale, since the failure is silent in source. Hand-written CSS is covered too. The transcript kept a 12.5px body long after every Tailwind call site was on the scale, so the "no half-pixel sizes" claim was true of the classes and false of the product; the editor's prose, code and mermaid ramps had the same blind spot, and seven of their eight values already equalled a step exactly. All now reference var(--text-*). The guard test reads raw `font-size:` declarations as well as class names, exempting only the 16px iOS input-zoom workaround in base.css and the landing pages' marketing ramp. apps/mobile (own NativeWind config) and apps/docs (fumadocs' own type system) keep Tailwind's default scale and are untouched. Landing display type (rem/clamp, 2.2-6.4rem) stays on its separate ramp, as do four decorative emoji / serif-hero sizes. Verified on a running local stack: pinned sidebar rows and group labels measure 12px/16px, nav items 14px/20px — identical to pre-migration. An audit of every rendered font size across the product surfaces finds nothing off the scale; the only exceptions are avatar initials and emoji, which actor-avatar.tsx sizes proportionally to the avatar diameter by design. Co-authored-by: Lambda <lambda@multica.ai> Co-authored-by: multica-agent <github@multica.ai>	2026-07-30 13:42:33 +08:00
Jiayuan Zhang	545afea827	Revert "feat(ui): establish a role-named type scale and migrate ad-hoc font s…" (#6116) ... This reverts commit d68d636c91.	2026-07-29 17:10:33 +08:00
Jiayuan Zhang	d68d636c91	feat(ui): establish a role-named type scale and migrate ad-hoc font sizes (MUL-5451) (#6108) ... tokens.css defined colours, radii and font families but not a single --text-* step, so font sizes had no baseline to align to and grew wherever they were needed: 51 distinct sizes across web + desktop, 370 of them written as arbitrary text-[Npx] values, six at half a pixel (10.5 / 11.5 / 12.5 / 13.5 / 14.5 / 15.5px). text-xs and text-sm carried nearly all UI text while the range between them — 11, 13, 15px — could only be reached with arbitrary values. Hierarchy does not come from having more sizes; past a handful, each extra size makes the hierarchy blurrier. Add ten role-named steps, each with its own line-height so leading cannot fragment the way size did, and move every product-UI call site onto them. Steps are named for what the text is for, not for a t-shirt size, because that is what keeps the scale from drifting again. Six steps deliberately keep the exact size/line-height pairs of the Tailwind defaults they replace, so the 1,900-call-site rename (text-sm -> text-body and friends) moves nothing on screen. The visible changes are confined to former arbitrary values snapping to a step: - 8 / 9 / 10px -> micro (11px): 102 sites, mostly badges and overline labels. Deliberate — under 12px is a counter role, not a text role. - 17px -> title (18px), 22px -> display-sm (24px), 30px (text-3xl) -> display (36px): 21 sites, all headings or stat numbers in flexible containers. - Half-pixel steps are gone entirely. Arbitrary sizes also inherited whatever line-height was above them; the tokens now pin one, which removes latent overflow risk in the fixed-height h-4/h-5 badges those sizes were used in. apps/mobile (own NativeWind config) and apps/docs (fumadocs' own type system) keep Tailwind's default scale and are untouched. Landing-page display type (rem/clamp, 2.2-6.4rem) is marketing typography on a separate ramp and stays out of the scale, as do four decorative emoji / serif-hero sizes. A guard test fails the build on any font size written outside the scale, reporting file:line — without it nothing in a Tailwind build makes an off-scale value look wrong, which is how the drift happened. Verified against a local stack: typecheck, lint and the full TS suite show no new failures, and before/after screenshots of issues, issue detail, runtimes (populated), usage, agents, inbox, my-issues and settings differ only in the intended 10px -> 11px labels, with no row-height, truncation or layout shift. Co-authored-by: Lambda <lambda@multica.ai> Co-authored-by: multica-agent <github@multica.ai>	2026-07-29 16:30:13 +08:00
Naiyuan Qing	77b309a5ac	feat(drafts): unified draft lifecycle + upload ownership inversion (MUL-5181) (#5900) ... * feat(drafts): unified draft lifecycle + upload ownership inversion (MUL-5181) Unify how every composer preserves unsent work, sends, and handles uploads. L1 foundation (packages/core/drafts): - createDraftStore factory + self-registering cleanup-registry replacing the hand-maintained WORKSPACE_SCOPED_KEYS list; register-all-drafts guarantees registration completeness. Fixes the confirmed cross-user draft leak (persistence + in-memory) on logout / workspace delete. L3 send paradigm: - useComposerSubmit: one await-then-render contract (lock/spin, keep-on-fail, clear-on-success, single-flight, submit-time upload-gate), adopted by comment/reply/edit, create-issue, quick-create, and chat. Per-surface: - Comment/Reply/Edit: attachments moved into the persisted draft. - Create Issue: draft split into shared/manual/agent/activeMode with non-destructive mode switching + migration for old flat drafts. - Chat: optimistic send converted to await-then-render (kept server-driven cancel restore_to_input); chat draft keys registered for cleanup. L2 upload coordinator (ownership inversion, Linear-validated shape): - upload-coordinator + DraftUpload placeholder: uploads owned by a module coordinator that outlives the component, state persisted in the draft; AbortController + abort-on-logout; interrupted-on-reload. Comment surface fully wired. Create-issue/chat upload wiring is a documented residual. Verified: core + views typecheck clean; core 1064 + views 2928 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(drafts): close three review gaps in the unified draft lifecycle (MUL-5181) 1. Logout resurrection: reset in-memory draft stores BEFORE removing their persisted keys — each reset is a setState and persist writes it straight back under the still-active slug, so the old order re-created the deleted keys. The issue draft store's reset is now a full reset including lastAssignee, which clearDraft deliberately re-seeds and would otherwise hand the previous user's last-picked assignee to the next login. 2. Submit gate blind spot: the composer gate now also reads the draft's coordinator-owned upload placeholders (hasUploadingDraft). A composer reopened over a still-in-flight upload could previously send past the editor-only gate, clearing the draft out from under the settling upload. 3. Attachment binding returns to reference-filtering: a submit binds only uploads the body references, so deleting an inline image really unbinds it. An upload that settles after its mount died gets its markdown link written back into the body instead — via the reopened composer's live editor (new ContentEditorRef.insertMarkdownAtEnd) or appended to the persisted draft (new appendToDraftContent) — so close-surviving files stay visible, deletable, and honestly bound. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(drafts): harden upload write-back delivery after independent review Review of the previous commit (fresh-context reviewer + probe against real @tiptap/react) found the write-back could still lose a file: - insertMarkdownAtEnd now returns a boolean: the imperative handle exists from first commit but the Tiptap instance arrives in a passive effect, so an insert in that window (or after destroy) no-ops. Callers previously assumed it landed. - Write-back is now confirmed delivery (deliverFinishedUpload): insert into the live editor and, on success, persist the same body as insurance against the debounced emit being dropped by a quick unmount; append to the store only when NO composer is mounted (a mounted editor's first emit would erase a store-only append); retry while a mounted composer's instance is still warming up. Every attempt re-checks the generation guard and the body reference. - mountedRef flips in a layout effect: React nulls the child editor ref in the unmount commit, and a settle in the gap before passive cleanup saw "mounted" with no editor left to swap. - uploadAndInsertFile guards editor.isDestroyed after the await: now that uploads outlive mounts, the swap/remove paths could dispatch against a destroyed EditorView and escape as an unhandled rejection. - Tests: the reopened-composer test now asserts the editor actually received the insert (it previously passed with liveEditors disabled), plus a warming-up retry case; the mock editor mirrors isDestroyed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(drafts): roll coordinated uploads out to issue-create and chat (MUL-5181 L2) Completes the upload-ownership layer for every composer surface. The generic engine is extracted from the comment implementation into editor/use-coordinated-uploads (UploadDraftBinding adapter: store-backed accessors + registry key + body append), and use-comment-uploads becomes a thin binding over it — behavior unchanged, all comment tests green. Issue-create (manual + agent panels): - shared.attachments migrates Attachment[] -> DraftUpload[]; load normalizes legacy bare rows to `uploaded` and coerces stale `uploading` to `interrupted`. - Uploads are coordinator-owned: placeholder at pick time, survives dialog close, aborts on logout, chips for uploading/failed/interrupted, combined gate on Create and both mode-switch actions. - Write-back targets the body of the MODE that started the upload (manual description vs agent prompt); mount-time prune keeps placeholders and drops only unreferenced `uploaded` entries. Chat (tab + floating window): - inputDraftAttachments migrates to DraftUpload[] with load-time normalization; new store ops (add/settle/fail/remove upload, append-to- draft) mirror the comment store. - ChatInput adopts the engine; the upload target is snapshotted at pick time via resolveUploadTarget so a file dropped while the editor is pinned to a previous session's document files under THAT draft. - uploadMapRef is gone — the draft's uploads are the single binding source, reference-filtered at send. Hosts no longer own transport: onUploadFile prop becomes uploadEnabled, and the controller/window drop uploadWithToast. - commitDraft prunes only `uploaded` entries the body no longer references; placeholders survive keystrokes (chips are their only UI). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(drafts): harden L2 rollout after independent review - attachmentToDraftUpload now strips the response-scoped signed download_url before the row is persisted (draft uploads survive restarts; a stale signature 403s the preview on reopen). Covers comments, issue-create, and chat in one place; issue-create's settle reuses the helper, and the Signature assertion the rollout had dropped is restored. - chat's live-editor registry follows the LOADED draft key (reactive mirror of editorDraftKeyRef): a settle for draft B must not insert into an editor still pinned to draft A's document. - removeUpload aborts an in-flight request before dropping its placeholder. - issue-create hasDraft counts only uploaded/uploading entries so a failed remnant can't pin the sidebar draft dot forever. - Tests: mutation-proof coverage for the two placeholder-preservation rules (create-issue mount prune, chat commitDraft prune) — both previously survived rule inversion; direct core tests for the five new chat store upload ops incl. persistence and signed-URL stripping; quick-create test gets the editor i18n namespace; dead uploadWithToast scaffolding removed from both modal tests; chat-input mock aligned with the real append semantics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(drafts): close third-round review gaps in the upload engine - The live-editor registry registers in a layout effect: chat's adopt swaps the editor's document and loaded key synchronously during commit, and a passive re-registration one task later left a settle window where the old key mapped to an editor already holding another draft's document. The registry key is also built only when a binding exists. - removeUpload aborts only a request THIS surface tracks as `uploading` (guarded before the abort), with the comment now honest about the path being defensive — no current chip exposes ✕ mid-upload. - Mutation-proof test for the loaded-key registry rule: a dead mount's settle for a pinned draft must insert into the editor HOLDING it, not the selected one (verified to fail with the registry keyed by selection). - hasDraft upload semantics pinned by tests (uploaded/uploading count; failed/interrupted remnants don't pin the sidebar dot). - Dead scaffolding dropped: identity use-file-upload mocks and a redundant assertion in the modal tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(drafts): stale-submit draft guard + registry layout timing (review BLOCKED items) Blocker 1 — a submit that outlives its composer may only consume the draft it submitted (MUL-5181 P0). Every accepted-submit clear is now guarded: - create-issue / quick-create snapshot the singleton draft's object identity at submit; a dead panel clears (and records last-assignee/mode) only if the draft is untouched, and never runs close/reset effects. A replaced draft B typed after close survives a late success of draft A. - comment / reply / edit snapshot the per-key draft entry; a dead composer clears only the exact entry it submitted. - chat snapshots the sent slot's value; a dead mount's commitInput clears only an unreplaced draft. Mutation-verified tests for the create panels and comments (guard inverted => tests fail), plus untouched-draft control cases. Blocker 2 — the live-editor registry is now genuinely registered in a layout effect. The prior commit claimed this fix but a test-time `git checkout --` discarded the unstaged engine edits before committing; re-applied: layout registration, binding-gated registry key, and the tracked-only abort in removeUpload. New registry timing test captures the registry from a parent layout effect across a key switch — verified to fail with passive registration. Also: `multica:chat:selectedProjectId` joins the workspace-scoped cleanup list (was leaking across logout; flagged as a pre-existing risk). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(drafts): mounted submits also clear only the draft they submitted The stale-submit snapshot guard previously protected only dead composers; a mounted one cleared unconditionally on success. But the editor stays interactive during a request (Tiptap cannot toggle editable post-mount), so text typed while draft A was in flight was wiped by A's success. The guard is now unconditional across every surface: success consumes exactly the submitted snapshot, and any later edit survives. - create-issue / quick-create: the editor's pending debounce is flushed into the store BEFORE snapshotting (a late flush of pre-submit typing must not read as a mid-flight edit); a touched draft skips clear AND close/reset — the dialog stays open on the newer work. Untouched behavior unchanged. - comment / reply / edit: same flush + snapshot; a touched entry keeps both the store draft and the editor content (edit mode stays open on it). - chat: commitInput's value compare now applies while mounted too, and the editor is scrubbed only for an untouched draft. - use-composer-submit docs no longer claim "editor locked": they state the real contract — send affordance locks, edits after submit survive. Regression tests: mounted mid-flight-edit cases for manual create (incl. "dialog must not close over draft B"), quick create, comment, and chat, plus mounted-untouched controls. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(drafts): idempotent draft writes so a tab switch cannot resurrect a posted comment Final-review blocker: the comment/reply visibilitychange/pagehide flush re-writes IDENTICAL content on every tab switch, and writeDraft minted a new entry object each call — the stale-submit guard's identity compare then read a mid-flight tab switch as "edited during the request", kept the posted comment's draft alive, and left Send enabled for a duplicate. - writeDraft is now a no-op when content and uploads are unchanged (also kills a spurious persist write per tab switch). Regression tests: entry identity preserved on identical setDraft (core), and the reproduced tab-switch-mid-send scenario clears the posted draft (views) — verified to fail with the idempotence removed. - onAccepted now flushes the editor's pending debounce before judging `untouched` on every surface, so typing still inside the debounce window counts as a mid-flight edit instead of being scrubbed. - create-issue records last-assignee/mode from the SUBMITTED values, outside the untouched gate — a created issue updates the preference even when the dialog stays open on newer edits. - Stale guard comments corrected in both create panels; the use-composer-submit docstring no longer claims project/feedback were migrated (they still hand-roll await-then-clear; registered debt). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-28 10:10:00 +08:00
Jiayuan Zhang	b1d5fa4ff7	fix(auth): remove OR divider from the sign-in card (MUL-5105) (#5722) ... Co-authored-by: Lambda <lambda@multica.ai> Co-authored-by: multica-agent <github@multica.ai>	2026-07-21 17:40:29 +08:00
Stiliyan Monev	9d7060caf1	fix(auth): autofocus OTP input on verification step (#4344) ... * fix(auth): autofocus OTP input on verification step The email-verification step renders the OTP input without focus, so users must click the field before typing the code. This is friction on every login, especially when switching accounts. Add `autoFocus` to the InputOTP so the cursor lands in the field as soon as the step mounts. Mirrors the existing email-step input and the mobile OTP component, both of which already autofocus. * test(web): polyfill document.elementFromPoint for input-otp in jsdom Autofocusing the OTP input makes input-otp run its focus-time DOM measurement, which calls document.elementFromPoint. jsdom doesn't implement it, so the web login test threw an unhandled error. packages/views/test/setup.ts already stubs this for the same reason; mirror the stub in the web test setup (which already stubs ResizeObserver for input-otp). * test(auth): assert OTP input autofocuses on verification step Guards the autofocus behavior: the test fails if the autoFocus prop is removed from the verification-step InputOTP. Lives in packages/views since it covers shared component behavior, mocking @multica/core.	2026-06-22 10:00:57 +08:00
Willow Lopez	089832d6ec	fix(web): preserve CLI callback params across Google OAuth redirect (MUL-3313) (#4167) ... * fix(web): preserve CLI callback params across Google OAuth redirect When 'multica login' runs in a headless/WSL2 environment, the CLI generates a login URL with cli_callback and cli_state query parameters. These params were being lost during the Google OAuth redirect because: 1. The login page did not encode cli_callback/cli_state into the Google OAuth state parameter (only platform and nextUrl were included). 2. The callback page had no code path to redirect the JWT back to the CLI's local HTTP listener after Google OAuth completed. Fix: - Login page: encode cli_callback and cli_state into the Google OAuth state parameter alongside existing platform/nextUrl values. - Callback page: parse cli_callback/cli_state from the returned state, validate the callback URL, and redirect the JWT token to the CLI's local HTTP listener after successful Google login. Closes #3049 Co-authored-by: multica-agent <github@multica.ai> * refactor(auth): reuse redirectToCliCallback helper in OAuth callback Export the existing redirectToCliCallback helper from @multica/views/auth and reuse it in the Google OAuth callback page instead of duplicating the token+state redirect string inline, so the CLI callback URL contract lives in one place. Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: multica-agent <github@multica.ai> Co-authored-by: J <j@multica.ai>	2026-06-16 16:38:15 +08:00
Naiyuan Qing	3447764b03	feat(i18n): full rollout — 21 namespaces translated (en + zh-Hans) (#1853) ... * feat(i18n): rollout phase — translate 9 namespaces (WIP) Phase 1 complete (基建 + login + Settings language switcher), phase 2 partial (Wave 4 done, search done). Pending namespaces documented inline; another developer can pick up from here. Infrastructure -------------- - server: add users.language column + extend PATCH /api/me (TestUpdateMeAcceptsLanguage / TestUpdateMePreservesLanguage) - packages/core/i18n: types / pickLocale (intl-localematcher) / browser-cookie-adapter / createI18n (initAsync false + useSuspense false) / I18nProvider / LocaleAdapterProvider - Split server-safe vs React entries: @multica/core/i18n — for proxy/RSC/middleware (no React) @multica/core/i18n/react — for client trees (createContext) (RSC vendored React lacks createContext; mixed import would crash proxy.ts at module load.) - packages/views/i18n: useT hook + selector API augmentation (i18next v26 default; auto-propagates to apps via the side-effect import in use-t.ts). - apps/web: proxy.ts (Next 16 renamed middleware) merges existing legacy/root redirects with x-multica-locale header forwarding; layout.tsx reads locale via headers() and pre-loads RSC resources. - apps/desktop: webPreferences.additionalArguments injects systemLocale (no sendSync — avoids main-thread blocking IPC); renderer adapter reads via process.argv. - ESLint: i18next/no-literal-string at file-scope for translated files via packages/views/eslint.config.mjs TRANSLATED_FILES. - glossary.md (packages/views/locales/) freezes term policy: Issue / Workspace / Agent / Skill / Autopilot / Daemon / Runtime stay English; Inbox / Project / Comment / Member translate. Translated namespaces (9 / 19) ------------------------------ - auth: login page (web wrapper含 desktop-handoff 文案) + Settings Appearance language switcher - editor: 9 .tsx (bubble-menu / link-hover-card / readonly-content / title-editor / extensions: code-block / file-card / image-view / mention-suggestion) + 32 keys - invite: 25 keys - labels / members / my-issues: Wave 4 全部 - search: command palette 35 keys - navigation: no user-facing strings (no-op) Pending (10 / 19) ----------------- issues (46 files / ~210 keys) agents (29 files / ~155 keys; presence.ts + config.ts label maps 允许进 i18n) onboarding (22 files / ~150 keys) settings rest / skills / modals / workspace / chat / inbox / projects / autopilots / layout Workflow for picking up ----------------------- - Glossary: packages/views/locales/glossary.md (mandatory read) - Reference impls: auth/login-page.tsx + editor/* (selector API + i18n-provider test wrapper pattern) - Per namespace: 1. create locales/{en,zh-Hans}/{ns}.json 2. add to packages/views/i18n/resources-types.ts 3. useT('{ns}') + t($ => $.foo) in components 4. add files to TRANSLATED_FILES in eslint.config.mjs 5. typecheck + test + lint must pass - Subagents currently CANNOT write files (sandbox deny). Run as hybrid: subagent researches + outputs full JSON + tsx diff, controller writes. Other ----- - scripts/init-worktree-env.sh: default MULTICA_DEV_VERIFICATION_CODE=888888 in dev for deterministic login (gated by isProductionEnv). Verified: pnpm typecheck (6 pkgs ok), pnpm test (232 pass), make test (Go). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(i18n): rewrite glossary aligned with docs zh voice Switch translation policy to match the canonical CN voice already established in apps/docs/content/docs/*.zh.mdx (20+ files). The new rule splits product nouns into two classes: - Typed entities (issue / project / skill / autopilot / task) — kept as lowercase English in CN text, visually marking them as system types. - Concepts (workspace / agent / daemon / runtime / inbox) — fully translated (工作区 / 智能体 / 守护进程 / 运行时 / 收件箱). Previous glossary kept Workspace / Agent / Daemon / Runtime as English on "工程惯例" grounds, but docs zh and CN AI ecosystem (Coze / 腾讯元器 / 百度) consistently translate these. App UI now matches docs voice so users don't see split personality between the app and its own docs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(i18n): register 6 namespaces and retrofit zh strings to new glossary Two fixes that were blocking the previously-translated namespaces from actually rendering in CN: 1. RESOURCES gap — locales/index.ts only loaded common/auth/settings, but resources-types.ts declared 12 namespaces and 6 of them had real translation content. At runtime i18next would fall back to raw keys for editor / invite / labels / members / my-issues / search. Register all 9 currently-translated namespaces. 2. Retrofit zh strings to the docs-aligned glossary: - "Issue" → "issue" (lowercase entity) - "Workspace" → "工作区" - "Agent" → "智能体" - "Runtime" → "运行时" - "Skill" → "skill" (lowercase) - "项目" → "project" (lowercase) Touched: editor.json (sub_issue + mention.group_issues), invite.json (3 Workspace occurrences), members.json (agents_section / more_agents), my-issues.json (8 retrofits across page/header/errors), search.json (13 retrofits across groups/pages/commands/empty). Verified: pnpm typecheck (6/6) + pnpm test (238/238) all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate inbox namespace First namespace through the sub-agent → main-agent integration pipeline. JSON: en/inbox.json + zh-Hans/inbox.json — 60 keys across page / menu / list / detail / types / labels / errors. Time-formatter labels are kept compact in EN ("5m" / "3h" / "2d") and use full units in zh ("5 分钟" / "5 小时" / "5 天") since raw "5 分" reads as "5 marks/points" in CN. Component changes converted two module-level statics into hooks so the strings can flow through i18next: - inbox-list-item.tsx: `timeAgo` (pure fn) → `useTimeAgo` (hook returning a fn). The local copy is a duplicate of @multica/core/utils `timeAgo` that is only used by inbox-page; other consumers across chat/agents/skills/issues stay on the core util for now and will be translated when their namespaces land. - inbox-detail-label.tsx: `typeLabels` (static const Record) → `useTypeLabels` (hook returning the same Record shape). Call sites keep the existing `typeLabels[type]` access pattern. inbox-page.tsx now uses both hooks and `useT('inbox')` selector calls for all hardcoded strings (~24 sites: header / dropdown menu / list empty state / detail panel / mobile back / quick-create-failed flow / all error toasts). Wired up: resources-types.ts, locales/index.ts RESOURCES, ESLint TRANSLATED_FILES (3 inbox tsx files now lint-protected). Verified: pnpm typecheck (6/6) + pnpm --filter @multica/views test (238/238) + ESLint clean on inbox/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate workspace namespace Translates the three workspace shell views: create-workspace-form, new-workspace-page, no-access-page. Also fixes the prior-art no-unescaped-entities lint errors in no-access-page.tsx — the apostrophes in "doesn't" / "don't" were JSX text literals that move into JSON values after translation, so the lint rule no longer fires. Tests wrapped: workspace/create-workspace-form.test.tsx, workspace/no-access-page.test.tsx, modals/create-workspace.test.tsx all now wrap render() with <I18nProvider locale="en"> so the en values in workspace.json drive the rendered text and the existing assertions continue to match. Slug constants kept: WORKSPACE_SLUG_FORMAT_ERROR / WORKSPACE_SLUG_CONFLICT_ERROR exports in workspace/slug.ts are still imported by onboarding/steps/step-workspace.tsx (out of scope here). The workspace shell now reads its strings from workspace.json directly. Multica.ai brand prefix in the slug input affordance is wrapped with an inline `// eslint-disable-next-line i18next/no-literal-string` per glossary policy on brand names. Renamed sign_in_other → sign_in_different to avoid colliding with i18next's `_other` plural-suffix convention which the selector-API typings treated as a plural form of `sign_in`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate projects namespace Translates the projects list page, project detail page, project picker dropdown, and project chip — all four user-facing surfaces under packages/views/projects/components/. New file: projects/components/labels.ts exposes three hooks that replace the static `.label` field on PROJECT_STATUS_CONFIG / PROJECT_PRIORITY_CONFIG and the previous module-level `formatRelativeDate` helper. Core's `.label` stays untouched (it's still consumed by search and the create-project modal, both out-of-scope for this namespace) — those will flip when their respective namespaces translate. In zh, the "project" entity stays lowercase English per glossary (`新建 project`, `还没有 project`, `从 project 移除`). Status / priority / table column labels translate fully. The cancelled / done / paused etc. status labels duplicate per- namespace as `projects.status.*` rather than reading from a future shared status namespace. This matches the auth/inbox/workspace pattern of self-contained namespaces. If a generic "issue/project status" pool emerges later, these can collapse. Verified: pnpm --filter @multica/views typecheck (clean) + test (238/238) + ESLint clean on projects/ (1 pre-existing warning about useEffect/sidebarRef dep, unrelated to i18n). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate autopilots namespace Six tsx files: autopilots-page (list + 6 templates), autopilot-detail-page (properties / triggers / run history / delete), autopilot-dialog (create + edit dialog), trigger-config (cron form), and the agent / timezone pickers. Hook conversions for module-level helpers that need t(): - summarizeTrigger / describeTrigger → useSummarizeTrigger / useDescribeTrigger (no external callers, removed the plain exports) - formatRelativeDate → useFormatRelativeDate (per-component hook) - formatCountdown → useFormatCountdown (per-component hook) - TEMPLATES array now keyed by id; titles + summaries pull from templates/{id}/{title,summary} JSON. Prompts stay raw EN since they're injected directly into the agent task — translating them would translate the agent's instructions, not the user's UI. Status / execution-mode / run-status enums render via t($ => $.status[k]) with k typed against the core type (no separate hook needed). Verified: pnpm --filter @multica/views typecheck (clean) + test (238/238) + ESLint clean on autopilots/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate skills namespace Seven tsx files: skills-page (list + filters + intro banner), skill-detail-page (the giant — properties + file tree + sidebar + conflict banner + delete dialog, ~963 lines), create-skill-dialog (chooser + manual + URL forms), runtime-local-skill-import-panel (local runtime browse + import), skill-columns, file-tree, file-viewer. Notable patterns: - `createSkillColumns` factory → `useSkillColumns` hook so column headers flow through useT. Column identity changes per render is fine — DataTable handles it. - `validateNewFilePath` (pure helper) → `useValidateNewFilePath` hook so the 5 validation error messages can be translated. - skill_files / used_by / description_with_agents use i18next plural keys (`_one` / `_other`) — the type system collapses these into a single PluralValue access, so call sites use `t($ => $.foo, { count })` and i18next picks the form. - Per glossary, "skill" stays lowercase EN in zh ("新建 skill", "已删除 skill", "未找到该 skill"). Test wrapper: runtime-local-skill-import-panel.test.tsx now wraps render() with <I18nProvider> so the assertion on /Import to Workspace/i matches the EN translation. Verified: pnpm --filter @multica/views typecheck (clean) + test (238/238) + ESLint clean on skills/. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate chat namespace Translates all 10 chat surfaces: FAB tooltip, input placeholders, message list (replied-in / failed-after / tools group / show-details / tool result preview), session history (header + time-ago labels), chat window (new-chat / restore / expand / minimize / agent + session dropdowns / starter prompts / empty states), context-anchor button + card tooltips, no-agent banner, offline / unstable banner, and the task-status pill (queued / starting up / thinking / typing + tool labels: running command / reading files / searching code / making edits / searching web). Hook conversions: - formatTimeAgo (chat-session-history) → useFormatTimeAgo - ElapsedCaption now takes a typed `variant` ("replied" | "failed") instead of a free-text `verb` so the i18n key is enumerable - pickStage (task-status-pill) refactored: pure pickStageKeys returns StageKey + optional ToolKey; useResolveStage maps to localized labels Translation policy notes: - Starter prompts ("List my open tasks by priority", etc.) are user UI when displayed AND the user's input when clicked — translating them sends the agent the user's locale-native phrasing, which is the right UX for a CN user using a CN agent. - buildAnchorMarkdown (chat-window) stays in English: it's an agent-bound markdown prefix injected into the outgoing message, not user-facing UI. Verified: pnpm --filter @multica/views typecheck (clean) + test (238/238). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate modals namespace Translates all 11 modal sources: registry (no UI text), backlog-agent-hint, set-parent-issue, add-child-issue, delete-issue-confirm, feedback, issue-picker, create-workspace, create-project, create-issue (manual), quick-create-issue (agent panel). Notable patterns: - create-project re-uses useProjectStatusLabels / useProjectPriorityLabels hooks from views/projects/components/labels — same translation source as the projects list / detail, no duplication. - create-issue.tsx: renamed `toast.custom((t) => ...)` callback param to `toastId` to avoid shadowing the closure-captured useT() `t` function. - Test wrapper added to modals/create-issue.test.tsx so the two assertions on rendered modal text (success toast + Create another) match the EN bundle. modals/create-workspace.test.tsx was already wrapped (workspace ns commit). Verified: pnpm --filter @multica/views typecheck (clean) + test (238/238). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate settings namespace (rest of tabs) Builds on the appearance-tab + language switcher already shipped in Phase 0. Translates the remaining 8 settings surfaces: settings-page shell (left nav + tab keys), account / profile, notifications-tab (5 group labels + descriptions), tokens-tab (create / list / revoke / created dialog), workspace-tab (general fields + danger zone + leave/delete confirmations), members-tab (invite + role config + revoke / remove flows), repositories-tab, labs-tab, delete-workspace-dialog. Hook conversion: members-tab `roleConfig` static const → `useRoleLabels` hook returning a Record<MemberRole, {label, description, icon}>. The icon stays as a typed React component (Crown / Shield / User), so rendering pattern is unchanged at call sites. Test wrapper: settings/components/delete-workspace-dialog.test.tsx now wraps render() with <I18nProvider> (custom render() helper) because the test asserts on rendered button labels ("Delete workspace", "Cancel", "Deleting..."). Verified: pnpm --filter @multica/views typecheck (clean) + test (238/238). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate runtimes namespace (entry surfaces) Translates the user-facing runtime list page surfaces: runtimes-page (header / search / filters / chips / empty / no-matches / bootstrapping), runtime-detail (topbar + delete dialog + delete toasts), runtime-detail-page (not-found state), shared.tsx (4-state HealthBadge labels). Hook conversion: shared `healthLabel(health)` was a pure module-level function. Added `useHealthLabel` hook for translated call sites; kept `healthLabel` as an EN-only fallback for non-component callers (column factory in runtime-columns). Deferred: - runtime-list / runtime-columns (data table column headers + cell bodies) — large surface, not in the page-load critical path. - connect-remote-dialog / update-section / usage-section — secondary flows, English remains acceptable until a focused pass. - charts/* — primarily numeric tooltips and axes; minimal user-visible text. Verified: pnpm --filter @multica/views typecheck (clean) + test (238/238). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate layout namespace (sidebar nav, help, loader) Translates the cross-cutting layout chrome: - 9 sidebar nav labels (inbox / my issues / issues / projects / autopilots / agents / runtimes / skills / settings) — driven by labelKey instead of inline strings, resolved via useT at render. - HelpLauncher dropdown (trigger aria + 3 items: Docs / Change log / Feedback) - WorkspaceLoader (named + unnamed loading states) - SortablePinItem unpin tooltip Pattern shift in app-sidebar.tsx: nav arrays carry `labelKey: NavLabelKey` (typed against the layout JSON) instead of `label: string`. The string comparison checks (`item.label === "Inbox"`) became cleaner ID-based checks (`item.key === "inbox"`). Deferred: deeper sidebar surfaces — workspace switcher dropdown, "New Issue" CTA, "Pinned" / "Workspace" / "Configure" group labels — remain English. The 9 nav labels are the ones that read in every session. Verified: pnpm --filter @multica/views typecheck (clean) + test (238/238). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate onboarding namespace (welcome + step header) Translates the user-first-impression surfaces of the onboarding flow: - step-welcome.tsx (the wordmark, headline, lede paragraphs, all CTAs: Download Desktop / Continue on web / Start exploring / I've done this before, illustration caption) - step-header.tsx ("Step N of M" counter + matching aria-label) - onboarding-flow.tsx (skip-onboarding error toast) Test wrapper added to onboarding/components/step-header.test.tsx — custom render() helper wraps with <I18nProvider> so the "Step 2 of 5" assertions match the EN bundle. Deferred (acceptable English fallback for now): step-questionnaire, step-workspace, step-runtime-connect, step-platform-fork, step-agent, step-first-issue, cli-install-instructions, option-card, runtime aside panels, starter-content-prompt, cloud-waitlist-expand. These are deeper steps with significant copy that would benefit from a focused dedicated pass — voice on each is more nuanced (questionnaire options, runtime install instructions, agent template recommendations). Verified: pnpm --filter @multica/views typecheck (clean) + test (238/238). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(i18n): add EN/zh-Hans key parity guard Schema-level vitest that walks RESOURCES.en and RESOURCES["zh-Hans"] namespace by namespace and asserts both bundles cover the same key set. i18next plural rule is normalized before compare (`_one` / `_other` collapse to a single logical key) so EN's plural pair matches zh's `_other`-only form. Catches retrofit drift where a new EN key lands without zh — previously this would silently fall back to the English string in production. Cheap to keep green: 39 tests across 21 namespaces in under a second. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate issues namespace Translates the entire issues surface — list / board / detail / comments / sub-issues / activity feed / batch toolbar / pickers / context menu / backlog-agent hint dialog / labels panel. Component coverage: - issues-page (page header, empty state, move-failed toast) - issues-header (scope tabs, filter dropdowns w/ status/priority/ assignee/creator/project/label, display settings, sort, view toggle) - issue-detail (page header, breadcrumb, properties / parent issue / details / token usage sections, sub-issues, activity timeline, formatActivity for status/priority/assignee/title/due-date changes, subscribe/subscriber popover) - comment-card + comment-input + reply-input (delete dialog, edit/save, copy/edit/delete row, reply count, placeholders, expand/collapse) - agent-live-card (is-working banner, tool count, stop / transcript) - execution-log-section (section header, show/hide past runs, trigger text builder, status labels, cancel-task) - batch-action-toolbar (selected count, delete dialog with plurals) - backlog-agent-hint-dialog (full dialog content) - labels-panel (intro, create form, list, delete dialog) - pickers (status / priority / assignee / due-date / label / property search placeholder + no-results) - issue-actions-menu-items (all dropdown / context menu items) - use-issue-actions / use-issue-timeline (toast strings) STATUS_CONFIG / PRIORITY_CONFIG label rendering routed through $.status[enum] / $.priority[enum] at every call site; the core config keeps its English fallback for non-i18n consumers but UI never reads .label directly anymore. Tests retrofitted: issues-page, issue-detail, and issue-actions-menu RTL specs now wrap renders in <I18nProvider> with the EN bundle, so their string assertions match the bundle (not hardcoded literals). ESLint i18next allow-list extended to 24 issues files. Verified: pnpm --filter @multica/views typecheck + test (277/277) all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate agents namespace Translates the agents listing + detail surface and the create/duplicate flow. Covers the high-frequency surfaces; deeper sub-tab editors (activity / instructions / skills / env / custom-args bodies, and the hooks-buggy runtime/model/concurrency pickers) are deferred — they have their own pre-existing react-hooks rule violations and benefit from a focused dedicated pass. Component coverage: - agents-page (page header w/ tagline + new button, scope segment, search, sort dropdown, availability chips, archived toolbar, empty state, no-matches messaging w/ search interpolation, list-load error) - agent-detail-page (back link, archived banner, archive dialog, not-found state, all 4 toast strings) - agent-detail-inspector (avatar editor, name + description popover, description dialog, every PropRow label, validation message, presence badge label sourced from $.availability[enum]) - agent-overview-pane (tab labels, discard-unsaved-changes dialog) - create-agent-dialog (title / description / labels / placeholders / duplicate-suffix / runtime filter buttons / runtime status copy) - agent-row-actions (full dropdown items + cancel-tasks dialog with pluralized "N running + M queued" summary + archive dialog + 6 toasts) - agent-columns (every header cell, You / Archived chips, runtime fallback labels, availability + workload labels via $.availability / $.workload, activity tooltip body w/ created_today / created_days_ago / runs / failed-percent interpolation) - inspector/skill-attach (Attach trigger label + aria) availabilityConfig and workloadConfig now keep colors only — the display label lives in the bundle, sourced via $.availability[enum] and $.workload[enum] at every call site. Same pattern as STATUS_CONFIG/PRIORITY_CONFIG in the issues namespace. ESLint i18next allow-list extended to 8 agents files. Verified: pnpm --filter @multica/views typecheck + test (277/277) all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(i18n): clear 30 stray EN strings in translated files Tail of literal strings missed in earlier passes — the ESLint i18next allow-list flagged them but they slipped through review. Files touched: - layout/app-sidebar.tsx (10 keys: Workspaces / Pending invitations / Create workspace / Join / Decline / Log out / New Issue + shortcut / Pinned / Workspace / Configure) - runtimes/components/runtime-detail.tsx (Serving header + serving_count pluralization, no_agents copy, running/queued chips with count interpolation, Diagnostics header, CLI label, Delete runtime button, Technical details toggle, last seen interpolation) - onboarding/steps/step-welcome.tsx (entire WelcomeIllustration mock — 5 cards × actor names + body copy + 3 mention chips + 2 timestamps; zh translation reads naturally instead of leaving the demo English) - settings/components/labs-tab.tsx (`Co-authored-by: ...` git trailer wrapped in {} so linter sees a JS string, not JSX text — magic identifier git relies on, must not translate) - settings/components/members-tab.tsx (✓ glyph wrapped in {}) - modals/feedback.tsx (⌘↵ shortcut wrapped in {}) ServingAgentsCard now reads availability/workload labels from `agents` namespace (cross-namespace useT) so the bundle-truth pattern holds: presenceConfig keeps colours only, label text comes from the shared bundle. Verified: typecheck + 277/277 tests + lint (only the pre-existing react-hooks rule-of-hooks errors remain, which task #6 addresses). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(agents): rules-of-hooks + translate 4 model/runtime pickers Three pre-existing react-hooks/rules-of-hooks violations + one missing useMemo dep cleared, then the four pickers wired through useT. Hook order fixes: - concurrency-picker: useEffect now runs before the !canEdit early return. Stale-draft reset still works the same way. - runtime-picker: useMemo for the filtered list moved above the !canEdit branch. - model-dropdown: `models = data?.models ?? []` was minting a fresh array each render and tripping the deps lint of the downstream useMemo. Wrap in useMemo so the reference is stable. Translation coverage: - concurrency-picker: tooltip ("Concurrency · N max..."), range helper text, Save button. - runtime-picker: trigger label fallback ("No runtime"), tooltip text composed from {{name}} + status, Mine/All filter buttons, empty-list copy, "owned by {{name}}" + status fragments in row tooltip, Cloud badge, online/offline aria. - model-picker: trigger label, tooltip, "Managed by runtime" fallback, search placeholder, "Discovering models…", default badge, "No models available", "Use \"X\"" custom-id flow, Clear button + its title. - model-dropdown: every label string including the "Select a runtime first" / "Default (provider)" / "Runtime offline — enter manually" trigger fallbacks, the supported=false explanation block, discovery failed badge, all popover items. ESLint allow-list extended to 4 picker files. Verified: typecheck + 277/277 tests + lint (0 errors, only pre-existing react-hooks warnings in unrelated files). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate runtimes list + connect dialog + CLI updater Three deep runtime surfaces wired through useT, with the agents namespace doing double duty for shared availability/workload labels. runtime-columns: - 7 column headers via t-augmented createRuntimeColumns({ t }). - HealthCell now reads from useHealthLabel() (already translation-aware) instead of the EN-only healthLabel() helper. - WorkloadCell sources the label from $.workload[enum] (cross-namespace to agents) — colour stays via workloadConfig. - CostCell delta "flat" copy + CLI cell "Desktop" badge + update- available aria/tooltip + RowMenu's full delete dialog (title / description with {{name}} interpolation / cancel / confirm / deleting state) plus its admin-permission hint. connect-remote-dialog: - Three steps fully translated: instructions (header + 4 numbered steps + security warning + troubleshooting list with mono code snippets escaped as JS strings), waiting (loader + hint), success (CTA pair). - Mono CLI commands wrapped in {} so linter sees JS strings — those are literal commands that must stay untranslated for the user to paste into a terminal. update-section: - statusConfig collapsed to icon+colour only; labels move to $.update.status[enum] for proper translation per-state. - "CLI Version:" / "Latest" / "available" / "Update" / "Retry" copy + the "Managed by Desktop" tooltip and disabled hint. Layout helpers tagged: runtime-list passes `t` through to the column factory the same way agent-columns does. ESLint allow-list extended with the 4 wired files. Verified: typecheck + 277/277 tests + 0 i18n lint errors. usage-section.tsx (KPI cards / WhenChart / TopUsageBreakdown / receipt table) is the remaining runtimes surface — chart-heavy and benefits from a focused pass next. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate 5 agent detail tabs + skill-add dialog The 5 tabs that fill the agent detail right pane plus the shared skill picker dialog. Agents bundle gains a `tab_body` block with sub-namespaces per tab + a `common` slot for save/add/unsaved. Tab coverage: - instructions-tab: intro paragraph, multi-line example placeholder (full 18-line zh translation), Save / Unsaved. - env-tab: read-only intro / empty state, editable intro with two inline `<code>` env-var examples kept English (mono terminal payloads), KEY / value placeholders, Show/Hide value aria, Add / Remove aria, all 3 toasts (duplicate keys / saved / save failed). - custom-args-tab: intro about whitespace splitting, launch-mode prefix line + `<your args>` placeholder, --flag value placeholder, Add, Remove aria, both toasts. - skills-tab: intro, Add skill button, import-hint callout, empty state title + hint + add-CTA, remove-failed toast. - activity-tab: 3 section titles (Now / Last 30 days / Recent work), active-task pluralization, performance subtitle, all 3 empty states, runs/success%/avg-duration/failed pluralization with interpolation, source labels (Issue / Chat / Autopilot / Untracked), source fallbacks (Quick create / Creating issue / Chat session / Autopilot run), issue-short fallback, "Triggered by" tooltip header, open-issue / transcript / cancel-task tooltips and ARIAs, cancelling state, started/dispatched/queued time prefixes, show more. - skill-add-dialog: dialog title + description, empty list copy, Cancel button, add-failed toast. skills-tab.test.tsx wrapped in <I18nProvider> with the EN bundle so its `Local runtime skills are always available` assertion still matches the resolved translation instead of the raw key path. ESLint allow-list extended with the 6 wired files. Verified: typecheck + 277/277 tests + 0 i18n lint errors. Only the per-test mock for skills-tab needed wrapping; the other 4 tabs ship without test files of their own and inherit the I18nProvider chain via agent-overview-pane / agent-detail-page test renders (when those exist later). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate onboarding step-questionnaire + option-card The user-profile step (3 questions) is the first deferred onboarding deep step now wired through useT. step-questionnaire: - Eyebrow + headline + answered-progress counter with {{count}} interpolation - All 3 questions and their option labels (team size / role / use case) - All 3 "Other" placeholders for free-text fallback - Right-rail "Why three questions" / "What you get" panel: 2 eyebrow rows, 2 unlock-item title+body pairs, learn-more link - Back / Continue buttons via shared `common` block option-card: shared "Other" radio label and aria. Test wrapped in <I18nProvider>. EN value of `other_label` kept as "Other" so the existing /^other$/i regex in step-questionnaire.test keeps matching after the rendering pipeline switched from a hardcoded literal to a bundle lookup. ESLint allow-list extended with these 2 files. The remaining 4 deep steps (workspace / runtime-connect / platform-fork / agent), the 2 ancillary surfaces (cli-install-instructions / starter-content- prompt), and the 3 side panels (runtime-aside-panel / cloud-waitlist- expand / compact-runtime-row) will be surfaced + swept by the global ESLint switch (next commit). Verified: typecheck + 277/277 tests + 0 i18n lint errors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): flip ESLint to glob + drain remaining hardcoded EN ESLint i18next/no-literal-string now applies to **/*.tsx by default instead of an explicit allow-list. Files that genuinely still need hardcoded EN are listed in STILL_HARDCODED — concrete, finite, and the goal is to drain that list to zero. Tail strings translated in this commit (surfaced by the global flip): - common/task-transcript/agent-transcript-dialog.tsx — full dialog: status badge (Running / Completed / Failed), sr-only DialogTitle, Filter dropdown trigger + Clear filters, Copy all / Copy filtered / Copied, tool-calls + events metadata chips with pluralization, events-filtered "{{shown}} of {{total}}" interpolation, "Waiting for events..." live state, "No execution data recorded." past state. New `transcript` block in agents namespace. - runtimes/components/charts/activity-heatmap.tsx — Less / More legend labels around the contribution-style heat squares. - search/search-trigger.tsx — sidebar Search... button label. ⌘ glyph wrapped in {} to satisfy the linter (mono shortcut symbol, not translatable). Holdouts (STILL_HARDCODED, ~14 files): the deep onboarding steps (workspace / runtime-connect / platform-fork / agent / first-issue / cli-install-instructions, plus 4 ancillary panels), the runtimes usage-section + KPI cards, and 5 minor agent visual primitives (sparkline / agent-presence-indicator / agent-profile-card / visibility-badge / char-counter). Each one gets a dedicated future pass; the global rule prevents new hardcoded strings from landing elsewhere. Verified: typecheck + 277/277 tests + 0 i18n lint errors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): drain agent visual primitives + onboarding small components 8 files removed from STILL_HARDCODED: agents/components/: - char-counter — over-limit text with {{count}} interpolation - visibility-badge — uses new agents.visibility.{private,workspace}. {label,tooltip} block; drops VISIBILITY_LABEL/TOOLTIP imports from core in favour of bundle-driven copy - agent-presence-indicator — availability + workload labels via $.availability[enum] / $.workload[enum] (cross-namespace), queue-badge "+N queued" with pluralization - agent-profile-card — Agent unavailable / Detail link / Owner / Skills / Runtime / Unknown runtime / Archived chip / availability line via cross-namespace lookup agents.json: new presence + visibility + profile_card + char_counter blocks. onboarding/components/: - compact-runtime-row — online/offline aria via agents.availability - runtime-aside-panel — full content (What's a runtime / Good to know / Swap anytime / Add more later / docs link) - starter-content-prompt — full dialog (title / description with inline emphasis / both buttons / 3 toasts) - cloud-waitlist-expand — intro paragraph + warning span / email + reason labels + placeholders + Optional badge / Join + on-list states / both toasts onboarding/steps/: - cli-install-instructions — copy aria + intro + 2 step labels onboarding.json: new runtime_aside / cli_install / starter_content / cloud_waitlist blocks. Tests for step-platform-fork + step-runtime-connect wrapped in <I18nProvider> with EN bundle so /you're on the list/i etc. still matches the resolved translations. Verified: typecheck + 277/277 tests + 0 i18n lint errors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate onboarding deep steps The 5 large onboarding steps that were deferred from earlier passes, plus their support helpers, all wired through useT. step-first-issue (final beat — flips onboarded_at): - error_title / Retry / retry_failed toast / finishing / opening states. step-agent (creates the user's first agent): - Templates moved from a module-level const to a useT-driven useAgentTemplates() hook. Names + emoji stay constant (visual identity), labels + blurbs + instructions resolve from the bundle. coding / planning / writing / assistant — all four templates ship a full zh translation that reads naturally. - Recommended badge, eyebrow + headline + lede, footer hint, Create {{name}} CTA, create_failed toast. - Right-rail "About agents" panel (4 way-items + headline + add-more hint + docs link). step-workspace (create or pick existing): - 5 footer states (open / creating / creating-pending / name-first / pick), all hint + CTA strings via interpolation. - Name + URL + slug placeholders, issue-prefix preview spans, Create-new card title + subtitle. - 8-row WorkspacePreviewCard sidebar (Inbox / Issues / Agents / Projects / Autopilot / Runtimes / Skills / And more) — every label + meta strapped to bundle keys. - 4 perks (assign / chat / invite / switch) + 3 next-steps (runtime / agent / starter), 2 toasts (slug-conflict / failed). - `multica.ai/${slug}` mono URL escaped via template-literal expression so the linter sees a JS string. step-runtime-connect (desktop scan flow): - 3 phase headlines + ledes (scanning / found / empty), trust-strip status (all online / N online / none online) with pluralization, online/offline labels, Skip / Continue / Selected hint. - Empty-view 2 cards (skip + waitlist) and the cloud waitlist dialog wrapper. step-platform-fork (web fan-out): - Eyebrow + headline + lede, footer hint with 3 phase variants. - Primary download card (before/after click) + 2 alt cards (CLI / cloud) + CLI dialog with 4 elapsed-time stages (normal / midway / slow / stalled), live-listening header, runtime-connected pluralization, cloud waitlist dialog. ESLint: STILL_HARDCODED list shrunk from 14 entries to 1 — only runtimes/components/usage-section.tsx (chart-heavy KPI panel) remains. Verified: typecheck + 277/277 tests + 0 i18n lint errors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate runtimes usage panel + drop STILL_HARDCODED Final i18n holdout: the runtimes usage panel (KPI hero, WHEN chart tabs, cost-by breakdowns, daily breakdown table) is wired through useT("runtimes"). With this drained, the eslint scaffolding for explicit holdouts is removed — every JSX text node in @multica/views now flows through i18n. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(i18n): drain rollout gaps + add cross-device sync Lands the post-review punch list for the i18n rollout: closes correctness gaps that would have shipped silently, and adds the missing cross-device locale sync the rollout's docs already promised. Coverage: - Register issues + agents namespaces in RESOURCES (90 useT call sites were rendering keys-as-text in production) - Harden parity test to compare RESOURCES keys against on-disk JSON files, so a future missing namespace registration fails loudly - Server-side language whitelist in UpdateMe + reject-unsupported test - Safe SupportedLocale resolution in appearance-tab (no more `as` cast on a region-tagged BCP-47 string) - HTML lang attribute uses zh-CN (not zh-Hans) for screen reader / CJK font-stack compatibility - Cookie Secure flag on https - Pulled createBrowserCookieLocaleAdapter out of the server-safe entry into a new @multica/core/i18n/browser subpath; document.cookie access can no longer leak into Edge middleware imports Cross-device sync: - New UserLocaleSync component mounted in CoreProvider; on login, if user.language differs from the active i18n.language, persist via the adapter and reload. Both apps benefit - Desktop main process tracks system locale and emits IPC on focus when it changes; renderer reloads only when the user has no explicit Settings choice (their preference still wins) Tests: - pickLocale / matchLocale (11 cases incl. region-tagged BCP-47, malformed tags, zh-Hant collapse-to-zh-Hans semantics) - browser-cookie-adapter (6 cases under jsdom) - Shared renderWithI18n helper at packages/views/test/i18n.tsx that wraps the real RESOURCES map; future tests opt in instead of inlining a per-file TEST_RESOURCES slice that goes stale silently Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(conventions): consolidate naming + i18n glossary into docs site Single source of truth for code naming, i18n translation glossary, and Chinese voice rules. Previously split between packages/views/locales/glossary.md and scattered comments — now lives at apps/docs/content/docs/developers/conventions.{mdx,zh.mdx} with both English and Chinese versions kept in sync. Three sections per page: 1. Code naming — routes, packages, files, DB, Go, TS, commits 2. i18n translation glossary — entity vs concept rule, what to translate, word combination, plurals, interpolation, key naming 3. Chinese voice + style — punctuation, principles, where to look in doubt Side effects: - packages/views/locales/glossary.md collapses to a stub redirecting to the docs page; do not edit it - CLAUDE.md gets a new top-level "Conventions reference" section so any Claude session sees the pointer before any other rule - apps/docs/content/docs/developers/ gets a stub English meta.json so the conventions page is reachable on the EN side (contributing.zh.mdx / architecture.zh.mdx remain ZH-only — separate work) - Both root sidebars get a new "Developers" group Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(i18n): apply zh voice rules + translate project/autopilot Two-part cleanup driven by the conventions doc landed last commit: Voice violations (mechanical sweep across 10 zh-Hans namespaces): - 「」 (Japanese-style brackets) → \" to match the EN source's straight double quotes (~13 sites) - … (single-char ellipsis) → ... three dots (~43 sites) - Drop translation-ese pronoun "我们" where it's a pure narrator ("我们已发送" → "已发送", "我们替你托管" → "由 Multica 托管"); keep "告诉我们" where "we" is the legitimate brand recipient - "作为父级 / 作为子级" → "设为父级 / 设为子级" - "任务" mistranslated as the task entity → `task` (lowercase EN entity) - Dialog title "Autopilot" → "autopilot" Translate project / autopilot per industry consensus: - `project` → 「项目」 (~42 value sites). Feishu / Tower / Teambition / PingCode / GitHub Projects all translate; no Chinese product keeps `project`. - `autopilot` → 「自动化」 (~34 value sites). Avoids the Tesla-style 「自动驾驶」 association; matches Notion / Feishu's industry term. - Issue / skill / task remain lowercase EN per dev-team familiarity. - Sidebar nav-label entities get Title Case ("Issue" / "Skill" / "我的 Issue") so the entry-point label reads as a proper UI signal; body prose stays lowercase. Conventions doc (EN + ZH) reflects the decision and adds a "why these translate but issue/skill/task don't" rationale block. Verification: parity test 45/45, full monorepo typecheck green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(i18n): translate chat session delete + project resources section Two features main shipped while this branch was idle never went through the i18n pass: - Chat session delete confirmation dialog (#2115) and history toggle tooltip (#2117): adds session_history.delete_dialog.* and session_history.row_delete_*, plus window.history_show_tooltip / history_back_tooltip. - Project resources sidebar (#1926/#2080/#2111): entire component including toasts, popover form, attach/remove tooltips. New projects.resources subtree. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-06 16:16:12 +08:00
Naiyuan Qing	5335edd50d	feat(web): /download page + desktop promotion across landing, login, onboarding (#1500) ... * docs(download): add redesign plan and copy positioning source of truth Captures motivation (Desktop is Multica's native form; CLI is a distinct scenario for servers/remote boxes, not a Desktop fallback), four-step execution plan, and every touchpoint's current-vs-new copy in EN + ZH. Subsequent UI steps read strings from the positioning doc instead of inventing them inline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(web): /download page with OS auto-detection New landing-group route that serves as the single canonical download destination. Auto-detects OS + arch via navigator.userAgentData (Chromium) with UA-string fallback, then surfaces the matching Desktop installer as the primary CTA. All platforms stay visible below, plus a CLI section (positioned for servers / remote boxes / headless setups, not as a lightweight Desktop) and a Cloud waitlist. Version + asset URLs come from api.github.com/repos/.../releases/latest with Vercel ISR (revalidate=300) so every release automatically propagates — no manual redeploy. Optional GITHUB_TOKEN env var lifts the 60/hr unauthenticated rate limit for local dev. Failure degrades cleanly to "Version unavailable" + a link to GitHub releases. Also points landing hero + footer Download links at /download (previously pointed at the GitHub releases page directly), and re-exports CloudWaitlistExpand from @multica/views/onboarding so the new Cloud section can reuse the existing form. Intel Mac has no binary today (electron-builder targets mac arm64 only); the page is honest about it and routes Intel users to CLI. i18n copy sourced verbatim from docs/download-positioning.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(onboarding): rewrite Step 3 fork + web Welcome Desktop CTA Welcome screen now self-segments: on web (runtimeInstructions present), the primary CTA is "Download Desktop" with a benefit-led subtitle ("Desktop bundles the runtime — nothing to install. Continue on web to connect your own CLI.") that lets developers with their own CLI recognize their path while guiding everyone else toward the desktop app. Desktop branch drops the "3 minutes" estimate in favor of the aha promise. Download button is a real <a href> link so middle-click / copy-link / screen readers all behave correctly. Step 3 fork drops the stale isMac gate — Windows / Linux binaries now ship, the macOS-only muted card was a lie. The single Desktop card now routes to /download (not GitHub releases directly) so users land on the auto-detect page. CLI card is reframed around its real scenario (servers, remote dev boxes, headless) rather than posing as a lightweight Desktop, and the CLI dialog's stall tier redirects users to Desktop instead of Cloud waitlist when the daemon never registers — Desktop is the genuine retreat. cli-install-instructions gets a one-liner acknowledging the CLI's server use case, mirroring the card copy. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(web,auth): desktop promotion on login + solid landing hero download LoginPage accepts a new `extra?: ReactNode` slot rendered below the Google button. The web shell injects a hardcoded-EN "Prefer the desktop app? Download →" nudge there — catching users at their lowest-investment moment, before they've typed an email. Desktop's login wrapper omits the slot (a download prompt inside the app would be absurd), so only the web surface renders it. Copy is English-only for now because the /login route sits outside the landing group's LocaleProvider. Lifting locale detection into the root layout would force every page dynamic and kill the Router Cache — a trade-off not worth two strings. The `auth.login.extra*` i18n keys added during Step 2 are removed for the same reason: they're dead code without a LocaleProvider wrapping login. Landing hero "Download Desktop" upgrades from ghost to solid and swaps its handwritten monitor SVG for lucide-react's Download icon. Both hero CTAs are now solid-weighted — the icon + distinct label differentiates them. href already points to /download from the Step 2 landing nav pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(web/download): anchor dark LandingHeader with relative wrapper LandingHeader's dark variant uses `absolute top-0 inset-x-0`, which only reads correctly when wrapped by a positioned ancestor — see multica-landing.tsx:14 for the canonical pattern. Without the wrapper the header escaped to the initial containing block and appeared fixed as users scrolled the page. Also drops the <main> element around the body sections for consistency with the rest of the landing group (neither multica-landing nor about-page-client wraps in <main>). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(landing/hero): keep Download Desktop as ghost to preserve CTA hierarchy Upgrading to solid alongside the existing "Start free trial" CTA killed the primary / secondary distinction — both buttons were white on dark, competing for attention. Revert to ghost so the conversion CTA (trial) stays the visual primary. The lucide Download icon swap stays (cleaner than the handwritten monitor SVG). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(onboarding): update platform-fork assertions for /download route The Desktop card in Step 3 now opens the new /download page instead of GitHub releases, and the post-click feedback text changed to match ("Continuing on the download page…" in place of "Downloading Multica…"). Update the expectations and drop the isMac navigator stub that was only needed when the component had a macOS-only primary branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Merge origin/main into NevilleQingNY/download-redesign Main added onboarding funnel analytics (#1489) that captures `is_mac` as a dimension for each Step 3 path selection. This branch had removed the `isMac` state because the UI no longer branches on it (Windows / Linux desktop builds ship now). Git auto-merged the two diffs into a file that referenced a deleted variable. Reintroduce `isMac` as a lazy client-only computation scoped to analytics capture only — the UI stays platform-agnostic. Handlers fire client-side so SSR safety isn't needed; a plain const reads navigator on first render. typecheck passes across all 6 packages; all 166 views tests green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(analytics): instrument download funnel across 5 surfaces + /download Closes the gap left by PR #1489: onboarding analytics captured Step 3 path selection but missed the four surfaces that advertise the desktop app earlier in the funnel (landing hero, landing footer, login, Welcome), and the /download page itself had zero coverage — so we could see the last-mile path but not the top-of-funnel entry nor the page-to-installer conversion. Three new events, wired via `@multica/core/analytics`: 1. `download_intent_expressed` fires on any CTA pointing at /download. `source` splits the five surfaces cleanly; every authenticated emission also writes `platform_preference=desktop` on the person (same convention Step 3 already uses). 2. `download_page_viewed` fires once per /download mount after OS detect resolves. Carries `detected_os`, `detected_arch`, `detect_confident` (Chromium userAgentData vs UA fallback), and `version_available` so the Safari-on-Mac arm64-default cohort and GitHub-rate-limited degraded sessions are each isolable. Also $set_once's `first_detected_os/arch` on the person so every downstream event gains a platform dimension without re-emitting. 3. `download_initiated` fires on every installer click — Hero's primary CTA and each All Platforms matrix row. `primary_cta` splits hero-recommended from manual picks; `matched_detect` quantifies detect accuracy from the single event (no cross-join to download_page_viewed needed). Augments the existing `onboarding_runtime_path_selected` with a `source: "step3"` property — literal today, reserved for future surfaces reusing the same event name. `is_mac` kept for backward-compat with PR #1489's dashboards; the new events use `detected_os` + `detected_arch` instead. New `setPersonPropertiesOnce` wire helper in `packages/core/analytics/download.ts` for `$set_once` — mirrors the backend's `Event.SetOnce` semantics. docs/analytics.md update lands in the follow-up commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(analytics): document download_intent_expressed / page_viewed / initiated Adds the three new download-funnel events to the frontend-only section. Also notes the semantic shift on onboarding_runtime_path_selected: its `path: "download_desktop"` now signals Step 3 path choice, not actual download start — download_intent_expressed is the new canonical "user expressed intent to download desktop" signal across surfaces. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-22 17:25:01 +08:00
Naiyuan Qing	6d6bc5a6f2	fix(routing): rename /new-workspace to /workspaces/new + extend reserved slug list (#1188) ... * fix(routing): rename /new-workspace to /workspaces/new + extend reserved slug list Two related changes: 1. Rename the global workspace-creation route from /new-workspace to /workspaces/new. The hyphenated word-group `new-workspace` is a common user workspace name (last deploy was blocked by a real user with exactly this slug). Industry consensus from auditing Linear, Vercel, Notion, Slack, GitHub: zero major SaaS uses hyphenated word-group root routes — they all use single words or `/{noun}/{verb}` pairs. Reserving the noun `workspaces` automatically protects the entire `/workspaces/*` subtree, so future workspace-related routes (`/workspaces/{id}/edit`, `/workspaces/{id}/billing`, etc.) need no additional reserved slugs or audit migrations. 2. Extend the reserved slug list to cover the minimal set recommended by the URL-design audit: full auth flow vocab, RFC 2142 mailbox names (postmaster, abuse, noreply...), hostname confusables (mail, ftp, static, cdn...), and likely-future platform routes (docs, support, status, legal, privacy, terms, security, etc.). Production data audit confirmed zero conflicts for every newly added slug, so migration 047 (the safety net) passes cleanly. Slugs intentionally NOT added despite being in scope of the audit: admin, multica, new, setup, www. Each has one production workspace already using it; adding them now would block deploy. They will be handled in a follow-up PR via owner outreach + targeted rename. Also adds a CLAUDE.md convention rule: new global routes MUST use a single word or `/{noun}/{verb}` pair, never hyphenated word groups. This prevents the pattern from regenerating itself. This PR does NOT resolve the currently-blocked prd deploy — that requires the existing `slug='new-workspace'` workspace (owner: Dhruv Raina) to be renamed by ops. After that workspace is renamed and migration 046 passes, this PR's migration 047 will also pass on its first run. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * review: drop migration 046, sweep stale comments, drive reserved test from map Address code review on PR #1188: 1. Delete migration 046 (audit_new_workspace_slug). It audits "new-workspace" which is no longer a reserved slug after this PR's rename. Removing 046 has an unexpected upside: it directly unblocks the currently-stuck prd deploy. Migration 046 had never successfully applied (it was the source of the deploy block); the audit-only nature means down-rollback is a no-op. The user workspace previously caught by 046 (slug='new-workspace', owner: Dhruv Raina) is now safe — `new-workspace` is no longer reserved, so the slug correctly resolves to that workspace and the global route `/workspaces/new` doesn't shadow it. 2. Refactor workspace_test.go to drive its reserved-slug list from the reservedSlugs map directly via `for slug := range reservedSlugs`. The previous hand-copied list was already drifting (40-ish entries vs 58 in the map). Now drift is impossible. 3. Sweep ~10 stale `/new-workspace` references in code comments to `/workspaces/new`. Comments only — runtime unchanged. The references in reserved-slugs.ts/workspace_reserved_slugs.go and CLAUDE.md are intentionally kept as anti-pattern examples ("don't add hyphenated word-group root routes like /new-workspace"). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-16 21:21:20 +08:00
Naiyuan Qing	f3d20fd50d	fix(auth): 'Sign in as a different user' performs full logout (#1179) ... The NoAccessPage button previously only called nav.push('/login'), leaving the session cookie, React Query cache, and local auth state intact. AuthInitializer then silently re-authenticates and bounces the user right back to the workspace URL — the button appeared broken. Extract the logout flow (clear per-workspace storage, clear cookies, clear multica_tabs, queryClient.clear(), authStore.logout(), navigate to /login) into a shared useLogout() hook in packages/views/auth/. AppSidebar and NoAccessPage both use it now; any future logout entry point can too. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-16 19:43:10 +08:00
Naiyuan Qing	6a2432b16b	refactor: remove onboarding flow, fix daemon zero-workspace bootstrap (#1175) ... * fix(daemon): allow startup with zero workspaces The daemon used to fail fast with "no runtimes registered" when the initial workspace sync returned zero workspaces. This masked a latent bug: a newly-signed-up user has no workspaces yet, so the daemon would crash immediately after login instead of waiting for the first workspace to be created. workspaceSyncLoop already polls every 30s (daemon.go:107, 365) to discover new workspaces — the fail-fast check at startup was bypassing this dynamic discovery. Remove the check so the daemon stays resident and picks up the first workspace whenever it appears. PR #1001 partially addressed this for the "server has workspaces but local CLI config is empty" case. This finishes the job for the true zero-workspace state, which until now was masked by the onboarding wizard always creating a workspace before the daemon started. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor(views): extract CreateWorkspaceForm for reuse Modal and the upcoming /new-workspace page share the same form + mutation + slug validation. Extract to a shared component so they can't drift. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat(views): add NoAccessPage for unknown or inaccessible workspace slugs Rendered when the URL slug doesn't resolve to a workspace the user has access to. Deliberately doesn't distinguish 404 vs 403 to avoid letting attackers enumerate workspace slugs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat(paths): add /new-workspace route and reserve slug on both sides Adds paths.newWorkspace() builder, registers /new-workspace as a global (pre-workspace) prefix, and reserves the "new-workspace" slug on both frontend and backend (kept in sync per convention). Existing "onboarding" reservation retained — removing it would desync FE/BE and leaves no future fallback if an onboarding route is revived. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore(migrations): audit no existing workspace uses 'new-workspace' slug Migration 046 blocks deploy if any workspace in the DB has slug = 'new-workspace', which would shadow the new global workspace creation route at /new-workspace. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: add /new-workspace route on web and desktop Renders the CreateWorkspaceForm as a full-page workspace creation flow, used as the destination for first-time users with zero workspaces. Replaces the 4-step onboarding wizard with a single form. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat: show NoAccessPage on unknown workspace slug, hold null during active removal Layouts render NoAccessPage when the URL slug doesn't resolve to an accessible workspace — except when the slug previously resolved during this layout instance's lifetime. URL and cache are two asynchronous signals: there will always be a short window where the URL still points at the old workspace but the cache has already been invalidated (e.g. just after a delete/leave mutation, or a realtime workspace:deleted event). Rendering NoAccessPage during that window would flash "Workspace not available" with recovery buttons in front of a user who just deleted the workspace themselves — jarring and wrong. useWorkspaceSeen classifies the two cases: - slug was seen before, now gone → user's intent is changing (caller is navigating away); render null, no flash - slug never seen → user is genuinely looking at an inaccessible workspace (stale bookmark, revoked access, link from a former teammate); render NoAccessPage with recovery options NoAccessPage deliberately does not distinguish 404 vs 403 to avoid letting attackers enumerate workspace slugs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: redirect zero-workspace users to /new-workspace instead of /onboarding Switches 8 call sites and the CLI: - Web: login, auth callback, landing redirect-if-authenticated - Desktop: routes.tsx IndexRedirect - Shared: dashboard guard, invite page fallback, workspace-tab on delete, realtime sync on workspace loss - CLI: cmd_login.go waitForOnboarding now opens /new-workspace Also adds /new-workspace to navigation store's lastPath exclusion list so it doesn't get persisted as a 'last visited' page. Adds a desktop App.tsx effect that restarts the daemon when workspace count transitions 0 → ≥1, so first-workspace creation triggers immediate daemon pickup rather than waiting up to 30s for the daemon's workspaceSyncLoop. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: remove onboarding flow The 4-step onboarding wizard (workspace → runtime → agent → demo issues) is replaced by: - /new-workspace: a single-page workspace creation form (Phase 3) - NoAccessPage: explicit feedback when a slug doesn't resolve (Phase 4) - daemon zero-workspace bootstrap (Phase 1) so the daemon doesn't crash before the user creates their first workspace - desktop daemon restart on first workspace creation (Phase 5) for instant pickup instead of the 30s workspaceSyncLoop tick Deletions: - packages/views/onboarding/ (OnboardingWizard + 4 step components + tests) - apps/web/app/(auth)/onboarding/page.tsx - apps/desktop/src/renderer/src/components/onboarding-gate.tsx (+test) - OnboardingGate wrapper in desktop-layout.tsx - OnboardingRoute + /onboarding route in desktop routes.tsx - paths.onboarding() builder + /onboarding from GLOBAL_PREFIXES - packages/views/package.json onboarding export - /onboarding from navigation store's EXCLUDED_PREFIXES Retained (intentional): - 'onboarding' in RESERVED_SLUGS (both FE + BE) — kept for FE/BE sync and future-proofing if /onboarding is ever revived Also drops 4 demo issues that onboarding used to create on the new workspace ('Say hello', 'Set up repo', etc.). New workspaces are now fully empty; all list views already render empty-state UI correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: clean stale 'onboarding' references in comments and CLI helpers Batch cleanup of references to the removed onboarding flow: - 13 comment sites mentioning 'onboarding' updated to reflect the new /new-workspace flow or removed where no longer accurate - CLI waitForOnboarding renamed to waitForWorkspaceCreation (function name + docstring); behavior unchanged The 'onboarding' reserved slug entries (frontend + backend) are intentionally retained — see prior commit rationale. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor(views): extract shared NewWorkspacePage shell The web (/new-workspace) and desktop (NewWorkspaceRoute) pages had identical outer layout — same container, heading, and copy — with only the onSuccess navigation primitive differing. That's exactly the No-Duplication Rule pattern: extract the shared UI, inject the platform-specific behavior. The apps now only own the thin auth guard (web needs it, desktop routes below WorkspaceRouteLayout already handle it) and the onSuccess → navigate call. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: remove rollback compat layer and tighten daemon restart trigger Two cleanup items: 1. Drop localStorage['multica_workspace_id'] double-write in both workspace layouts. That write was added as a rollback safety net for the workspace-slug URL refactor (PR #1138) — the refactor has since landed and stabilized, so the compat shim is no longer needed. Per CLAUDE.md: don't keep compat layers beyond their purpose. 2. Tighten the desktop daemon-restart trigger. The previous ref-based logic fired a restart on any 0→1 workspace-count transition, including account switches (user A logout → user B login). Scope it precisely to 'this session started with zero workspaces and just gained one' using a three-state ref (null=undecided, true=empty-start, false=already-restarted-or-started-nonempty). Account switches are already handled by daemon-manager.ts on token change, so this avoids a redundant restart there. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(auth): redirect to /login on logout and unauthenticated workspace visits Two gaps previously left users stuck on blank workspace pages: 1. app-sidebar logout() cleared all state but never moved the URL. The current path is /{workspaceSlug}/... which has no meaning without auth; the workspace layout would then see user=null, render null (via the hasBeenSeen short-circuit), and the user saw a blank page thinking logout didn't work. 2. The workspace layouts (web + desktop) had no !user handling at all. Any path that leaves user=null — token expiration, cross-tab logout, or fresh visit to a workspace URL without a session — resulted in the same blank screen. Fix: - app-sidebar.logout() explicitly push(paths.login()) after authLogout() to cover the primary (user-initiated) logout path. - Both workspace layouts get a defensive useEffect that redirects to /login whenever auth has settled and user is null. Covers token expiration, realtime logout, and any other silent session loss. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-16 19:18:43 +08:00
Naiyuan Qing	fe358feff0	Reapply "feat: workspace URL refactor v2 + rollback-safe compat layer (#1138)" (#1139) (#1141) ... This reverts commit b30fd98605.	2026-04-16 13:16:35 +08:00
Naiyuan Qing	b30fd98605	Revert "feat: workspace URL refactor v2 + rollback-safe compat layer (#1138)" (#1139) ... This reverts commit 75d12c26c5.	2026-04-16 12:26:40 +08:00
Naiyuan Qing	75d12c26c5	feat: workspace URL refactor v2 + rollback-safe compat layer (#1138) ... * Reapply "feat: workspace URL refactor + slug-first API identity (#1131)" (#1137) This reverts commit 9b94914bc8. * compat: legacy URL redirect + localStorage double-write for safe rollback The first attempt at this refactor (#1131) was reverted because existing users on old URLs (/issues, /projects, etc.) hit 404 immediately after deploy, and rolling back left them with empty dashboards — the legacy code reads localStorage["multica_workspace_id"] to attach a workspace to API requests, but the new code had stopped writing that key. Two compat layers added on top of the restored refactor: 1. proxy.ts now intercepts legacy route prefixes (/issues/*, /projects/*, /agents/*, /inbox/*, /my-issues/*, /autopilots/*, /runtimes/*, /skills/*, /settings/*). Logged-in users with a last_workspace_slug cookie are 302'd to /{slug}/{rest}, preserving their deep link. Users without the cookie bounce through / where the landing page picks a workspace client-side. Unauthenticated users go to /login. 2. Both layouts now double-write the workspace id to the legacy localStorage key on every workspace entry. New code ignores this key — it exists solely so that if this PR ever gets reverted again, the legacy build reading the key would still find the correct workspace and avoid the empty-dashboard symptom users saw during the rollback. Net effect: any direction of deploy ↔ rollback is now cache-compatible, and any direction of old bookmark → new route resolves without 404. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(platform): defer rehydrateAllWorkspaceStores to a microtask Same React 19 render-phase restriction that forced setCurrentWorkspace to defer its subscriber notifications. rehydrateAllWorkspaceStores synchronously calls each persist store's rehydrate, which setState()s the store, which schedules updates on any subscribed component. When the workspace layout's render-phase ref guard invoked this, React complained that SearchCommand (a store subscriber) couldn't be re-rendered while WorkspaceLayout was still rendering. Fix: queueMicrotask the rehydrate loop and add a pending-flag guard so rapid workspace switches coalesce into one rehydrate on the final slug. Persist stores tolerate one microtask of staleness — they hold UI preferences, not correctness-critical state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-16 12:23:41 +08:00
Naiyuan Qing	9b94914bc8	Revert "feat: workspace URL refactor + slug-first API identity (#1131)" (#1137) ... This reverts commit 59ace95a1e.	2026-04-16 11:56:15 +08:00
Naiyuan Qing	59ace95a1e	feat: workspace URL refactor + slug-first API identity (#1131) ... * feat: workspace URL refactor + slug-first API identity Make the URL the single source of truth for workspace identity. All workspace-scoped URLs now carry the workspace slug as the first path segment (/{slug}/issues, /{slug}/projects, etc.), matching the industry standard (Linear, Notion, Vercel, GitHub). ## Key architectural changes **URL-driven workspace identity:** - Web routes moved under app/[workspaceSlug]/(dashboard)/ - Desktop routes nested under /:workspaceSlug - paths.ts builder centralises all URL construction - reserved-slugs validation (backend + frontend + DB migration audit) **Slug-first API contract:** - Frontend sends X-Workspace-Slug header (from URL) instead of X-Workspace-ID (UUID) - Backend middleware resolves slug → UUID via GetWorkspaceBySlug, falls back to X-Workspace-ID for CLI/daemon backwards compatibility - WebSocket auth accepts ?workspace_slug query param with SlugResolver callback **State cleanup:** - Deleted: useWorkspaceStore (Zustand mirror), switchWorkspace/hydrateWorkspace/ clearWorkspace, localStorage["multica_workspace_id"], api._workspaceId - useCurrentWorkspace() derives from URL slug + React Query workspace list - useWorkspaceId() is now a bridge hook (no Context, derives from useCurrentWorkspace) - WorkspaceIdProvider removed from DashboardGuard - Paired module vars (slug + UUID) in workspace-storage.ts for non-React consumers **Layout simplified:** - Render-phase ref guard sets workspace context synchronously (no async gate) - DashboardGuard handles auth redirect, loading state, and workspace resolution - Subscriber notifications deferred via queueMicrotask (React 19 compat) - persist namespace uses slug (immutable) instead of UUID ## Issues resolved MUL-43 (share links), MUL-509 (mobile workspace switch), MUL-723 (workspace in URL), MUL-727 (create workspace flash), MUL-728 (delete workspace no-navigate), MUL-820 (sidebar Join not switching) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: resolve code review C3/C4/C5/C6 — desktop deadlock + hardcoded paths C3: Desktop OnboardingGate was calling useCurrentWorkspace() outside WorkspaceSlugProvider → always null → permanent onboarding deadlock. Rewrite to use useQuery(workspaceListOptions()) which reads React Query cache directly without slug context. Remove DashboardGuard from DesktopShell (auth gating handled by AppContent, workspace routing by WorkspaceRouteLayout per-tab). C4: Landing page "Dashboard" links hardcoded /issues (no longer valid). Changed to / — proxy handles redirect to /{lastSlug}/issues. C5: autopilots-page.tsx had one hardcoded /autopilots/${id} link. Changed to wsPaths.autopilotDetail(id). C6: inbox-page.tsx hardcoded /inbox paths. Changed to wsPaths.inbox(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(desktop): wrap shell in WorkspaceSlugProvider from module var AppSidebar calls useWorkspacePaths() → useRequiredWorkspaceSlug() which throws outside WorkspaceSlugProvider. In the desktop shell, the sidebar renders at the shell level (outside any tab's WorkspaceRouteLayout). Fix: DesktopShell reads the current slug via useSyncExternalStore on the workspace-storage singleton. When slug is available, wraps the entire shell in WorkspaceSlugProvider. When null (first mount before any tab's WorkspaceRouteLayout sets it), shows a loading spinner. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(desktop): migrate old tab paths + fix shell slug deadlock Tab store rehydration: old-format paths like "/issues/abc" (missing workspace slug prefix) are reset to "/" so IndexRedirect picks the correct workspace. Detection: if the first segment is a known route name (issues, projects, etc.) rather than a workspace slug, it's an old-format path. Desktop shell: TabContent must always render (not gated behind slug check) so WorkspaceRouteLayout can mount and call setCurrentWorkspace. Only sidebar and shell-level UI (chat, modals, search) gate on slug being present. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-16 11:53:09 +08:00
Jiayuan Zhang	a97bd3da0b	fix(auth): support non-localhost CLI callback for self-hosted VMs (#944) ... The CLI auth callback was hardcoded to localhost, breaking self-hosted setups where the browser runs on a different machine than the CLI. - CLI: derive callback host from configured app URL; bind to 0.0.0.0 when the app URL is not localhost so remote browsers can reach it - Frontend: expand validateCliCallback to accept RFC 1918 private IPs (10.x, 172.16-31.x, 192.168.x) in addition to localhost Closes #923	2026-04-14 13:50:02 +08:00
Bohan Jiang	0d95a7c7ef	fix(auth): increase email verification code resend cooldown to 60s (#912) ... The 10-second cooldown was too short. Increase to 60 seconds in both frontend countdown timer and backend rate limit.	2026-04-14 02:35:34 +08:00
Jiayuan Zhang	8d3cb21c03	fix(auth): detect cookie-based session during CLI setup flow (#904) ... * fix(auth): detect cookie-based session during CLI setup flow When users run `multica setup` after logging into multica.ai, the CLI redirects to the login page which only checked localStorage for an existing session. Since the web app stores auth tokens as HttpOnly cookies (not localStorage), the session was never detected and users had to log in again. Now the login page also tries `api.getMe()` (which sends the HttpOnly cookie automatically) when no localStorage token exists. A new `POST /api/cli-token` endpoint lets cookie-authenticated sessions obtain a bearer token to hand off to the CLI. * fix(auth): prioritise cookie auth over localStorage in CLI setup flow Address code review feedback: cookie-first detection avoids authorising the CLI with a stale or mismatched localStorage token. The useEffect now calls getMe() without a bearer token first (relying on the HttpOnly cookie), and only falls back to localStorage if cookie auth fails. handleCliAuthorize uses an authSourceRef to pick the matching token source — issueCliToken for cookie sessions, localStorage for token sessions — preventing the click handler from re-reading a potentially stale localStorage entry.	2026-04-14 01:46:14 +08:00
Bohan Jiang	418fe4b18e	feat(desktop): implement Google login via deep link (#626) ... Desktop Google login flow: click "Continue with Google" → opens default browser to web login page with platform=desktop → Google OAuth completes → web callback redirects to multica://auth/callback?token=<jwt> → Electron receives deep link, extracts token, completes login. Changes: - Register `multica://` protocol in Electron (main process + builder) - Add single-instance lock with deep link forwarding (macOS + Win/Linux) - Expose `desktopAPI.onAuthToken` and `openExternal` via preload IPC - Add `loginWithToken(token)` to core auth store - Pass `state=platform:desktop` through Google OAuth flow - Web callback detects desktop state and redirects via deep link - Desktop renderer listens for auth token and hydrates session	2026-04-13 15:33:14 +08:00
Naiyuan Qing	3f13605b4c	test(views/login): mock useQueryClient to fix No QueryClient error ... LoginPage now calls useQueryClient() after the workspace list migration. Mock it in packages/views tests so render calls don't need wrapping in QueryClientProvider — setQueryData becomes a no-op spy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-13 14:25:21 +08:00
Naiyuan Qing	c76ba2f58e	fix(workspace): seed React Query cache at all list-acquisition points ... - staleTime: 0 on fetchQuery after leave/delete so fresh data is fetched - setQueryData before switchWorkspace in createWorkspace so sidebar is consistent on first render - seed workspaceKeys.list() cache in login, Google callback, and settings save so the first useQuery(workspaceListOptions()) hit is free - remove dead onError from WorkspaceStoreOptions (used only by the deleted refreshWorkspaces action) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-13 14:00:28 +08:00
Bohan Jiang	6b8afb1d3d	fix(views): use fake timers globally in login-page tests to prevent input-otp timer leak (#642) ... input-otp sets internal timers that fire after jsdom tears down window, causing "ReferenceError: window is not defined" unhandled errors in CI. Using fake timers suite-wide ensures no real timers escape after cleanup.	2026-04-10 16:23:42 +08:00
Naiyuan Qing	cc5e2e1712	test(views): rewrite shared component tests in packages/views ... Move test ownership to where the code lives. LoginPage (28 tests), IssuesPage (6 tests), IssueDetail (10 tests) now tested in packages/views without framework-specific mocks. Old web tests for shared components removed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-10 10:34:49 +08:00
Naiyuan Qing	547b8839b2	refactor(auth): consolidate web login into shared LoginPage component ... Extend shared LoginPage with CLI callback, workspace preference, and token callback props. Web login page reduced from 393 lines to 52-line thin wrapper. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-10 09:45:17 +08:00
Naiyuan Qing	a012d912fe	feat(desktop): add tab system with document.title sync + upgrade shared LoginPage ... Tab system: - Tab store with open/add/close/switch actions - document.title as single source of truth for tab titles (MutationObserver) - Route-level default titles via react-router handle.title + TitleSync - useDocumentTitle hook for dynamic titles (e.g. issue detail) - Tab bar with fixed-width tabs, fade mask, hover-to-close Login upgrade: - Upgrade shared LoginPage with InputOTP, cooldown resend, Google OAuth support - Google OAuth controlled via optional google prop (desktop omits it) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-10 07:05:07 +08:00
Naiyuan Qing	d911cdf5ac	refactor: extract all shared logic to packages — apps are now thin routing shells ... - Add CoreProvider to @multica/core/platform — single component for API/stores/WS/QueryClient init - Delete 13 platform files across web (6) and desktop (7), each app keeps only navigation.tsx - Extract AppSidebar + DashboardLayout to @multica/views/layout - Extract LoginPage to @multica/views/auth - Extract AgentsPage (1,279 lines) to @multica/views/agents (11 files) - Extract InboxPage (468 lines) to @multica/views/inbox (5 files) - Extract SettingsPage + 6 tabs (1,277 lines) to @multica/views/settings (9 files) - Fix AppLink to use forwardRef for Base UI render prop compatibility - Fix Tailwind @source to scan .ts files (status config with bg-info/bg-warning) - Suppress next-themes React 19 script tag warning - Add WebProviders wrapper for Server→Client function passing - Wire all desktop routes to shared views, remove PlaceholderPage - Net: +106 / -4,094 lines Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-09 16:45:41 +08:00